Re: [PATCH 2/2] gitweb: Add support for per project git URLs

[Jakub Narebski <jnareb@gmail.com>]

Junio C Hamano wrote:

> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> It is now possible for project to have individual clone/fetch URLs.
>> They are provided in new file 'cloneurl' added below project's
>> $GIT_DIR directory.
>>
>> If there is no cloneurl file, concatenation of git base URLs with
>> project name is used.
>>
>> This is merge of Jakub Narebski and David Rientjes
>>   gitweb: Show project's git URL on summary page
>> with Aneesh Kumar
>>   gitweb: Add support for cloneurl.
>>   gitweb: Support multiple clone urls
>> patches.
>>
>> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>
> 
> I'll take this for now, but we might want to consider moving
> 'description' and 'cloneurl' information to the config file to
> prevent cluttering.
> 
>         gitweb.description
>         gitweb.giturl
> 
> The URL is not for cloning only, but also for fetch/pull, right?

As of now reading text file is faster than invoking git-repo-config...
although reimplementing _reading_ part of git-repo-config in Perl should be
easy...

cloneurl name is leftover from Aneesh Kumar patch. 

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git