From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: gitweb: Support for snapshots in gitweb
Date: Thu, 17 Aug 2006 11:49:03 +0200 [thread overview]
Message-ID: <ec1e0j$bqr$1@sea.gmane.org> (raw)
In-Reply-To: 44E40CB1.7040805@gmail.com
Aneesh Kumar K.V wrote:
> + print $cgi->header(-type=>'application/x-tar', -Content-Encoding=>'x-gzip',
> + '-content-disposition' => "inline; filename=\"$project.tar.gz\"",
> + -status=> '200 OK');
Wouldn't it be better to put $hash somewhere in the name?
And please remember that $project can contain slashes, so it should be processed
(only basename of $project, perhaps).
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-08-17 9:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-16 0:16 gitweb / cg-export Toby White
2006-08-16 0:23 ` gitweb / cg-export - corrected patch Toby White
2006-08-16 9:54 ` gitweb / cg-export Jakub Narebski
2006-08-16 10:53 ` Aneesh Kumar K.V
2006-08-16 11:32 ` Aneesh Kumar K.V
2006-08-16 20:05 ` Fredrik Kuivinen
2006-08-16 18:01 ` Junio C Hamano
2006-08-17 6:29 ` gitweb: Support for snapshots in gitweb Aneesh Kumar K.V
2006-08-17 7:34 ` Junio C Hamano
2006-08-17 7:48 ` Aneesh Kumar
2006-08-17 9:49 ` Jakub Narebski [this message]
2006-08-16 22:40 ` gitweb / cg-export Martin Waitz
2006-08-16 22:50 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ec1e0j$bqr$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.