diff for duplicates of <ec2a2c6d-b007-bc7c-e01e-2f98024a3d97@users.sourceforge.net> diff --git a/a/1.txt b/N1/1.txt index 303c8e7..9f389eb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -23,7 +23,7 @@ index 1fe2a295db93..a133dfdd869a 100644 if (list_empty(&vidq->queued)) return 0; buf = list_entry(vidq->queued.next, struct viu_buf, vb.queue); -- if (prev = NULL) { +- if (prev == NULL) { + if (!prev) { list_move_tail(&buf->vb.queue, &vidq->active); @@ -32,7 +32,7 @@ index 1fe2a295db93..a133dfdd869a 100644 struct viu_buf *buf = container_of(vb, struct viu_buf, vb); int rc; -- BUG_ON(fh->fmt = NULL); +- BUG_ON(fh->fmt == NULL); + BUG_ON(!fh->fmt); if (fh->width < 48 || fh->width > norm_maxw() || @@ -41,10 +41,10 @@ index 1fe2a295db93..a133dfdd869a 100644 enum v4l2_field field; int maxw, maxh; -- if (dev->ovbuf.base = NULL) +- if (dev->ovbuf.base == NULL) + if (!dev->ovbuf.base) return -EINVAL; -- if (dev->ovfmt = NULL) +- if (dev->ovfmt == NULL) + if (!dev->ovfmt) return -EINVAL; if (win->w.width < 48 || win->w.height < 32) @@ -53,7 +53,7 @@ index 1fe2a295db93..a133dfdd869a 100644 /* check args */ fmt = format_by_fourcc(fb->fmt.pixelformat); -- if (fmt = NULL) +- if (fmt == NULL) + if (!fmt) return -EINVAL; @@ -62,7 +62,7 @@ index 1fe2a295db93..a133dfdd869a 100644 /* Allocate memory for video device */ vdev = video_device_alloc(); -- if (vdev = NULL) { +- if (vdev == NULL) { + if (!vdev) { ret = -ENOMEM; goto err_vdev; diff --git a/a/content_digest b/N1/content_digest index 5ecdfe8..1885ee7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0bf912679-c695-c9c0-a464-3bd3e976fa8a@users.sourceforge.net\0" "From\0SF Markus Elfring <elfring@users.sourceforge.net>\0" "Subject\0[PATCH 3/3] [media] fsl-viu: Adjust six checks for null pointers\0" - "Date\0Fri, 08 Sep 2017 19:46:08 +0000\0" + "Date\0Fri, 8 Sep 2017 21:46:08 +0200\0" "To\0linux-media@vger.kernel.org" Arvind Yadav <arvind.yadav.cs@gmail.com> Bhumika Goyal <bhumirks@gmail.com> @@ -38,7 +38,7 @@ " \t\tif (list_empty(&vidq->queued))\n" " \t\t\treturn 0;\n" " \t\tbuf = list_entry(vidq->queued.next, struct viu_buf, vb.queue);\n" - "-\t\tif (prev = NULL) {\n" + "-\t\tif (prev == NULL) {\n" "+\t\tif (!prev) {\n" " \t\t\tlist_move_tail(&buf->vb.queue, &vidq->active);\n" " \n" @@ -47,7 +47,7 @@ " \tstruct viu_buf *buf = container_of(vb, struct viu_buf, vb);\n" " \tint rc;\n" " \n" - "-\tBUG_ON(fh->fmt = NULL);\n" + "-\tBUG_ON(fh->fmt == NULL);\n" "+\tBUG_ON(!fh->fmt);\n" " \n" " \tif (fh->width < 48 || fh->width > norm_maxw() ||\n" @@ -56,10 +56,10 @@ " \tenum v4l2_field field;\n" " \tint maxw, maxh;\n" " \n" - "-\tif (dev->ovbuf.base = NULL)\n" + "-\tif (dev->ovbuf.base == NULL)\n" "+\tif (!dev->ovbuf.base)\n" " \t\treturn -EINVAL;\n" - "-\tif (dev->ovfmt = NULL)\n" + "-\tif (dev->ovfmt == NULL)\n" "+\tif (!dev->ovfmt)\n" " \t\treturn -EINVAL;\n" " \tif (win->w.width < 48 || win->w.height < 32)\n" @@ -68,7 +68,7 @@ " \n" " \t/* check args */\n" " \tfmt = format_by_fourcc(fb->fmt.pixelformat);\n" - "-\tif (fmt = NULL)\n" + "-\tif (fmt == NULL)\n" "+\tif (!fmt)\n" " \t\treturn -EINVAL;\n" " \n" @@ -77,7 +77,7 @@ " \n" " \t/* Allocate memory for video device */\n" " \tvdev = video_device_alloc();\n" - "-\tif (vdev = NULL) {\n" + "-\tif (vdev == NULL) {\n" "+\tif (!vdev) {\n" " \t\tret = -ENOMEM;\n" " \t\tgoto err_vdev;\n" @@ -85,4 +85,4 @@ "-- \n" 2.14.1 -4cdc968d8e191bb2e0b9ef869bcd8065bbb1c605ac18dfb8aeb5d0f754352057 +8426c9be5589e45b00005a439ba9b2764f8836bfa67888395c271408aa24bcfd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.