Re: [PATCH v3 net] rxrpc: fix race condition in rxrpc_input_packet()

[Eric Dumazet <eric.dumazet@gmail.com>]

On 04/24/2019 01:27 AM, David Howells wrote:

> 
> Acked-by: David Howells <dhowells@redhat.com>
> 

A v4 is coming, since @local could be NULL in rxrpc_lookup_local()
as reported by kbuild test robot <lkp@intel.com> and Julia Lawall <julia.lawall@lip6.fr>


diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c
index 15cf42d5b53a56d8d19cabdc8c2b55156d73d28a..01959db51445ca00e6044d8a849e698c4ab17a33 100644
--- a/net/rxrpc/local_object.c
+++ b/net/rxrpc/local_object.c
@@ -304,7 +304,8 @@ struct rxrpc_local *rxrpc_lookup_local(struct net *net,
        ret = -ENOMEM;
 sock_error:
        mutex_unlock(&rxnet->local_mutex);
-       kfree(local);
+       if (local)
+               call_rcu(&local->rcu, rxrpc_local_rcu);
        _leave(" = %d", ret);
        return ERR_PTR(ret);