From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from m43-7.mailgun.net ([69.72.43.7]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kINHQ-0002cR-6t for ath11k@lists.infradead.org; Wed, 16 Sep 2020 02:34:48 +0000 MIME-Version: 1.0 Date: Wed, 16 Sep 2020 10:33:51 +0800 From: Wen Gong Subject: Re: [PATCH v5 2/8] ath11k: add support for 6GHz radio in driver In-Reply-To: <0b4f6d618388a97082009ba5380afbf5@codeaurora.org> References: <20200603001724.12161-1-pradeepc@codeaurora.org> <20200603001724.12161-3-pradeepc@codeaurora.org> <0b4f6d618388a97082009ba5380afbf5@codeaurora.org> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Pradeep Kumar Chitrapu Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org On 2020-09-16 07:07, Pradeep Kumar Chitrapu wrote: >>>> >>>> - if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP) { >>>> + if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP && >>>> !ar->supports_6ghz) { >>>> band = &ar->mac.sbands[NL80211_BAND_5GHZ]; >>>> ht_cap = cap->band[NL80211_BAND_5GHZ].ht_cap_info; >>>> if (ht_cap_info) >>> After this change, when 6G is support, it removed HT/VHT of 5G band >>> from "iw list", when connect to an 11AX AP of 5G, it used non-HT. >>> caused together with this commit >>> 75e296e9b22aef6fa467523ace87ef623dac1fad(mac80211: simplify and >>> improve HT/VHT/HE disable code) >>> + /* disable HT/VHT/HE if we don't support them */ >>> + if (!sband->ht_cap.ht_supported) { >>> + ifmgd->flags |= IEEE80211_STA_DISABLE_HT; >>> + ifmgd->flags |= IEEE80211_STA_DISABLE_VHT; >>> + ifmgd->flags |= IEEE80211_STA_DISABLE_HE; >>> + } >>> >>> after remove this change in ath11k, it become correct to HE >>> iw wls1 station dump: >>> rx bitrate: 149.7 MBit/s HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0 > Hi Wen, > > Do you have > https://lore.kernel.org/linux-wireless/20200528213443.25687d2695bc.I3f9747c1147480f65445f13eda5c4a5ed4e86757@changeid/? yes, I have it. > >>> >> Hi Pradeep Kumar Chitrapu, >> For QCA6390, it is single_pdev, the pdev support all 2G/5G/6G, >> Is it have 3 pdev/ath11k in your chip for 2G/5G/6G? >> And the pdev/ath11k of 6G have WMI_HOST_WLAN_5G_CAP of >> cap->supported_bands? >>> [...] > Yes, ath11k receives WMI_HOST_WLAN_5G_CAP from firmware for 6G as well. Ok, so it need to add logic for single_pdev for it(single_pdev is added in https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/drivers/net/wireless/ath/ath11k?id=5f859bc02c7bc7a4094bfba0b4ed145edd7661f2, it is later than your 6G patches), maybe I will add it later. -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3718C433E2 for ; Wed, 16 Sep 2020 02:34:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E0B621655 for ; Wed, 16 Sep 2020 02:34:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="PlmAN3A+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbgIPCeL (ORCPT ); Tue, 15 Sep 2020 22:34:11 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:37378 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbgIPCeI (ORCPT ); Tue, 15 Sep 2020 22:34:08 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600223648; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=GuM+5PC5V/VWqovefSsnII13+/3t+zXYKz4BHWRfjAM=; b=PlmAN3A+eGKz5EE6bM30nLSjzUnETA0n3UqT2cexXWdA7afFNFngMWqMYrcvMeHwyRq1Va0C QPFI1E5pPqV+iu2RJjKGCJzXdI3lZRoNM5FbNv2eIl4TjqcS2Mtg9iMyMVFmmj3UPmmGaxH0 eO/g2dqPB0WsY8spCkVUZhBvKhM= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5f61799024954b1631ac76bd (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 16 Sep 2020 02:33:52 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9467EC433FE; Wed, 16 Sep 2020 02:33:52 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0DE5DC433C8; Wed, 16 Sep 2020 02:33:51 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 16 Sep 2020 10:33:51 +0800 From: Wen Gong To: Pradeep Kumar Chitrapu Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH v5 2/8] ath11k: add support for 6GHz radio in driver In-Reply-To: <0b4f6d618388a97082009ba5380afbf5@codeaurora.org> References: <20200603001724.12161-1-pradeepc@codeaurora.org> <20200603001724.12161-3-pradeepc@codeaurora.org> <0b4f6d618388a97082009ba5380afbf5@codeaurora.org> Message-ID: X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-09-16 07:07, Pradeep Kumar Chitrapu wrote: >>>> >>>> - if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP) { >>>> + if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP && >>>> !ar->supports_6ghz) { >>>> band = &ar->mac.sbands[NL80211_BAND_5GHZ]; >>>> ht_cap = cap->band[NL80211_BAND_5GHZ].ht_cap_info; >>>> if (ht_cap_info) >>> After this change, when 6G is support, it removed HT/VHT of 5G band >>> from "iw list", when connect to an 11AX AP of 5G, it used non-HT. >>> caused together with this commit >>> 75e296e9b22aef6fa467523ace87ef623dac1fad(mac80211: simplify and >>> improve HT/VHT/HE disable code) >>> + /* disable HT/VHT/HE if we don't support them */ >>> + if (!sband->ht_cap.ht_supported) { >>> + ifmgd->flags |= IEEE80211_STA_DISABLE_HT; >>> + ifmgd->flags |= IEEE80211_STA_DISABLE_VHT; >>> + ifmgd->flags |= IEEE80211_STA_DISABLE_HE; >>> + } >>> >>> after remove this change in ath11k, it become correct to HE >>> iw wls1 station dump: >>> rx bitrate: 149.7 MBit/s HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0 > Hi Wen, > > Do you have > https://lore.kernel.org/linux-wireless/20200528213443.25687d2695bc.I3f9747c1147480f65445f13eda5c4a5ed4e86757@changeid/? yes, I have it. > >>> >> Hi Pradeep Kumar Chitrapu, >> For QCA6390, it is single_pdev, the pdev support all 2G/5G/6G, >> Is it have 3 pdev/ath11k in your chip for 2G/5G/6G? >> And the pdev/ath11k of 6G have WMI_HOST_WLAN_5G_CAP of >> cap->supported_bands? >>> [...] > Yes, ath11k receives WMI_HOST_WLAN_5G_CAP from firmware for 6G as well. Ok, so it need to add logic for single_pdev for it(single_pdev is added in https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/drivers/net/wireless/ath/ath11k?id=5f859bc02c7bc7a4094bfba0b4ed145edd7661f2, it is later than your 6G patches), maybe I will add it later.