From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Fix timeout handling in i915_gem_shrinker_vmap
Date: Wed, 9 Jan 2019 15:07:34 +0000 [thread overview]
Message-ID: <ec836866-6083-149e-b876-85f24237aa1a@linux.intel.com> (raw)
In-Reply-To: <154704382537.10666.7533806249666251009@skylake-alporthouse-com>
On 09/01/2019 14:23, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-01-09 14:12:47)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> The code tries to grab struct mutex for 5ms every time the unlocked GPU
>> idle wait succeeds. But the GPU idle wait itself is practically unbound
>> which means the 5ms timeout might not be honoured.
>
> The arbitrary timeout is merely advisory. If we hang, we get to recover
> everything we can!
You mean if we hang, eg. take more than 5ms to idle, the function bails
out on the 5ms timeout check, failing to take the lock and free anything? ;)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-09 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 14:12 [PATCH 1/2] drm/i915: Reduce recursive mutex locking from the shrinker Tvrtko Ursulin
2019-01-09 14:12 ` [PATCH 2/2] drm/i915: Fix timeout handling in i915_gem_shrinker_vmap Tvrtko Ursulin
2019-01-09 14:23 ` Chris Wilson
2019-01-09 15:07 ` Tvrtko Ursulin [this message]
2019-01-09 15:13 ` Chris Wilson
2019-01-09 14:31 ` Chris Wilson
2019-01-09 14:52 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Reduce recursive mutex locking from the shrinker Patchwork
2019-01-09 17:51 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-09 20:54 ` [PATCH 1/2] " Chris Wilson
-- strict thread matches above, loose matches on Subject: below --
2019-01-04 14:02 Tvrtko Ursulin
2019-01-04 14:02 ` [PATCH 2/2] drm/i915: Fix timeout handling in i915_gem_shrinker_vmap Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec836866-6083-149e-b876-85f24237aa1a@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.