From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6BF2C61D94 for ; Tue, 21 Nov 2023 14:43:50 +0000 (UTC) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.groups.io with SMTP id smtpd.web10.42307.1700577823759567207 for ; Tue, 21 Nov 2023 06:43:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=uU1RTH+P; spf=pass (domain: linaro.org, ip: 209.85.128.45, mailfrom: neil.armstrong@linaro.org) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4083f61322fso26014915e9.1 for ; Tue, 21 Nov 2023 06:43:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700577822; x=1701182622; darn=groups.io; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=M3yT5RMqJr5jUDcTW5YR1z+r11j9wG67ASkHlOA237Q=; b=uU1RTH+PwepeaOvTdlQu2dWedMnInDJrPPUIDSEHktPX24MqQrumwn/cekNjD6qmSv h4TebzgxZdEgpvZ+HGHhohzMj+Zpi1xkmFn7ktcFj3kqgDVeA8wWUzbbn8yWMQB+w+d0 h1zoTqChkJ8emWRbWYWILlX4AMBqSUN94Bm6BKsh2haLr0NkX300NI00KceJwExn4EJs xqKCmHHB0UZtPCL4ZHah2dv919GI+oZMLeMCAFOZI/hONyBo62gl+cD9/s6n965jReNK I3Z62nLyH/hXJMN0SvZ6oT2WlzD2p0/CpWAt3e6dNcYdNoqR0S6Qf9BH8+81T5p2AzJz Sybw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700577822; x=1701182622; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=M3yT5RMqJr5jUDcTW5YR1z+r11j9wG67ASkHlOA237Q=; b=A19NNFergVPkRPbt3OkicYG7QGPSbBU564RTJmY2XJdV+ti/DRkmedJy+31D2j3Ml7 uZNuOz2KlUv8lPGDe41O9SRLKSxtK92qtf6uTCgKREJPB3HcczlK4sdIdpHQ4A1y8RNF MD08QK+EOVljCDaHgNK6FAYeQJJNFMEZTwe+yM8dfStQ+S+GXcBzRb/LxQZuImN0sFYk 7NxcCs+eyPyv6prOO5/YOP24deXVNXjhBh6omeODcMtG8wvH/5fzdWAE61EMmpFSZSNU qU3tQ0eS0k4B/JowpdNVUEFW8TR/2c0KrXns+9TWR91NTdbIbvHwvaOTgh9iMbPqrZU5 Y4lg== X-Gm-Message-State: AOJu0Yz94NX9vYv4OfEBDSRaIcwqn2A4XpEW2qdNK/lOKs5PfaPdo2sq jPRsNAsiNic7tkcfi/LXGPiHDA== X-Google-Smtp-Source: AGHT+IGoIbqo1bvrbEzq5bBVNBSV34CocXhzq6RBNsPdaq7u2VS5APyDC7bmtALNrSv8qS3JBvu+UA== X-Received: by 2002:a5d:64af:0:b0:331:3c88:6fcd with SMTP id m15-20020a5d64af000000b003313c886fcdmr9027701wrp.53.1700577822071; Tue, 21 Nov 2023 06:43:42 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:2a39:bc19:20b6:16a? ([2a01:e0a:982:cbb0:2a39:bc19:20b6:16a]) by smtp.gmail.com with ESMTPSA id s13-20020a5d6a8d000000b0032fbe5b1e45sm14393887wru.61.2023.11.21.06.43.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Nov 2023 06:43:40 -0800 (PST) Message-ID: Date: Tue, 21 Nov 2023 15:43:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] libretech-cc: Populate SMBIOS information Content-Language: en-US, fr To: Tom Rini Cc: u-boot@lists.denx.de, u-boot-amlogic@groups.io, Ilias Apalodimas , Simon Glass References: <20231120201609.619598-1-trini@konsulko.com> <20231121131551.GP2513409@bill-the-cat> <20231121140929.GV2513409@bill-the-cat> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <20231121140929.GV2513409@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 21 Nov 2023 14:43:50 -0000 X-Groupsio-URL: https://groups.io/g/u-boot-amlogic/message/1880 On 21/11/2023 15:09, Tom Rini wrote: > On Tue, Nov 21, 2023 at 02:46:29PM +0100, Neil Armstrong wrote: >> On 21/11/2023 14:15, Tom Rini wrote: >>> On Tue, Nov 21, 2023 at 10:18:04AM +0100, Neil Armstrong wrote: >>>> Hi Tom, >>>> >>>> On 20/11/2023 21:16, Tom Rini wrote: >>>>> Enable CONFIG_SYSINFO_SMBIOS and populate the nodes so that Linux can >>>>> eventually display this information >>>>> >>>>> Signed-off-by: Tom Rini >>>>> --- >>>>> Posting this as this was the easiest platform for me to test some SMBIOS >>>>> related patches on and I needed to populate the nodes so I could check >>>>> things in dmidecode once Linux was up. >>>> >>>> Sorry to be late a the party, but can't this be dynamically found from DT's compatible & model ? >>>> Since I'll probably need to add this to all boards, it seems like a duplicate of what's already in the DT. >>> >>> Part of the "fun" as to why we have the binding here is that while we >>> could use the top-level model property, there's not a corresponding one >>> for manufacturer. I'm fine ignoring the patch I posted here and having a >>> longer discussion about populating SMBIOS more usefully, globally, as I >>> think has been suggested a time or two. >>> >> >> I'm ok landing it with the same data as from the vendor. >> but couldn't we use the first top-level compatible as default smbios data ? >> >> compatible = "vendor1,board-name", "vendor1,soc-name"; >> >> and translate to: >> >> >> smbios { >> system { >> manufacturer = "vendor1"; >> product = "board-name"; >> }; >> >> baseboard { >> manufacturer = "vendor1"; >> product = "board-name"; >> }; >> >> chassis { >> manufacturer = "vendor1"; >> product = "board-name"; >> }; >> }; >> >> since the vendor name should be already documented in the linux >> bindings, same for the board name. >> And we would be free to add some custom data in the DT if needed. >> >> Anyway, not sure it's the right place to discuss about that ! > > That's essentially > https://patchwork.ozlabs.org/project/uboot/patch/20220906134426.53748-2-ilias.apalodimas@linaro.org/ > which had a bunch of comments on 1/2: > https://patchwork.ozlabs.org/project/uboot/patch/20220906134426.53748-1-ilias.apalodimas@linaro.org/ > > But I think that since then some thoughts on the subject have changed > and that approach might be more welcome now than it was then. > Thanks for the pointer, seems I had the exact same idea. Hope this will be re-spinned, I don't want to add this to the 45 amlogic boards when we have the necessary info already available and documented... Neil