From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37863C55174 for ; Sat, 8 Aug 2026 14:39:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LY3mvYiLSm2ExO8O51zbpt2TAZ0R9mY4D6vI2MXMI20=; b=az5GIhDhRA+nqN qcd2SKwwa53tBkYKkxJhCgiF4YmD59IeTCD9fhKJNaOkZ1+VYPMmJklrEOJ7UmNpxxfN131hlyykd T5wnkdJ5kIb5LKsHXyt6F+gmMRCP+tZ1XfC89rjeCmuukR3eocRRTTdUXOX85mb3xD+c/SEyUTwSZ JnLtFME2gpMs3yfpPrDPj2va6naVOesbskRmWeWc3k3YskVGwHRSU2NnepA/v083cM/GrwHSRYjrz wctzC8g7IFBTOylCgeoutsNnBdfGN8XwZ9V/WAKg7EjjxetlZE+1E4hZW+hG23+14RkfFKFt48z57 cPGTCMNPvKV+KsLsFOFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiCp-00000009SYU-3efr; Sat, 08 Aug 2026 14:39:23 +0000 Received: from mail-pj2-x09.google.com ([2607:f8b0:4864:39::9]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiCm-00000009SXj-3XgG for linux-phy@lists.infradead.org; Sat, 08 Aug 2026 14:39:22 +0000 Received: by mail-pj2-x09.google.com with SMTP id 98e67ed59e1d1-38f0f8ab050so595764a91.0 for ; Sat, 08 Aug 2026 07:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786199960; x=1786804760; darn=lists.infradead.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gLPlagPSnxq9fTONnyyz/3ddba5KQ5Gz9V5u0Vh5tVQ=; b=Idw1GdxC3g34OI9Fq+b24Oqrhrb1zEpulo42qIbYCLQVr518EzbLl0muj59DogpK1T 3/ZNxG4jJnF9cHg9ezwedpCtvrMgToiAjZC8XRdHQgwwwA1gEnk67hYnDWIxrgFbx3t6 1EJEiLYNTcmR2scRfgDl437nWaiW8bVXZ248TfAh9aYtuY8Eu1196yRFy0iH0vLBOgfA Z00wZhgKYrltOK0pRJA/yah+Z/63E4vhtqfE+5Oj2lCQMLe6qs/9GYaRF1BrYSEmQLvO 7GYS7Xk8Lhp+zy3Hbj4o4ZWnBEZ6C2DnCma/qJI9c/+jwkIts0ZoDshbMgkHEx3Pxp+I Zj4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786199960; x=1786804760; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gLPlagPSnxq9fTONnyyz/3ddba5KQ5Gz9V5u0Vh5tVQ=; b=NOuKQv/yLl6B8SYs8cWUnc6cAcVzf9NlZGSt8dZXq6610O7lxWBSDpPogJ4uU0MfTU 891KAC5fyIhR13DbRyXjBWa9ITlhoEGIjRVkX5y03h6fWsSFe2E77PCG4uMhKhxkq+uh oXfPtIQ40UiMhpLLkT7PlmvlbQ/Fs6G2BXhJs7eLXMb0nQ3eGEOtFkzZ0pPvuVPxthYK vTdnI3LQxwLdYVsTXM68MKbrYkuBgeyCMm2LBherXQb9swsWgpUq/t2ncT1cQqUNHDqx GBZY4QAmhsUtzfsfX3p7cWSPuMzt3dAWvXk6GymDnEOtP6ehumJXRw1kz119fu/QoUem i1aA== X-Forwarded-Encrypted: i=1; AHgh+Rom0qhZC6TNco1ohm/b48rTMS7CYlnCLAK1rGufEXrusIB2Yx0J5UZjGxUiDrUrWQV9D6YILfdEjmA=@lists.infradead.org X-Gm-Message-State: AOJu0YxDnrYP7LP+PNkhf58OwHLevel2EoWgRTykPzrfZ6n8u5K1iLyt osA1JDlfSPAAoE9rFaoDvMQXmD5NpOKxQtEA7BrBJpMiVepS94j8LN/F X-Gm-Gg: AR+sD12jPFSPa3+MAP+/zuSHNOnFa7zHKOXbNnzHxrqvnMbklOpfBjdmjQ8F6QV9fWR sMW0phL26Qwvy17q0WuGGL1XA1YnlfVqRDDh4TpKNsmzn+xjgMgolpsQBp54piQ+T+aAeuVHAq+ tZlFwWjlgxIUUgfh7S4EUw7ZIr6GdX5o+vUBTMg2OyBC3UWlnTI6olpPwb9gOGgwGdymLGX6XxJ crquTiwOeIZE7YFrjiHcdj+ZTks837wnye5uFU8/nzqspy642rUZTvO/8wGOPLIVGBa2yOPwJHO hV1ddwE8MUN96rV+pPqKpC/qNhYcs9dTrOfE7BTRLho1t4OBTuRLELQjjPr0jan9g+ZhuUChM5x uTCFHhyQky8YeLJFY7VlcrJezZDOG4aFocD8by9Ky+n/+acmZCisLvnZOqmJ+OJm5piOVqLvCTX lpZSG4yxZEPHO0Btmh8vhpe/cB+hdejhLmteD0zNQ= X-Received: by 2002:a17:90b:2585:b0:38e:bbf1:de34 with SMTP id 98e67ed59e1d1-39261fdab5amr13832835a91.7.1786199959787; Sat, 08 Aug 2026 07:39:19 -0700 (PDT) Received: from localhost ([2403:2c80:17:1e::20db]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fd95794sm6424491a91.7.2026.08.08.07.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 07:39:19 -0700 (PDT) Date: Sat, 08 Aug 2026 22:39:16 +0800 Message-ID: From: Cody Kang To: Rob Herring Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Vinod Koul , Neil Armstrong , Haylen Chu , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RESEND 03/17] dt-bindings: display: spacemit: add K3 Innosilicon DP/eDP controller In-Reply-To: <20260807230404.GA2211679-robh@kernel.org> References: <20260725-k3-display-v1-0-6de34d80e86c@gmail.com> <20260725-k3-display-v1-3-6de34d80e86c@gmail.com> <20260807230404.GA2211679-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260808_073920_890070_FD9D2CE7 X-CRM114-Status: GOOD ( 20.69 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Rob, On Fri, 07 Aug 2026 18:04:04 -0500, Rob Herring wrote: > On Sat, Jul 25, 2026 at 12:51:12AM -0400, Cody Kang wrote: > > Both K3 instances are the same IP and share one compatible; which one > > behaves as eDP is decided by what its downstream port is wired to, not by > > which register window it sits in, so the binding does not distinguish them. > > > > Signed-off-by: Cody Kang > > --- > > .../display/spacemit/spacemit,k3-inno-dp.yaml | 140 +++++++++++++++++++++ > > 1 file changed, 140 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml > > new file mode 100644 > > index 000000000000..865ea310daaf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml > > @@ -0,0 +1,140 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/spacemit/spacemit,k3-inno-dp.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SpacemiT K3 Innosilicon DisplayPort / embedded DisplayPort Controller > > + > > +maintainers: > > + - Cody Kang > > + > > +description: > > + Innosilicon DisplayPort transmit controller integrated in the SpacemiT K3 > > + SoC. The K3 has two instances of the same block sharing one compatible; > > + each acts as embedded or external DisplayPort depending on whether its > > + output port drives a panel or a connector. > > + > > +properties: > > + compatible: > > + const: spacemit,k3-inno-dp > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + description: Link and hot-plug events. > > + > > + clocks: > > + items: > > + - description: Pixel clock for the controller. > > + - description: > > + Pixel clock generated by the DP PHY PLL; the pixel clock above is > > + parented onto it in use. > > + > > + clock-names: > > + items: > > + - const: pxclk > > + - const: pll > > + > > + resets: > > + maxItems: 1 > > + description: Controller-wide reset signal. > > + > > + phys: > > + maxItems: 1 > > + description: Phandle to the K3 Innosilicon DP PHY. > > + > > + phy-names: > > + items: > > + - const: dp > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Video input from the DPU. > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Output to the panel or to the DisplayPort connector. > > + > > + required: > > + - port@0 > > Shouldn't port@1 be required too? Thanks for the review. Yes, will make port@1 required in v2 and describe the DP connector on the board side (dp-connector) so the graph is complete. > Otherwise, > > Reviewed-by: Rob Herring (Arm) Thanks! Will pick up your Reviewed-by with that change in v2. Cody -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF5E1C5AC67 for ; Sat, 8 Aug 2026 14:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LYglee6Js4paxlw4cNsDt1Ztpw/OVLs89zkW2cxG4sU=; b=E6zCI1fUFGl7jh I5j93DvxALsmaWJgr+J3SZ+LOErrAB4ig9I3/i65IDMzbNMYu3pwJ++GHtbgHiGPQbFJQ5AkdYPvn sXHNSZSRKxpqIyAuXkAjUhwyy4++LVYgF0ErILsllVzcqxcTqqe0kpAz3b6IOz3aMyqBymcGcFq6w 4ffyeyoCFF5zNEOpWmTuMYoaG8k4zEVG2IVJRYUVz8JOez3Ht8uzL1iklcAanXJReVbkhZ4HK0DLC qgeBY+q3qrUhlka+E1cY7Ej8ibus4HE3kCDksGjb0KOyVxODciLX991VJSN4kBnuin5bwVO5JjWjL CNwNoOx6aE6YsrBtMUBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiCp-00000009SYY-3w9v; Sat, 08 Aug 2026 14:39:23 +0000 Received: from mail-pj2-x09.google.com ([2607:f8b0:4864:39::9]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiCm-00000009SXk-3Y4V for linux-riscv@lists.infradead.org; Sat, 08 Aug 2026 14:39:22 +0000 Received: by mail-pj2-x09.google.com with SMTP id 98e67ed59e1d1-38f0f8ab050so595763a91.0 for ; Sat, 08 Aug 2026 07:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786199960; x=1786804760; darn=lists.infradead.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gLPlagPSnxq9fTONnyyz/3ddba5KQ5Gz9V5u0Vh5tVQ=; b=Idw1GdxC3g34OI9Fq+b24Oqrhrb1zEpulo42qIbYCLQVr518EzbLl0muj59DogpK1T 3/ZNxG4jJnF9cHg9ezwedpCtvrMgToiAjZC8XRdHQgwwwA1gEnk67hYnDWIxrgFbx3t6 1EJEiLYNTcmR2scRfgDl437nWaiW8bVXZ248TfAh9aYtuY8Eu1196yRFy0iH0vLBOgfA Z00wZhgKYrltOK0pRJA/yah+Z/63E4vhtqfE+5Oj2lCQMLe6qs/9GYaRF1BrYSEmQLvO 7GYS7Xk8Lhp+zy3Hbj4o4ZWnBEZ6C2DnCma/qJI9c/+jwkIts0ZoDshbMgkHEx3Pxp+I Zj4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786199960; x=1786804760; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gLPlagPSnxq9fTONnyyz/3ddba5KQ5Gz9V5u0Vh5tVQ=; b=N74zmo/Mz265UekDmXIiJaCzXCl2mnqBlrX8doPpcZCj7iYvhCQRHRQ4B68FFTnukm iIUkuXJjcj3HFnAgM9RoOoeafFO2HZLabYUOBxq5YaOD9jT3eZuh+GQDyKx0gFA1Otjp R9uzq4RCu2WuUMm+jl9PVmv7/+KaHuq2yfdKq9t6rZF9MXXlt1rDhi8HXCVWmwzJVt1X p0tfoyCNVtukckGakyRbENdJDacjr8t9LhDXwdWL2TVSLc1PO1BkdvpXmuNb1pcFimD5 HzO8UtKrmwGI3lDvjJtw4urlWBt7ei9+2xlxKt0rqeft+0V6jp4HXdPeArSlBynE5DDJ n3aw== X-Forwarded-Encrypted: i=1; AHgh+Ro8cVsbl15sX2lh+MLclULEyb+kW4FuFAmul9ajDYQZKIoC3vDiadTvoK0YFb75e4u1DAYSVz/8TyeUpg==@lists.infradead.org X-Gm-Message-State: AOJu0Yy3os1aGw9r9+3x4khVCYPQGEHaqVyLNBljctQY6FB2IJ9wymlH wZW0yhXL+WIV0aRSG0KBq9Qhhe23Mac2ZM3IUcYEApFl26E2X2HjJaDW X-Gm-Gg: AR+sD13o7qPQjzWv9ewJwA6WcsrBvL1/GTukOEcq93e2soTbwpb3ZeY87JPDRw3mGOg lQAD6RcAQxzVQ27YXa6iFo9sRSQ7LqBNKuPBA1WlGFCO92ZnoGPEQrlEGVmILwYbGZtRFoaHvxB vgPQ7tEsEEmHcL/0LVqAnno1UYDeCsKJtAKCP6fqMmZc1BFjKhVB18nC04QmsDWNBuL6ipyyQvu iVJrGnHUZgkBrmefopxX0jI6KOSAtPWBbmTcgwg11MdmZUFR5IPQ5QzDzasgleOzFFAgadcq0Pv H58iBay3ygorPtwDwsUZkAO92qygQx+lFE3i68d3oZpsDp2cdzKZwnT6EtXpgsFAFFM2TkNQXqF ICoqVIYokrMUTA8YIQb7OFGTjRCRdq3O967IUbZ4OnLD86cgNnP2wcz2Mcjloz6lSVzC6oanMRb ScgBM+nsfLMC9T8V0y5tE1Mln1+cAv8EJxEkNV88s= X-Received: by 2002:a17:90b:2585:b0:38e:bbf1:de34 with SMTP id 98e67ed59e1d1-39261fdab5amr13832835a91.7.1786199959787; Sat, 08 Aug 2026 07:39:19 -0700 (PDT) Received: from localhost ([2403:2c80:17:1e::20db]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fd95794sm6424491a91.7.2026.08.08.07.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 07:39:19 -0700 (PDT) Date: Sat, 08 Aug 2026 22:39:16 +0800 Message-ID: From: Cody Kang To: Rob Herring Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Vinod Koul , Neil Armstrong , Haylen Chu , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RESEND 03/17] dt-bindings: display: spacemit: add K3 Innosilicon DP/eDP controller In-Reply-To: <20260807230404.GA2211679-robh@kernel.org> References: <20260725-k3-display-v1-0-6de34d80e86c@gmail.com> <20260725-k3-display-v1-3-6de34d80e86c@gmail.com> <20260807230404.GA2211679-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260808_073920_890547_F7FA4C1D X-CRM114-Status: GOOD ( 20.60 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Rob, On Fri, 07 Aug 2026 18:04:04 -0500, Rob Herring wrote: > On Sat, Jul 25, 2026 at 12:51:12AM -0400, Cody Kang wrote: > > Both K3 instances are the same IP and share one compatible; which one > > behaves as eDP is decided by what its downstream port is wired to, not by > > which register window it sits in, so the binding does not distinguish them. > > > > Signed-off-by: Cody Kang > > --- > > .../display/spacemit/spacemit,k3-inno-dp.yaml | 140 +++++++++++++++++++++ > > 1 file changed, 140 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml > > new file mode 100644 > > index 000000000000..865ea310daaf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml > > @@ -0,0 +1,140 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/spacemit/spacemit,k3-inno-dp.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SpacemiT K3 Innosilicon DisplayPort / embedded DisplayPort Controller > > + > > +maintainers: > > + - Cody Kang > > + > > +description: > > + Innosilicon DisplayPort transmit controller integrated in the SpacemiT K3 > > + SoC. The K3 has two instances of the same block sharing one compatible; > > + each acts as embedded or external DisplayPort depending on whether its > > + output port drives a panel or a connector. > > + > > +properties: > > + compatible: > > + const: spacemit,k3-inno-dp > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + description: Link and hot-plug events. > > + > > + clocks: > > + items: > > + - description: Pixel clock for the controller. > > + - description: > > + Pixel clock generated by the DP PHY PLL; the pixel clock above is > > + parented onto it in use. > > + > > + clock-names: > > + items: > > + - const: pxclk > > + - const: pll > > + > > + resets: > > + maxItems: 1 > > + description: Controller-wide reset signal. > > + > > + phys: > > + maxItems: 1 > > + description: Phandle to the K3 Innosilicon DP PHY. > > + > > + phy-names: > > + items: > > + - const: dp > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Video input from the DPU. > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Output to the panel or to the DisplayPort connector. > > + > > + required: > > + - port@0 > > Shouldn't port@1 be required too? Thanks for the review. Yes, will make port@1 required in v2 and describe the DP connector on the board side (dp-connector) so the graph is complete. > Otherwise, > > Reviewed-by: Rob Herring (Arm) Thanks! Will pick up your Reviewed-by with that change in v2. Cody _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f9.google.com (mail-pj2-f9.google.com [74.125.227.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A9A1277CA5 for ; Sat, 8 Aug 2026 14:39:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.137 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786199961; cv=none; b=TGE9afQ8Aa+npD5wZZK+epimzvbUpOdGuAf3e+UL2RKyb5/CxP3IN3qxXxc/doz8lg3t6lVkQEuJcE3G75AnzJzWZVZkUAPD+hZErjZAk+Swv/sp1D8n3EpkQAYXOceF5HzVwOEHCftgc7dRFi0iRtIENgPbGa/I3RaEOXB6OLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786199961; c=relaxed/simple; bh=GNZdbMnUJ+VqGa8a7gNHiTQSeSgxpLKBAsS0DNjAnew=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=nGPriz9Y2fePO2YXNNRQvwzc+qOkQnuq5/7PotZuO8+xzBsaGpwvVke5hcLc+fIPGyL1lLGrlVb3OG6Oqjl+Ne9zONFfz46JYReGYtymuQUNJBg1kY8D5amMRz1jwvWyqUxXQIqHL+7ysowBwyVheS3ja55DIEM/n3qZ8ZTI0dM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D26+vpQv; arc=none smtp.client-ip=74.125.227.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D26+vpQv" Received: by mail-pj2-f9.google.com with SMTP id 98e67ed59e1d1-38f0f8ab050so595758a91.0 for ; Sat, 08 Aug 2026 07:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786199960; x=1786804760; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gLPlagPSnxq9fTONnyyz/3ddba5KQ5Gz9V5u0Vh5tVQ=; b=D26+vpQvhZwWjfur4gExF4hKMVinXGQ8obSX9UAbU8f4ld5iF9Pm94eQ3TZBsRHat7 fGS8VUOKSbooARdm29094mB/TDc/gC2+RZoXTwImtkQ8TEpMNSezTACtE6BNV7omosgf ZG5bxKg9W7DpJVstLlKmpbPpC21cwjUnRj8TD/GOSNbucSFcdyfoURNJNBxyFS6pkWyW uDAjqu9Z5F2Db2j/lxJH7Meii1iltQKblF9l/8NeDat4mjRWXXGxx4jo4c28ilqXXYtj kt4tVac3ruTmKa54v8N8oJVbk3VZyEwKn9VVinio5Yn2yh84uiN2iQ+En55SWY5K9r3Q OYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786199960; x=1786804760; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gLPlagPSnxq9fTONnyyz/3ddba5KQ5Gz9V5u0Vh5tVQ=; b=EFNnZc93PqFogJ+6hTWJqPvdMTklCT+yGHjh9mgZQDe+8vQIbGhielbf0ZGwESqY/Y bKrGGVU4arYvUnrWZgtmQO/780BbTehlWdwQRFRJTdxuZkaTfKOaAYeFPE1QIMp1R6s7 O83sj68WIZ4AFRFphoBTfrP7lg8GQjrpXko+HhJyinJ3KXkvBMAgp3Ok+0sK4oydHKJJ WxFtED9c4f7D3ikLywflX6CbN/CC+eMTQFitFLNZ8EgyrUyawTaVJkhT0xn9VZ8EbPQX +/dZX5Q9oPhvOBr/PtoJmFQzXg/NLIN8viH+z2amRIIVg6yFFo/UNARk+oL9fbkNqJO5 BMDw== X-Forwarded-Encrypted: i=1; AHgh+RqC9IfuaUJ5tiSi7SQs5EDj8OcBPXQmkh8UPZpoMYKktggbyZNq5O6bQOFd1Gv9XMaavyRo+Kc1aRHT@vger.kernel.org X-Gm-Message-State: AOJu0YyU9UmMun1SKdP8FuLs1+FUf3KSOVwH2DAm1YrbobMdckMPXTo5 5zbJF0cnbOvXS79W3Yzw6T5fLTS7QATqJ9rHsjrSObYRrUa+6B2ZAOIg X-Gm-Gg: AR+sD11gOn5JunkkM58gVoec2l8OC66nnTSFxU5AjZuHpyd5z1Z0b3cVofAlmBB+9Xw Lcj3pD5KZEJYyeUUjklPs8u8nZ+HjvDoSEBhqFqig9NIk4wiZULdww63XmXwlCNXI9QOjCeO4yj nwVPr3AIuaM4iU3imjroJaQY2tOPurONVwj7ER72kO3LOPwIfAYbweCAAEcAQr0f1vtNHchnK2D t9oKGbfytzxaLIKLaySMpuubPmSZKeb2+m3kz69NOKrfAB0jYC6KlaPQCtC2BcLWJF1n/thUDQu phoTtQQBLfCVn5nE+aVmg9STyhKEVckFmsVzp+14WMN4OjKii/wj0dmOYVcpeCWUBjYNxQdpFh3 T4AA59eBL9PXKO/+4U6UMqBRvSszYFE72xwBnIERfR62aHBCQyegvUpMlSwnlX054HTtaBgbYKG Viv3Z4/ZfF85sVMfQn+vWyEZOaNLnozTYHIiMGujk= X-Received: by 2002:a17:90b:2585:b0:38e:bbf1:de34 with SMTP id 98e67ed59e1d1-39261fdab5amr13832835a91.7.1786199959787; Sat, 08 Aug 2026 07:39:19 -0700 (PDT) Received: from localhost ([2403:2c80:17:1e::20db]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fd95794sm6424491a91.7.2026.08.08.07.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 07:39:19 -0700 (PDT) Date: Sat, 08 Aug 2026 22:39:16 +0800 Message-ID: From: Cody Kang To: Rob Herring Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Vinod Koul , Neil Armstrong , Haylen Chu , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RESEND 03/17] dt-bindings: display: spacemit: add K3 Innosilicon DP/eDP controller In-Reply-To: <20260807230404.GA2211679-robh@kernel.org> References: <20260725-k3-display-v1-0-6de34d80e86c@gmail.com> <20260725-k3-display-v1-3-6de34d80e86c@gmail.com> <20260807230404.GA2211679-robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Hi Rob, On Fri, 07 Aug 2026 18:04:04 -0500, Rob Herring wrote: > On Sat, Jul 25, 2026 at 12:51:12AM -0400, Cody Kang wrote: > > Both K3 instances are the same IP and share one compatible; which one > > behaves as eDP is decided by what its downstream port is wired to, not by > > which register window it sits in, so the binding does not distinguish them. > > > > Signed-off-by: Cody Kang > > --- > > .../display/spacemit/spacemit,k3-inno-dp.yaml | 140 +++++++++++++++++++++ > > 1 file changed, 140 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml > > new file mode 100644 > > index 000000000000..865ea310daaf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml > > @@ -0,0 +1,140 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/spacemit/spacemit,k3-inno-dp.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SpacemiT K3 Innosilicon DisplayPort / embedded DisplayPort Controller > > + > > +maintainers: > > + - Cody Kang > > + > > +description: > > + Innosilicon DisplayPort transmit controller integrated in the SpacemiT K3 > > + SoC. The K3 has two instances of the same block sharing one compatible; > > + each acts as embedded or external DisplayPort depending on whether its > > + output port drives a panel or a connector. > > + > > +properties: > > + compatible: > > + const: spacemit,k3-inno-dp > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + description: Link and hot-plug events. > > + > > + clocks: > > + items: > > + - description: Pixel clock for the controller. > > + - description: > > + Pixel clock generated by the DP PHY PLL; the pixel clock above is > > + parented onto it in use. > > + > > + clock-names: > > + items: > > + - const: pxclk > > + - const: pll > > + > > + resets: > > + maxItems: 1 > > + description: Controller-wide reset signal. > > + > > + phys: > > + maxItems: 1 > > + description: Phandle to the K3 Innosilicon DP PHY. > > + > > + phy-names: > > + items: > > + - const: dp > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Video input from the DPU. > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Output to the panel or to the DisplayPort connector. > > + > > + required: > > + - port@0 > > Shouldn't port@1 be required too? Thanks for the review. Yes, will make port@1 required in v2 and describe the DP connector on the board side (dp-connector) so the graph is complete. > Otherwise, > > Reviewed-by: Rob Herring (Arm) Thanks! Will pick up your Reviewed-by with that change in v2. Cody