From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 401E1C2BA15 for ; Mon, 17 Jun 2024 13:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bJ9yi4NmAT8Fp87Y4Xh/Q1F1hAfSsaP6QnGQhNJA8so=; b=ML9PuQ1f7036Dm mULmfAcVQ1BFN1kekUYKjAqTOgTaLqkxw11oIQ4IlMJIpeuyY0xDhyJiMdVdmCB0Mtt1Wh0lwbGXh vQBu4W6ySAQ78G/ftoPtK+bYgIfw7KGp1EbG2/VF5KpXGArzCPiP8FpJVaudoKe3RzNuNioo5Zrl2 kxvQYBFQHL8TshQiO0GORCwgCQRFR3nbWXWHwJCWHL6aEmGulh/G+i9kURut+a+iLVwX7Y4Sot1bf ZgphHCmbfomJ1NMVocOREK+6LkE5/tQmnRAWudQGYIPzbREql7e7bTgdyrnXBwPGQxbPVaH4cjVi3 JUaLO/3cXwBnvX2HcfoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCe4-0000000AuyG-2Cgs; Mon, 17 Jun 2024 13:43:40 +0000 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJCe1-0000000AuwY-1vL4 for linux-rockchip@lists.infradead.org; Mon, 17 Jun 2024 13:43:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1718631814; bh=wPdlMn4BkQJ1i+WvuHCmNwqJAwmoMMcYl971v9DomFs=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=S3HkmBr6agUfW95p6IZ5XRCZ8SXGakexEfxerssqNteb6ERE+9IrPn+eIzXQ3pPwT QRQcBuxxe/IdVRooZRu4o6xbj88PsaPT0WRD7HzPGgSeFCnVoavP/DQJB7t8eKL9gP GEClxw+4Gn1LePmGb7jSe7RM4T09+hfsHST1NeqyQDdJOHvOdbpbP0LVG7K7j/DxS+ gc2UJuy5w7VXuaOlPt+5WIvUXr4S97awQsFm5m1SjMBFPkxpnEP0rzHEhR5UPX99je f417DkkCcpc9mkI4RuDtBywU40yoThKahWTcPehbESaQIyfFwJhaHm4gPpQYvorx3E jb7T1pIkbGI/Q== Received: from nicolas-tpx395.localdomain (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 6CB9E3782121; Mon, 17 Jun 2024 13:43:32 +0000 (UTC) Message-ID: Subject: Re: [PATCH v4 00/11] media: rkvdec: Add H.264 High 10 and 4:2:2 profile support From: Nicolas Dufresne To: Diederik de Haas , Ezequiel Garcia , Mauro Carvalho Chehab , Hans Verkuil , linux-rockchip@lists.infradead.org, Jonas Karlman , Andy Yan Cc: Alex Bee , Benjamin Gaignard , Sebastian Fricke , Christopher Obbard , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Mon, 17 Jun 2024 09:43:29 -0400 In-Reply-To: <122755518.lCnTqr06ca@bagend> References: <20231105165521.3592037-1-jonas@kwiboo.se> <122755518.lCnTqr06ca@bagend> User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_064338_027207_15EF4A8E X-CRM114-Status: GOOD ( 34.08 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGksCgpMZSBkaW1hbmNoZSAxNiBqdWluIDIwMjQgw6AgMTE6NDcgKzAyMDAsIERpZWRlcmlrIGRl IEhhYXMgYSDDqWNyaXTCoDoKPiBPbiBTdW5kYXksIDUgTm92ZW1iZXIgMjAyMyAxNzo1NDo1OSBD RVNUIEpvbmFzIEthcmxtYW4gd3JvdGU6Cj4gPiBUaGlzIGlzIGEgcmV2aXZhbCBvZiBhIDMgeWVh ciBvbGQgc2VyaWVzIFsxXSBub3cgdGhhdCBOVjE1L05WMjAvTlYzMCBzdXBwb3J0Cj4gPiBmb3Ig ZGlzcGxheSBkcml2ZXIgaGF2ZSBsYW5kZWQgaW4gbWFpbmxpbmUgdHJlZS4KPiA+IAo+ID4gVGhp cyBzZXJpZXMgYWRkcyBILjI2NCBIaWdoIDEwIGFuZCA0OjI6MiBwcm9maWxlIHN1cHBvcnQgdG8g dGhlIFJvY2tjaGlwCj4gPiBWaWRlbyBEZWNvZGVyIGRyaXZlci4KPiA+IAo+ID4gUGF0Y2ggMSBh ZGRzIGhlbHBlcnMgZm9yIGNhbGN1bGF0aW5nIHBsYW5lIGJ5dGVzcGVybGluZSBhbmQgc2l6ZWlt YWdlLgo+ID4gUGF0Y2ggMiBhZGRzIHR3byBuZXcgcGl4ZWxmb3JtYXRzIGZvciBzZW1pLXBsYW5l ciAxMC1iaXQgNDoyOjAvNDoyOjIgWVVWLgo+ID4gCj4gPiBQYXRjaCAzIGNoYW5nZSB0byB1c2Ug Ynl0ZXNwZXJsaW5lIGFuZCBidWZmZXIgaGVpZ2h0IHRvIGNvbmZpZ3VyZSBzdHJpZGVzLgo+ID4g UGF0Y2ggNCBjaGFuZ2UgdG8gdXNlIHZhbHVlcyBmcm9tIFNQUy9QUFMgY29udHJvbCB0byBjb25m aWd1cmUgdGhlIEhXLgo+ID4gUGF0Y2ggNSByZW1vdmUgYW4gdW5uZWNlc3NhcnkgY2FsbCB0byB2 YWxpZGF0ZSBzcHMgYXQgc3RyZWFtaW5nIHN0YXJ0Lgo+ID4gCj4gPiBQYXRjaCA2LTEwIHJlZmFj dG9yIGNvZGUgdG8gc3VwcG9ydCBmaWx0ZXJpbmcgb2YgQ0FQVVRSRSBmb3JtYXRzIGJhc2VkCj4g PiBvbiB0aGUgaW1hZ2UgZm9ybWF0IHJldHVybmVkIGZyb20gYSBnZXRfaW1hZ2VfZm10IG9wcy4K PiA+IAo+ID4gUGF0Y2ggMTEgYWRkcyBmaW5hbCBiaXRzIHRvIHN1cHBvcnQgSC4yNjQgSGlnaCAx MCBhbmQgNDoyOjIgcHJvZmlsZXMuCj4gPiAKPiA+IFRlc3RlZCBvbiBhIFJPQ0sgUGkgNCAoUksz Mzk5KSBhbmQgUm9jazY0IChSSzMzMjgpOgo+ID4gCj4gPiAgIHY0bDItY29tcGxpYW5jZSAxLjI0 LjEsIDY0IGJpdHMsIDY0LWJpdCB0aW1lX3QKPiA+ICAgLi4uCj4gPiAgIFRvdGFsIGZvciBya3Zk ZWMgZGV2aWNlIC9kZXYvdmlkZW8xOiA0NiwgU3VjY2VlZGVkOiA0NiwgRmFpbGVkOiAwLAo+ID4g V2FybmluZ3M6IDAKPiA+IAo+ID4gICBSdW5uaW5nIHRlc3Qgc3VpdGUgSlZULUZSLUVYVCB3aXRo IGRlY29kZXIgRkZtcGVnLUguMjY0LVY0TDItcmVxdWVzdAo+ID4gICAuLi4KPiA+ICAgUmFuIDY1 LzY5IHRlc3RzIHN1Y2Nlc3NmdWxseQo+ID4gCj4gPiAgIFJ1bm5pbmcgdGVzdCBzdWl0ZSBKVlQt QVZDX1YxIHdpdGggZGVjb2RlciBGRm1wZWctSC4yNjQtVjRMMi1yZXF1ZXN0Cj4gPiAgIC4uLgo+ ID4gICBSYW4gMTI3LzEzNSB0ZXN0cyBzdWNjZXNzZnVsbHkKPiA+IAo+ID4gQmVmb3JlIHRoaXMg c2VyaWVzOgo+ID4gCj4gPiAgIFJ1bm5pbmcgdGVzdCBzdWl0ZSBKVlQtRlItRVhUIHdpdGggZGVj b2RlciBGRm1wZWctSC4yNjQtVjRMMi1yZXF1ZXN0Cj4gPiAgIC4uLgo+ID4gICBSYW4gNDQvNjkg dGVzdHMgc3VjY2Vzc2Z1bGx5Cj4gPiAKPiA+IC4uLgo+ID4gCj4gPiBGb2xsb3dpbmcgY29tbWl0 cyBhZGRzIHN1cHBvcnQgZm9yIE5WMTUvTlYyMC9OVjMwIHRvIFZPUCBkcml2ZXI6Cj4gPiA3Mjhj MTViNGI1ZjMgKCJkcm0vZm91cmNjOiBBZGQgTlYyMCBhbmQgTlYzMCBZVVYgZm9ybWF0cyIpCj4g PiBkNGIzODQyMjg1NjIgKCJkcm0vcm9ja2NoaXA6IHZvcDogQWRkIE5WMTUsIE5WMjAgYW5kIE5W MzAgc3VwcG9ydCIpCj4gPiAKPiA+IFRvIGZ1bGx5IHJ1bnRpbWUgdGVzdCB0aGlzIHNlcmllcyB5 b3UgbWF5IG5lZWQgYWJvdmUgZHJtIGNvbW1pdHMgYW5kIGZmbXBlZwo+ID4gcGF0Y2hlcyBmcm9t IFsyXSwgdGhpcyBzZXJpZXMgYW5kIGRybSBwYXRjaGVzIGlzIGFsc28gYXZhaWxhYmxlIGF0IFsz XS4KPiA+IAo+ID4gWzFdCj4gPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1tZWRpYS8y MDIwMDcwNjIxNTQzMC4yMjg1OS0xLWpvbmFzQGt3aWJvby5zZS8KPiA+IFsyXSBodHRwczovL2dp dGh1Yi5jb20vS3dpYm9vL0ZGbXBlZy9jb21taXRzL3Y0bDItcmVxdWVzdC1uNi4xLWRldi8gWzNd Cj4gPiBodHRwczovL2dpdGh1Yi5jb20vS3dpYm9vL2xpbnV4LXJvY2tjaGlwL2NvbW1pdHMvbGlu dXh0di1ya3ZkZWMtaGlnaC0xMC12NC8KPiA+IFs0XSBodHRwczovL2dpc3QuZ2l0aHViLmNvbS9L d2lib28vZjRhYzE1NTc2YjJjNzI4ODdhZTJiYzVkNThiNWM4NjUgWzVdCj4gPiBodHRwczovL2dp c3QuZ2l0aHViLmNvbS9Ld2lib28vNDU5YTFjOGYxZGNiNTZlNDVkYzdhN2EyOWNjMjhhZGYKPiAK PiBSZXZpdmluZyB0aGlzIG9sZCB0aHJlYWQgbm93IHRoYXQgcmt2ZGVjMiAnc3R1ZmYnIGVtZXJn ZWQuCj4gSSBoYXZlIChhY3R1YWxseSkgZG9uZSBxdWl0ZSBzb21lIHRlc3RzIHdpdGggdGhpcyAo YW5kICJtZWRpYTogcmt2ZGVjOiBBZGQgCj4gSEVWQyBiYWNrZW5kIiBwYXRjaCBzZXQpIGFuZCB0 aGV5IGhhdmUgYmVlbiBwYXJ0IG9mIG15IGtlcm5lbCBidWlsZHMgZXZlciAKPiBzaW5jZS4KPiBJ IF90aGlua18sIGJ1dCBkb24ndCBrbm93LCB0aGF0IGlzIHJlbGV2YW50IGZvciBBbmR5J3MgcXVl c3Rpb246Cj4gCj4gT24gem9uZGFnIDE2IGp1bmkgMjAyNCAwODo1ODoyMCBDRVNUIEFuZHkgWWFu IDxhbmR5c2hya0AxNjMuY29tPiB3cm90ZToKPiA+IEhvdyBjYW4gSSB0ZXN0IHRoZXNlIHBhdGNo ZXM/IERvIHRoZXkgcmVxdWlyZSBhbnkgYWRkaXRpb25hbCB1c2Vyc3BhY2UKPiA+IHBhdGNoZXM/ Cj4gCj4gSSBoYXZlIHRoZSBzYW1lIHF1ZXN0aW9uIGFuZCBJIHRoaW5rIHlvdSdkIG5lZWQgdGhp cyBhbmQgdGhlIEhFVkMgcGF0Y2ggc2V0IAo+IGFuZCB0aGVuIGFsc28gcGF0Y2ggRkZtcGVnIGFu ZCB0aGVuIGl0IHNob3VsZCBlbmFibGUgSFcgYWNjZWxlcmF0aW9uLgo+IFNvIG15IHF1ZXN0aW9u IGJvaWxzIGRvd24gdG86IHdpdGggdGhlIHJrdmRlYzIgcGF0Y2ggc2V0LCBzaG91bGQgVjRMMi1y ZXF1ZXN0cyAKPiBub3cgYWxzbyB3b3JrIHdpdGggcmt2ZGVjLCBzbyBub3QganVzdCBIYW50cm8g YW55bW9yZT8KCkZGbXBlZyBjaGFuZ2VzIGFyZSBzdGlsbCBkb3duc3RyZWFtLCBhbmQgZGlmZmVy ZW50IHBlb3BsZSAoZXZlbiB3aXRoaW4KTGlicmVFTEVDKSBzZWVtcyB0byBoYXZlIHNsaWdodGx5 IGRpZmZlcmVudCB2ZXJzaW9uIG9yIGFsdGVyYXRpb24uIEl0IHdvdWxkIGJlCnJlYWxseSBuaWNl IGlmIHRoaXMgd29yayBjb3VsZCBtb3ZlIHVwc3RyZWFtIEZGTXBlZyBzbyB0aGF0IHdlIGNhbiBi ZSBtb3JlIHN1cmUKd2hhdCB3aGF0ICJ3b3JraW5nIHdpdGggRkZtcGVnIHY0bDItcmVxdWVzdHMi IG1lYW5zLgoKTWVhbndoaWxlLCBzdXBwb3J0IGluIHVwc3RyZWFtIEdTdHJlYW1lciBpcyBzdGFi bGUgb24gSGFudHJvIEcyIGFuZCBNZWRpYXRlawpWQ09ERUMuIEluIHRoZW9yeSwgaXQgd29ya3Mg ZmluZSB3aXRoIFJLVkRFQywgYW5kIGl0IHdpbGwgY2VydGFpbmx5IHdvcmsgd2l0aApSS1ZERUMy IHdoZW4gd2UgZ2V0IHRvIHdyaXRlIHRoZSBIRVZDIHN1cHBvcnQuCgo+IAo+IEJUVzogdGhlIGxp YmRybSBjb21taXRzIGhhdmUgYmVlbiBtZXJnZWQgdXBzdHJlYW0gcXVpdGUgc29tZSB0aW1lIGFn bywgc28gaWYgCj4geW91IGhhdmUgYSByZWNlbnQgdmVyc2lvbiBvZiB0aGF0LCB5b3UgZG9uJ3Qg bmVlZCB0byBwYXRjaCB0aGF0Lgo+IElmIHlvdSB1c2UgRkZtcGVnIDcuMCwgdGhlbiBKb25hcyBo YXMgYSBicmFuY2ggZm9yIHRoYXQgdG9vIChoYXZlbid0IHRyaWVkIGl0IAo+IHlldCB0aG91Z2gp Lgo+IAo+IEZXSVc6IG15IHRlc3QgcmVzdWx0cyB3ZXJlIGEgYml0IG1peGVkLiBJIGRpZG4ndCBw b3N0IHRoZW0gYmVmb3JlIGFzIEkgZG9uJ3QgCj4gZnVsbHkvcmVhbGx5IHVuZGVyc3RhbmQgdGhp cyAndmlkZW8gc3R1ZmYnLCBhbmQgSSBkaWRuJ3Qgd2FudCB5b3UgYWxsIHRvIHN1ZmZlciAKPiBm cm9tIHdoYXQgd2FzIGxpa2VseSBhIFBFQktBQyBpc3N1ZS4KPiAKPiBPbiBteSBQaW5lVGFiMiAo cmszNTY2KSBJIGhhZCBzb21lIGguMjY0IHZpZGVvcyBIVyBhY2NlbGVyYXRlZCwgYnV0IG5vdCBh bGwuIAo+IE15IGd1ZXNzIGlzIHRoYXQgaXQncyByZWxhdGVkIHRvIHRoZSByZXNvbHV0aW9uLiAx OTIweDEwODAgd29ya2VkLCB3aGlsZSBpdCAKPiBkaWRuJ3Qgd29yayB3aXRoIGEgMTI4MHg2NDAg dmlkZW8uIFRoZSB2aWRlbyBzdGlsbCBwbGF5ZWQsIGp1c3Qgbm90IEhXIAo+IGFjY2VsZXJhdGVk LiBJT1c6IGltcHJvdmVtZW50cyBpbiBzb21lIGFuZCBvdGhlcndpc2UgaXQgd2FzIGp1c3QgcmVu ZGVyZWQgYnkgCj4gdGhlIENQVSAoSSB0aGluayksIGp1c3QgbGlrZSBiZWZvcmUuCgpUaGlzIGlz IGJlY2F1c2UgYWxsIHJrMzVYWCBoYXZlIHR3byBoYXJkd2FyZSB2aWRlbyBkZWNvZGVycyBmb3Ig SC4yNjQuIFRoaXMgaXMKbm90IHRvIGJlIGJlIGNvbmZ1c2VkIHdpdGggcmt2ZGVjIHdoaWNoIGlz IGdvbmUuIEl0IGhhcyBhIG1vZGlmaWVkIEhhbnRybyBHMQpjb3JlIChsaW1pdGVkIHRvIDEwODBw NjApIGFuZCBya3ZkZWMyIGNvcmUgKGRyaXZlciBpbiBwcm9ncmVzcykuIEkgZG9uJ3QgdGhpbmsK Um9ja2NoaXAgcmVhbGx5IGV4cGVjdGVkIHRoZSBmaXJzdCBvbmUgdG8gYmUgZXZlciB1c2VkLCBi dXQgdXBzdHJlYW0gaGFzIGJlZW4KcHVzaHkgYW5kIGl0cyBub3cgZW5hYmxlZCB1cHN0cmVhbS4g VGhhdCBoYXMgYSBzaWRlIGVmZmVjdCwgd2hpY2ggaXMgdGhhdAp1c2Vyc3BhY2Ugd2lsbCBoYXZl IHRvIHdvcmsgaGFyZGVyIG9uIHRoZXNlIHBsYXRmb3JtIHRvIHBpY2sgdGhlIHJpZ2h0IEhXIGZv cgp0aGUgdGFzay4KCj4gCj4gT24gbXkgUm9jazY0IEkgZ290IGEgcGluayB0aW50IHdpdGggYWxs IHZpZGVvcywgbGlrZSBkZXNjcmliZWQgaGVyZToKPiBodHRwczovL2dpdGh1Yi5jb20vbXB2LXBs YXllci9tcHYvaXNzdWVzLzEyOTY4Cj4gSUlVQywgdGhhdCdzIGFjdHVhbGx5IGEgcHJvYmxlbSBp biB0aGUgbGltYSBkcml2ZXI/CgpJdHMgbm90IGNsZWFyIGZyb20gdGhlIGJ1ZyByZXBvcnQuIFRo aXMgdmlzdWFsIGFydGVmYWN0IGhhcyBiZWVuIHNlZW4gd2l0aAp3YXlsYW5kIGNvbXBvc2l0b3Jz IGxhdGVseSAobm90YWJseSB3ZXN0b24pLiBOb3RhYmx5LCB0aGlzIGNhbiBoYXBwZW4gaWYgeW91 IHRyeQphbmQgaW1wb3J0IE5WMTIgd2l0aCBtZXNhIChwYW5mcm9zdCBhbmQgbGltYSBpbmNsdWRl ZCkgYnV0IGZvcmNpbmcgYSBURVhUVVJFXzJECnRhcmdldCBpbnN0ZWFkIG9mIGV4dGVybmFsIHRh cmdldC4gTm9ybWFsbHkgdGhpcyBzaG91bGQgYmUgcmVqZWN0ZWQgYnkgbWVzYSwgYnV0CmlzIGFj Y2lkZW50YWxseSBub3QsIGFuZCBjYXVzZSBtaXNzLXJlbmRlci4KCk5pY29sYXMKCj4gCj4gQ2hl ZXJzLAo+ICAgRGllZGVyaWsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F18181AED2F for ; Mon, 17 Jun 2024 13:43:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718631818; cv=none; b=MJEZpF4y/1OVQa941H1h32JY4KyZRZmIqgroJ2rPQ8/Fk9vxhhBHGeGwSFwmuq4L1h5KQgjXWovEkMSCNjSILqyrGX3nXI4qwGtYcS8CFNO+UzjDVvrx7na+ppOCZuWTTz1qbEKHOEao5CHF+Qjz0AF8ZgCH3+qzaWHVmnH1Tr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718631818; c=relaxed/simple; bh=wPdlMn4BkQJ1i+WvuHCmNwqJAwmoMMcYl971v9DomFs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=FnPdep+IHRWNGYUAIpzXJMV7KC6CCF6DdZ5AweACKKzeKUT5zj3Xzd24eKmkc919TSjZyVDWllB2XbNjxfLTCw8qzowPDz0WFU0BprgqSPuQ051fEZEuGCTfqYyvkGRfd1MKxi6B8M0/ILJ11/A9O2Czloj7oZccBDCX7P1iG1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=S3HkmBr6; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="S3HkmBr6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1718631814; bh=wPdlMn4BkQJ1i+WvuHCmNwqJAwmoMMcYl971v9DomFs=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=S3HkmBr6agUfW95p6IZ5XRCZ8SXGakexEfxerssqNteb6ERE+9IrPn+eIzXQ3pPwT QRQcBuxxe/IdVRooZRu4o6xbj88PsaPT0WRD7HzPGgSeFCnVoavP/DQJB7t8eKL9gP GEClxw+4Gn1LePmGb7jSe7RM4T09+hfsHST1NeqyQDdJOHvOdbpbP0LVG7K7j/DxS+ gc2UJuy5w7VXuaOlPt+5WIvUXr4S97awQsFm5m1SjMBFPkxpnEP0rzHEhR5UPX99je f417DkkCcpc9mkI4RuDtBywU40yoThKahWTcPehbESaQIyfFwJhaHm4gPpQYvorx3E jb7T1pIkbGI/Q== Received: from nicolas-tpx395.localdomain (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 6CB9E3782121; Mon, 17 Jun 2024 13:43:32 +0000 (UTC) Message-ID: Subject: Re: [PATCH v4 00/11] media: rkvdec: Add H.264 High 10 and 4:2:2 profile support From: Nicolas Dufresne To: Diederik de Haas , Ezequiel Garcia , Mauro Carvalho Chehab , Hans Verkuil , linux-rockchip@lists.infradead.org, Jonas Karlman , Andy Yan Cc: Alex Bee , Benjamin Gaignard , Sebastian Fricke , Christopher Obbard , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Mon, 17 Jun 2024 09:43:29 -0400 In-Reply-To: <122755518.lCnTqr06ca@bagend> References: <20231105165521.3592037-1-jonas@kwiboo.se> <122755518.lCnTqr06ca@bagend> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, Le dimanche 16 juin 2024 =C3=A0 11:47 +0200, Diederik de Haas a =C3=A9crit= =C2=A0: > On Sunday, 5 November 2023 17:54:59 CEST Jonas Karlman wrote: > > This is a revival of a 3 year old series [1] now that NV15/NV20/NV30 su= pport > > for display driver have landed in mainline tree. > >=20 > > This series adds H.264 High 10 and 4:2:2 profile support to the Rockchi= p > > Video Decoder driver. > >=20 > > Patch 1 adds helpers for calculating plane bytesperline and sizeimage. > > Patch 2 adds two new pixelformats for semi-planer 10-bit 4:2:0/4:2:2 YU= V. > >=20 > > Patch 3 change to use bytesperline and buffer height to configure strid= es. > > Patch 4 change to use values from SPS/PPS control to configure the HW. > > Patch 5 remove an unnecessary call to validate sps at streaming start. > >=20 > > Patch 6-10 refactor code to support filtering of CAPUTRE formats based > > on the image format returned from a get_image_fmt ops. > >=20 > > Patch 11 adds final bits to support H.264 High 10 and 4:2:2 profiles. > >=20 > > Tested on a ROCK Pi 4 (RK3399) and Rock64 (RK3328): > >=20 > > v4l2-compliance 1.24.1, 64 bits, 64-bit time_t > > ... > > Total for rkvdec device /dev/video1: 46, Succeeded: 46, Failed: 0, > > Warnings: 0 > >=20 > > Running test suite JVT-FR-EXT with decoder FFmpeg-H.264-V4L2-request > > ... > > Ran 65/69 tests successfully > >=20 > > Running test suite JVT-AVC_V1 with decoder FFmpeg-H.264-V4L2-request > > ... > > Ran 127/135 tests successfully > >=20 > > Before this series: > >=20 > > Running test suite JVT-FR-EXT with decoder FFmpeg-H.264-V4L2-request > > ... > > Ran 44/69 tests successfully > >=20 > > ... > >=20 > > Following commits adds support for NV15/NV20/NV30 to VOP driver: > > 728c15b4b5f3 ("drm/fourcc: Add NV20 and NV30 YUV formats") > > d4b384228562 ("drm/rockchip: vop: Add NV15, NV20 and NV30 support") > >=20 > > To fully runtime test this series you may need above drm commits and ff= mpeg > > patches from [2], this series and drm patches is also available at [3]. > >=20 > > [1] > > https://lore.kernel.org/linux-media/20200706215430.22859-1-jonas@kwiboo= .se/ > > [2] https://github.com/Kwiboo/FFmpeg/commits/v4l2-request-n6.1-dev/ [3] > > https://github.com/Kwiboo/linux-rockchip/commits/linuxtv-rkvdec-high-10= -v4/ > > [4] https://gist.github.com/Kwiboo/f4ac15576b2c72887ae2bc5d58b5c865 [5] > > https://gist.github.com/Kwiboo/459a1c8f1dcb56e45dc7a7a29cc28adf >=20 > Reviving this old thread now that rkvdec2 'stuff' emerged. > I have (actually) done quite some tests with this (and "media: rkvdec: Ad= d=20 > HEVC backend" patch set) and they have been part of my kernel builds ever= =20 > since. > I _think_, but don't know, that is relevant for Andy's question: >=20 > On zondag 16 juni 2024 08:58:20 CEST Andy Yan wrote: > > How can I test these patches? Do they require any additional userspace > > patches? >=20 > I have the same question and I think you'd need this and the HEVC patch s= et=20 > and then also patch FFmpeg and then it should enable HW acceleration. > So my question boils down to: with the rkvdec2 patch set, should V4L2-req= uests=20 > now also work with rkvdec, so not just Hantro anymore? FFmpeg changes are still downstream, and different people (even within LibreELEC) seems to have slightly different version or alteration. It would= be really nice if this work could move upstream FFMpeg so that we can be more = sure what what "working with FFmpeg v4l2-requests" means. Meanwhile, support in upstream GStreamer is stable on Hantro G2 and Mediate= k VCODEC. In theory, it works fine with RKVDEC, and it will certainly work wi= th RKVDEC2 when we get to write the HEVC support. >=20 > BTW: the libdrm commits have been merged upstream quite some time ago, so= if=20 > you have a recent version of that, you don't need to patch that. > If you use FFmpeg 7.0, then Jonas has a branch for that too (haven't trie= d it=20 > yet though). >=20 > FWIW: my test results were a bit mixed. I didn't post them before as I do= n't=20 > fully/really understand this 'video stuff', and I didn't want you all to = suffer=20 > from what was likely a PEBKAC issue. >=20 > On my PineTab2 (rk3566) I had some h.264 videos HW accelerated, but not a= ll.=20 > My guess is that it's related to the resolution. 1920x1080 worked, while = it=20 > didn't work with a 1280x640 video. The video still played, just not HW= =20 > accelerated. IOW: improvements in some and otherwise it was just rendered= by=20 > the CPU (I think), just like before. This is because all rk35XX have two hardware video decoders for H.264. This= is not to be be confused with rkvdec which is gone. It has a modified Hantro G= 1 core (limited to 1080p60) and rkvdec2 core (driver in progress). I don't th= ink Rockchip really expected the first one to be ever used, but upstream has be= en pushy and its now enabled upstream. That has a side effect, which is that userspace will have to work harder on these platform to pick the right HW f= or the task. >=20 > On my Rock64 I got a pink tint with all videos, like described here: > https://github.com/mpv-player/mpv/issues/12968 > IIUC, that's actually a problem in the lima driver? Its not clear from the bug report. This visual artefact has been seen with wayland compositors lately (notably weston). Notably, this can happen if yo= u try and import NV12 with mesa (panfrost and lima included) but forcing a TEXTUR= E_2D target instead of external target. Normally this should be rejected by mesa= , but is accidentally not, and cause miss-render. Nicolas >=20 > Cheers, > Diederik