From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F7D8C54E49 for ; Mon, 4 Mar 2024 21:03:42 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EA01384A; Mon, 4 Mar 2024 22:03:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EA01384A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1709586220; bh=dRyORiaaDkhOJHe//rVljh2VmfBmbMd7knOY/VOeJyE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=otL2yoqvCSGXOWp53XiJmJYRIb7Wm6dtapcDZE6qScSzHc5+VDsnypIJPYsAX0cPI Xa4Khc2qr229DkdXhez082ziwGwBVRA5RQleCGlLE38Z34nqTCrH02jaYkucBRgxzx aPE/HydFcha7Bwtj/VxyoLq3WtZqjkbnajmkZkgo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 06AC8F80587; Mon, 4 Mar 2024 22:03:07 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5D9C8F805AA; Mon, 4 Mar 2024 22:03:07 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5B925F8024E; Mon, 4 Mar 2024 22:03:02 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8ADE0F80088 for ; Mon, 4 Mar 2024 22:02:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8ADE0F80088 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=YQ0hlFP4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709586180; x=1741122180; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dRyORiaaDkhOJHe//rVljh2VmfBmbMd7knOY/VOeJyE=; b=YQ0hlFP4FKBjEI2P6Yozte9DqSYUHaGGJXGcUsNhMkeD7GT9Ta0Qtueb /sfEifWzDA95VQWBVN/uxTXoNcaPGe4Ti+cus13VIx6746Ra0y9/KhWfL DcO2Y/WwZJiKoP0E+oYHmldxTvkXgL7Ixzan5zL7KVscaJ6sO5GW/ZGx+ RgLXuuGdczh3M6oZXDxH3DLu2YqOHRnWMHPNWOdOYVomc6CzrUf8zHKpP 4ZH71dqa+N7tzYofFNKKvLud2pa+C0U5xxRgdsjwR0g6SAa/jC2l0gIM0 k4Isq/uJdMn3Ldb5IXk3u57hUVwzDSxHaFTBnjn8U2EA9IZewQL4ybqX8 w==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="3962383" X-IronPort-AV: E=Sophos;i="6.06,204,1705392000"; d="scan'208";a="3962383" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 13:02:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,204,1705392000"; d="scan'208";a="9066810" Received: from cryoung-mobl2.amr.corp.intel.com (HELO [10.212.71.160]) ([10.212.71.160]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 13:02:47 -0800 Message-ID: Date: Mon, 4 Mar 2024 15:02:46 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] ASoC: Intel: Disable route checks for Skylake boards Content-Language: en-US To: Cezary Rojewski , broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, tiwai@suse.com, perex@perex.cz, amadeuszx.slawinski@linux.intel.com, hdegoede@redhat.com References: <20240304190536.1783332-1-cezary.rojewski@intel.com> <20240304190536.1783332-2-cezary.rojewski@intel.com> <87c39d2f-fac0-4414-9c9f-53e45de70e79@intel.com> From: Pierre-Louis Bossart In-Reply-To: <87c39d2f-fac0-4414-9c9f-53e45de70e79@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID-Hash: 4Q7GOMDS5ZDSDE6LSYVUT6JXCJAQSKGO X-Message-ID-Hash: 4Q7GOMDS5ZDSDE6LSYVUT6JXCJAQSKGO X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/4/24 14:40, Cezary Rojewski wrote: > On 2024-03-04 8:28 PM, Pierre-Louis Bossart wrote: >> On 3/4/24 13:05, Cezary Rojewski wrote: >>> Topology files that are propagated to the world and utilized by the >>> skylake-driver carry shortcomings in their SectionGraphs. >>> >>> Since commit daa480bde6b3 ("ASoC: soc-core: tidyup for >>> snd_soc_dapm_add_routes()") route checks are no longer permissive. Probe >>> failures for Intel boards have been partially addressed by commit >>> a22ae72b86a4 ("ASoC: soc-core: disable route checks for legacy devices") >>> and its follow up but only skl_nau88l25_ssm4567.c is patched. Fix the >>> problem for the rest of the boards. >>> >>> Link: >>> https://lore.kernel.org/all/20200309192744.18380-1-pierre-louis.bossart@linux.intel.com/ >>> Fixes: daa480bde6b3 ("ASoC: soc-core: tidyup for >>> snd_soc_dapm_add_routes()") >>> Signed-off-by: Cezary Rojewski >>> --- >>>   sound/soc/intel/boards/bxt_da7219_max98357a.c       | 1 + >>>   sound/soc/intel/boards/bxt_rt298.c                  | 1 + >>>   sound/soc/intel/boards/glk_rt5682_max98357a.c       | 1 + >>>   sound/soc/intel/boards/kbl_da7219_max98357a.c       | 1 + >>>   sound/soc/intel/boards/kbl_da7219_max98927.c        | 4 ++++ >>>   sound/soc/intel/boards/kbl_rt5660.c                 | 1 + >>>   sound/soc/intel/boards/kbl_rt5663_max98927.c        | 2 ++ >>>   sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 1 + >>>   sound/soc/intel/boards/skl_hda_dsp_generic.c        | 1 + >> >> This HDAudio machine driver is shared with the SOF-based solutions and I >> see no reason to change the route checking... >> >> I don't agree with this change. Why can't you fix the broken topologies >> instead, if indeed they 'carry shortcomings'? >> >> Same for glk, this an SOF-based solution. > > Perhaps the flag could be set conditionally for those two? > > Even when you address the problem in the topology file, you do not get > any confirmation user replaced the invalid file. skylake-driver topology > were not part of any firmware-alike package. Please note that I actually > did all that I believe could be done to repair those topologies and > provided valid references at avs-topology/for-skylake-driver [1]. Humm, the commit daa480bde6b3 ("ASoC: soc-core: tidyup for snd_soc_dapm_add_routes()") dates from August 2019 and was included in kernel 5.4. Why are we seeing issues on route checks with the Skylake driver in 2024? Are we saying that the card creation failed for the last 5 years? I must be missing something here.