From: David Laight <David.Laight@ACULAB.COM>
To: 'Arnaldo Carvalho de Melo' <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Jiri Olsa <jolsa@kernel.org>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] perf beauty: Don't use 'find ... -printf' as it isn't available in busybox
Date: Fri, 1 Dec 2023 12:05:31 +0000 [thread overview]
Message-ID: <ecad5dffa8474ed8a5367e917610e707@AcuMS.aculab.com> (raw)
In-Reply-To: <ZWkEeqdmCHMLhLr2@kernel.org>
...
> # Create list of architectures that have a specific errno.h.
> archlist=""
> -for arch in $(find $toolsdir/arch -maxdepth 1 -mindepth 1 -type d -printf "%f\n" | sort -r); do
> +for arch in $(find $toolsdir/arch -maxdepth 1 -mindepth 1 -type d | while read arch ; do basename
> $arch ; done | sort -r); do
> test -f $toolsdir/arch/$arch/include/uapi/asm/errno.h && archlist="$archlist $arch"
> done
Jeepers ...
Does this work?
for f in $toolsdir/arch/*/include/uapi/asm/errno.h; do
[ ! -f $f ] && break
d=${f%/include/uapi/asm/errno.h}
archlist="${d##*/} $archlist"
done
No fork()s or exec()s.
I think it only differs in having a trailing space instead of a leading one.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-12-01 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 21:54 [PATCH 1/1] perf beauty: Don't use 'find ... -printf' as it isn't available in busybox Arnaldo Carvalho de Melo
2023-11-30 22:12 ` Namhyung Kim
2023-12-01 12:05 ` David Laight [this message]
2023-12-01 17:01 ` Arnaldo Carvalho de Melo
2023-12-01 17:16 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecad5dffa8474ed8a5367e917610e707@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.