From: Bart Van Assche <bart.vanassche@gmail.com>
To: Marco Elver <elver@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Boqun Feng <boqun.feng@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Will Deacon <will@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Chris Li <sparse@chrisli.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Alexander Potapenko <glider@google.com>,
Arnd Bergmann <arnd@arndb.de>, Christoph Hellwig <hch@lst.de>,
Dmitry Vyukov <dvyukov@google.com>,
Eric Dumazet <edumazet@google.com>,
Frederic Weisbecker <frederic@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Ian Rogers <irogers@google.com>, Jann Horn <jannh@google.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
Johannes Berg <johannes.berg@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Josh Triplett <josh@joshtriplett.org>,
Justin Stitt <justinstitt@google.com>,
Kees Cook <kees@kernel.org>,
Kentaro Takeda <takedakn@nttdata.co.jp>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Miguel Ojeda <ojeda@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Thomas Gleixner <tglx@linutronix.de>, Thomas Graf <tgraf@suug.ch>,
Uladzislau Rezki <urezki@gmail.com>,
Waiman Long <longman@redhat.com>,
kasan-dev@googlegroups.com, linux-crypto@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-security-module@vger.kernel.org,
linux-sparse@vger.kernel.org, linux-wireless@vger.kernel.org,
llvm@lists.linux.dev, rcu@vger.kernel.org
Subject: Re: [PATCH v5 07/36] lockdep: Annotate lockdep assertions for context analysis
Date: Fri, 19 Dec 2025 14:28:48 -0700 [thread overview]
Message-ID: <ecb35204-ea13-488b-8d60-e21d4812902a@gmail.com> (raw)
In-Reply-To: <CANpmjNPJXVtZgT96PP--eNAkHNOvw1MrYzWt5f2aA0LUeK8iGA@mail.gmail.com>
On 12/19/25 2:16 PM, Marco Elver wrote:
> It's basically an escape hatch to defer to dynamic analysis where the
> limits of the static analysis are reached.
That's not how lockdep_assert_held() is used in the kernel. This macro
is more often than not used to document assumptions that can be verified
at compile time.
This patch seems like a step in the wrong direction to me because it
*suppresses* compile time analysis compile-time analysis is useful. I
think that this patch either should be dropped or that the __assume()
annotations should be changed into __must_hold() annotations.
Bart.
next prev parent reply other threads:[~2025-12-19 21:28 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 15:39 [PATCH v5 00/36] Compiler-Based Context- and Locking-Analysis Marco Elver
2025-12-19 15:39 ` [PATCH v5 01/36] compiler_types: Move lock checking attributes to compiler-context-analysis.h Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 02/36] compiler-context-analysis: Add infrastructure for Context Analysis with Clang Marco Elver
2025-12-19 18:38 ` Bart Van Assche
2025-12-19 18:59 ` Marco Elver
2025-12-19 19:04 ` Bart Van Assche
2025-12-19 19:11 ` Marco Elver
2025-12-20 13:33 ` Peter Zijlstra
2026-01-05 15:53 ` [tip: locking/core] tags: Add regex for context_lock_struct tip-bot2 for Peter Zijlstra
2026-01-05 15:54 ` [tip: locking/core] compiler-context-analysis: Add infrastructure for Context Analysis with Clang tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 03/36] compiler-context-analysis: Add test stub Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 04/36] Documentation: Add documentation for Compiler-Based Context Analysis Marco Elver
2025-12-19 18:51 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 05/36] checkpatch: Warn about context_unsafe() without comment Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 06/36] cleanup: Basic compatibility with context analysis Marco Elver
2025-12-19 19:16 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2026-01-06 13:21 ` [PATCH v5 06/36] " Tetsuo Handa
2026-01-06 17:34 ` Marco Elver
2026-01-27 10:14 ` Lorenzo Stoakes
2026-01-27 10:17 ` Marco Elver
2026-01-27 10:21 ` Lorenzo Stoakes
2025-12-19 15:39 ` [PATCH v5 07/36] lockdep: Annotate lockdep assertions for " Marco Elver
2025-12-19 20:53 ` Bart Van Assche
2025-12-19 21:16 ` Marco Elver
2025-12-19 21:28 ` Bart Van Assche [this message]
2025-12-19 21:47 ` Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 08/36] locking/rwlock, spinlock: Support Clang's " Marco Elver
2025-12-19 20:26 ` Bart Van Assche
2025-12-19 21:02 ` Marco Elver
2025-12-19 21:34 ` Bart Van Assche
2025-12-19 21:48 ` Marco Elver
2025-12-19 21:45 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 09/36] compiler-context-analysis: Change __cond_acquires to take return value Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:39 ` [PATCH v5 10/36] locking/mutex: Support Clang's context analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2026-01-08 22:10 ` [PATCH v5 10/36] " Bart Van Assche
2026-01-08 23:26 ` Marco Elver
2026-01-09 6:02 ` Christoph Hellwig
2026-01-09 13:07 ` Steven Rostedt
2026-01-10 3:23 ` Marco Elver
2025-12-19 15:40 ` [PATCH v5 11/36] locking/seqlock: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 12/36] bit_spinlock: Include missing <asm/processor.h> Marco Elver
2025-12-19 20:38 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 13/36] bit_spinlock: Support Clang's context analysis Marco Elver
2025-12-19 20:47 ` Bart Van Assche
2025-12-19 21:09 ` Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 14/36] rcu: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 15/36] srcu: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2026-01-26 17:31 ` [PATCH v5 15/36] " Bart Van Assche
2026-01-26 18:35 ` Marco Elver
2026-01-26 18:54 ` Bart Van Assche
2026-01-26 21:35 ` Peter Zijlstra
2026-01-26 23:46 ` Marco Elver
2025-12-19 15:40 ` [PATCH v5 16/36] kref: Add context-analysis annotations Marco Elver
2025-12-19 20:49 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 17/36] locking/rwsem: Support Clang's context analysis Marco Elver
2025-12-19 20:55 ` Bart Van Assche
2025-12-20 12:52 ` Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 18/36] locking/local_lock: Include missing headers Marco Elver
2025-12-19 20:56 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 19/36] locking/local_lock: Support Clang's context analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 20/36] locking/ww_mutex: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2026-01-09 20:16 ` [PATCH v5 20/36] " Bart Van Assche
2026-01-09 21:06 ` Marco Elver
2026-01-09 21:26 ` Bart Van Assche
2026-01-12 10:32 ` Maarten Lankhorst
2025-12-19 15:40 ` [PATCH v5 21/36] debugfs: Make debugfs_cancellation a context lock struct Marco Elver
2025-12-19 21:01 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 22/36] um: Fix incorrect __acquires/__releases annotations Marco Elver
2025-12-19 21:05 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 23/36] compiler-context-analysis: Remove Sparse support Marco Elver
2025-12-19 21:38 ` Bart Van Assche
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 24/36] compiler-context-analysis: Remove __cond_lock() function-like helper Marco Elver
2025-12-19 21:42 ` Bart Van Assche
2025-12-20 12:51 ` Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 25/36] compiler-context-analysis: Introduce header suppressions Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 26/36] compiler: Let data_race() imply disabled context analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 27/36] MAINTAINERS: Add entry for Context Analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 28/36] kfence: Enable context analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 29/36] kcov: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 30/36] kcsan: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 31/36] stackdepot: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 32/36] rhashtable: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 33/36] printk: Move locking annotation to printk.c Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 34/36] security/tomoyo: Enable context analysis Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 35/36] crypto: " Marco Elver
2026-01-05 15:54 ` [tip: locking/core] " tip-bot2 for Marco Elver
2025-12-19 15:40 ` [PATCH v5 36/36] sched: Enable context analysis for core.c and fair.c Marco Elver
2026-01-05 15:53 ` [tip: locking/core] " tip-bot2 for Marco Elver
2026-01-12 22:04 ` [PATCH v5 36/36] " Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecb35204-ea13-488b-8d60-e21d4812902a@gmail.com \
--to=bart.vanassche@gmail.com \
--cc=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=frederic@kernel.org \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=irogers@google.com \
--cc=jannh@google.com \
--cc=joelagnelf@nvidia.com \
--cc=johannes.berg@intel.com \
--cc=josh@joshtriplett.org \
--cc=justinstitt@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kees@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=longman@redhat.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=lukas.bulwahn@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=nathan@kernel.org \
--cc=neeraj.upadhyay@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=ojeda@kernel.org \
--cc=paulmck@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sparse@chrisli.org \
--cc=takedakn@nttdata.co.jp \
--cc=tglx@linutronix.de \
--cc=tgraf@suug.ch \
--cc=urezki@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.