From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D512C6FD1F for ; Tue, 26 Mar 2024 15:27:45 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.698122.1089483 (Exim 4.92) (envelope-from ) id 1rp8i4-0006yo-T9; Tue, 26 Mar 2024 15:27:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 698122.1089483; Tue, 26 Mar 2024 15:27:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rp8i4-0006yh-PD; Tue, 26 Mar 2024 15:27:32 +0000 Received: by outflank-mailman (input) for mailman id 698122; Tue, 26 Mar 2024 15:27:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rp8i3-0006ya-Kn for xen-devel@lists.xenproject.org; Tue, 26 Mar 2024 15:27:31 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5aa81742-eb85-11ee-a1ef-f123f15fe8a2; Tue, 26 Mar 2024 16:27:28 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 8BCEA4EE0739; Tue, 26 Mar 2024 16:27:27 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5aa81742-eb85-11ee-a1ef-f123f15fe8a2 MIME-Version: 1.0 Date: Tue, 26 Mar 2024 16:27:27 +0100 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, bertrand.marquis@arm.com, julien@xen.org, George Dunlap , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 07/11] xen/page_alloc: address violations of MISRA C Rule 20.7 In-Reply-To: References: Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, sorry, forgot to reply. On 2024-03-25 10:27, Jan Beulich wrote: > On 22.03.2024 17:01, Nicola Vetrini wrote: >> --- a/xen/common/page_alloc.c >> +++ b/xen/common/page_alloc.c >> @@ -150,7 +150,7 @@ >> #include >> #else >> #define p2m_pod_offline_or_broken_hit(pg) 0 > > Seeing this in context: Does Misra also have a rule demanding > evaluation > of macro arguments? > No such rule. There is one for unused function parameters, though. >> -#define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) >> +#define p2m_pod_offline_or_broken_replace(pg) BUG_ON((pg) != NULL) > > Or easier > > #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg) > > ? > Good point. I'll modify it. > Jan -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)