From: David Ahern <dsahern@kernel.org>
To: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ido Schimmel <idosch@nvidia.com>, Shuah Khan <shuah@kernel.org>,
Petr Machata <petrm@nvidia.com>
Subject: Re: [PATCH net v3 1/3] ipv4: ignore dst hint for multipath routes
Date: Mon, 28 Aug 2023 12:55:57 -0600 [thread overview]
Message-ID: <ecba2119-2182-16b5-9ad5-25a9b497b0d6@kernel.org> (raw)
In-Reply-To: <20230828113221.20123-2-sriram.yagnaraman@est.tech>
On 8/28/23 5:32 AM, Sriram Yagnaraman wrote:
> Route hints when the nexthop is part of a multipath group causes packets
> in the same receive batch to be sent to the same nexthop irrespective of
> the multipath hash of the packet. So, do not extract route hint for
> packets whose destination is part of a multipath group.
>
> A new SKB flag IPSKB_MULTIPATH is introduced for this purpose, set the
> flag when route is looked up in ip_mkroute_input() and use it in
> ip_extract_route_hint() to check for the existence of the flag.
>
> Fixes: 02b24941619f ("ipv4: use dst hint for ipv4 list receive")
> Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
> ---
> include/net/ip.h | 1 +
> net/ipv4/ip_input.c | 3 ++-
> net/ipv4/route.c | 1 +
> 3 files changed, 4 insertions(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2023-08-28 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 11:32 [PATCH net v3 0/3] Avoid TCP resets when using ECMP for load-balancing between multiple servers Sriram Yagnaraman
2023-08-28 11:32 ` [PATCH net v3 1/3] ipv4: ignore dst hint for multipath routes Sriram Yagnaraman
2023-08-28 15:15 ` Ido Schimmel
2023-08-28 18:55 ` David Ahern [this message]
2023-08-28 11:32 ` [PATCH net v3 2/3] ipv6: " Sriram Yagnaraman
2023-08-28 15:16 ` Ido Schimmel
2023-08-28 18:56 ` David Ahern
2023-08-28 11:32 ` [PATCH net v3 3/3] selftests: fib_tests: Add multipath list receive tests Sriram Yagnaraman
2023-08-28 15:24 ` Ido Schimmel
2023-08-28 18:57 ` David Ahern
2023-08-28 19:14 ` Jakub Kicinski
2023-08-30 9:17 ` Sriram Yagnaraman
2023-08-30 15:42 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecba2119-2182-16b5-9ad5-25a9b497b0d6@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=sriram.yagnaraman@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.