From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8616CA0EED for ; Thu, 28 Aug 2025 18:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KP6GeI4QNlyVzRWNe4PL6HeP+siA3vt2wqk6FJm5c6M=; b=1bJUpT/fmHsc3qoGn60jwCorp+ GGrSiFdBfMdYbhQiC4DPV4j/YD9AGMVvPvY7BsqMUtRMY5fQRUS5TbrJz9lZxh7XHfs5rF0ILNzp3 oMmknsph1TpN9yDLoAWonQ60s1TLz5jSun6C+GqGdsxBhBlpVt/AI+A2pxWzOFn6Q258IZMFpFTUz sca+ieYOSrQ7+VlsXCOGj/+KfovIJcSJmfe2098y8J1GxD/BuwtOSe5x6/tUtE8hkQlKa4K6+Y4aq UcZ62Xy6ZZxoS8/UR9/MNzroiob+gYrghK7EzZRY75AuPOPP8I+M/+OLM7AVqvgFw4qHLcsDAsAIl L5w3XxbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1urhWL-00000002oCT-27k1; Thu, 28 Aug 2025 18:38:49 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1urccl-00000001jGL-2dIh for linux-arm-kernel@lists.infradead.org; Thu, 28 Aug 2025 13:25:08 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-afcb72d5409so152588966b.0 for ; Thu, 28 Aug 2025 06:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756387506; x=1756992306; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KP6GeI4QNlyVzRWNe4PL6HeP+siA3vt2wqk6FJm5c6M=; b=fjGRryPNRdN2zZ2SI40/V0o8WL4hLj+ebeRnaotiWKdXVs+Z4owGWVi4GZDRpEfDQs 6xN5KT3zV6af7OIQ6hS7hDuR4bGEqgab6x9Ojh3JH7kX9Wvi6dokwa+HtVK37fzzgmae pWYmjGSMb/8CEv3oti17C623B9qrXpARnL2GMo9LEPNO+iBGWHQCIQacHTP4Bd7lwf8H 6o5apKK9t0QRdgnALFIirKLpfTNqBlp2yrdvpAnQ/8UTXiBX4iOvLlIxXU5HU0VxhD8F GLkHnbAABytpGe+iM9yis3zrdH3BZ/idAqPvcU80HuEGT701z3KcSSA+KQvgiwvBJsG4 Bnvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756387506; x=1756992306; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KP6GeI4QNlyVzRWNe4PL6HeP+siA3vt2wqk6FJm5c6M=; b=rSWHuUrU6NBSmgIQHhblHEgi5QeLmXYSekVYUsQLvcLJ1SIodaLMGMswQjt1piY/Nw yr6CvXtK8s1oKe8FLDzcV3+03yq8tIOzreOAPFKRWBVRpQ6Tjh+f3X8QJPqgJ/tlq0tB XizzTKe//odeMUERfALVh1FA20ZooWi618f9aXEUqYacr8beqT+p/ki63cPbbYsCMh9f CjggLrwylJ5jeHqBLt5XLHsMCpXfTwQuiQ3HeaDI0YQSBM+XEwaXJO36oU+EK03Xqhct XhxL5QkzxS1Uf0bh5jKw8BXfmwYPA2K5pvmh938VDTBsvD2yn+wOU7oVtalGZ6UdOt6N ud5w== X-Forwarded-Encrypted: i=1; AJvYcCUDj99nqc61jnILBeUoqjM0/TtZrMFEYciwdgTTB46c5/s+eXq7IdmPT9RdubHeydQ6fs5TBIvIjvZN76mC7ANM@lists.infradead.org X-Gm-Message-State: AOJu0YwJbPEuRoxN+cqeHedCHHPuAtr4D3+E11XMIIU/vCeCrE2Dp5Tc ohrKc5I0URXRk9E6ALp6Ao5e0uhZWc3gu+uJB3ZuFcjamTLN5yNjeCHQriffytejEZ0= X-Gm-Gg: ASbGncuAQ34RVlQycf04oC3dqmJ2m7h9eAy4+5gGNVnrweUGTAYc9kFxlv7ZvBiIZFJ pPOM9Y8BaGjsKwb8VV5yGjy4Hlw6x4VTZyGTPoTiZXo0z5HSFgXQY3WtROF/Yxk8KK4/Heu/tx6 1V0ZodT4idhARKP3RKinvzDvH7lFXyf/Icw17yAGN5+coNW6LVN7VnHofs3wqkZksRrue+iwQcK aIdKUuvk28QsQav10v9mOmj4ZAWpOw7F8ChwK8LyIC0CK+vPb1Oav+DPzkuM3PafYeK4kYQWoVb t/B4pDYw9eLR3bVPXV0uCnVJrk1Y2C3CziddJ8uuYOkhWsNwKDD61fOS2W5kO0FfXLRTaMbibh9 quUVwQc9lGrVRNpUNNQyEp8eY6xe1taag9LoGHQUCFgmxg5FMIm7H/RYsf4kCCFtSUthbdAjbJ6 Bd2Q== X-Google-Smtp-Source: AGHT+IHnstlza8K9C5w6vOWcSWmYNQEhQr+qMHGXGhuf3pnVngAd6eVaQO3IZGsyPfF2zyp3aTQhtA== X-Received: by 2002:a17:907:968c:b0:afd:d9e4:51e7 with SMTP id a640c23a62f3a-afe296bceabmr2217290166b.63.1756387505863; Thu, 28 Aug 2025 06:25:05 -0700 (PDT) Received: from [10.41.150.230] ([77.241.232.9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe79fba62dsm926560266b.100.2025.08.28.06.25.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Aug 2025 06:25:04 -0700 (PDT) Message-ID: Date: Thu, 28 Aug 2025 15:25:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 10/13] arm64: dts: rockchip: add the vip node to px30 To: michael.riesch@collabora.com, Mehdi Djait , Maxime Chevallier , =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Thomas Petazzoni , Gerald Loacker , Markus Elfring , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Nicolas Dufresne , Sebastian Reichel , Collabora Kernel Team , Paul Kocialkowski , Alexander Shiyan , Val Packett , Rob Herring , Philipp Zabel , Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Mehdi Djait References: <20240220-rk3568-vicap-v10-0-62d8a7b209b4@collabora.com> <20240220-rk3568-vicap-v10-10-62d8a7b209b4@collabora.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20240220-rk3568-vicap-v10-10-62d8a7b209b4@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250828_062507_662377_9F0F8ABF X-CRM114-Status: GOOD ( 16.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/08/2025 01:26, Michael Riesch via B4 Relay wrote: > From: Mehdi Djait > > Add the device tree node for the PX30 Video Input Processor (VIP). > > Signed-off-by: Mehdi Djait > [added cosmetic changes] > Signed-off-by: Michael Riesch > Signed-off-by: Michael Riesch > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > index 46f64cd33b9b..ef52879d6a73 100644 > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > @@ -1280,6 +1280,18 @@ isp_mmu: iommu@ff4a8000 { > #iommu-cells = <0>; > }; > > + cif: video-capture@ff490000 { > + compatible = "rockchip,px30-vip"; > + reg = <0x0 0xff490000 0x0 0x200>; > + interrupts = ; > + clocks = <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>; > + clock-names = "aclk", "hclk", "pclk"; > + power-domains = <&power PX30_PD_VI>; > + resets = <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_CIF_PCLKIN>; > + reset-names = "axi", "ahb", "pclkin"; > + status = "disabled"; > + }; > + > qos_gmac: qos@ff518000 { > compatible = "rockchip,px30-qos", "syscon"; > reg = <0x0 0xff518000 0x0 0x20>; > Now that I look at the rockchip dtsi it appears newline scarcity is the norm, you can disregard my suggestion for your example in the previous patch so. Reviewed-by: Bryan O'Donoghue From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD107CA1000 for ; Thu, 28 Aug 2025 18:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MTp5Y0J0Pp1gqGxjaDwKaDSAtAp/dyZAKHrS67ejLB8=; b=C3+Y0EEfqAE8VF d5CzBHTZnb+IQNyGTz9eOg1HpnREgAqfHCAnfMYYj1IO0k0Asgd9F6n530xbAuDLqK2EgCSU923ZL wP5MYt4GSWuTBYKdDj+OK7s0plPQq5DmfY7vQwu5KHtamSKA30g5AHoqyliRgYLFQ+kEXLeEPJZQK GV6wQQHG4++lbnublZx5LplLD3IuVaBlF5TFqTYU1bWmgq8CStVyZSpDpXgJ1SPjkDTqlolz3A2W7 fAb6t4qdndHwlKEMx6+uvzuUT0npcFzFTxlgwlQytYJVJq9iZ7mtgf+IgKLRBmiMS0aJf40292fW3 fIRlpx1/t4YH0Ovox/Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1urhWM-00000002oDF-0fz6; Thu, 28 Aug 2025 18:38:50 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1urccl-00000001jGM-2Jlg for linux-rockchip@lists.infradead.org; Thu, 28 Aug 2025 13:25:09 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-afe84202bc2so128725966b.2 for ; Thu, 28 Aug 2025 06:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756387506; x=1756992306; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KP6GeI4QNlyVzRWNe4PL6HeP+siA3vt2wqk6FJm5c6M=; b=fjGRryPNRdN2zZ2SI40/V0o8WL4hLj+ebeRnaotiWKdXVs+Z4owGWVi4GZDRpEfDQs 6xN5KT3zV6af7OIQ6hS7hDuR4bGEqgab6x9Ojh3JH7kX9Wvi6dokwa+HtVK37fzzgmae pWYmjGSMb/8CEv3oti17C623B9qrXpARnL2GMo9LEPNO+iBGWHQCIQacHTP4Bd7lwf8H 6o5apKK9t0QRdgnALFIirKLpfTNqBlp2yrdvpAnQ/8UTXiBX4iOvLlIxXU5HU0VxhD8F GLkHnbAABytpGe+iM9yis3zrdH3BZ/idAqPvcU80HuEGT701z3KcSSA+KQvgiwvBJsG4 Bnvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756387506; x=1756992306; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KP6GeI4QNlyVzRWNe4PL6HeP+siA3vt2wqk6FJm5c6M=; b=RqVeWLjhQOCL/3lHHAlpqqqugwHEd4xYx+2jk0KcUiGxkWDBqkJl1s2lEtNHuLB9fv FHp+iXw8WZdiIdM16rIalmEjcBORkZo1IpFXfzMtsc14HDazD3YYrmwEoV9x0IdEb437 mH1oWubcWhJQBfVZSbnykCyaLYWGmJIAMQ3v0IzGN+9ymwq2+1WmWMFztvwPqHOvrJMm /qb23FEQSeoQI/Sc4DO2AtiIHVV31Oz5Moxmjw/pyoanqzeSmUv0MHt0UPQ4Tuy/Fj5H +GY4Q36b7Jam5BAM+c1wYq+uEzrSnHSDGn2aeaoDWvYijgs/GSXwxysgnDIFBaaHvHN7 IRdw== X-Forwarded-Encrypted: i=1; AJvYcCV8frLMOPkxzEldMM647zBG2iQkBoIL8qckxPqzdGdmxNqQ3iTECDrRA1doAcS5pzR2IY7znxDQefhg4++JSg==@lists.infradead.org X-Gm-Message-State: AOJu0YzI9s1XKD1+C9IgsOizzKO6rDE2GUE1lyMqfk+O1kfsC6ucBgCT wOZjf2sCTZzLW8urH9MSxBPLKue6LiPwflKh3QT1Y9iS3xLwNLM94wgTAYDjfGOCfBI= X-Gm-Gg: ASbGncu/6o06SFqQ5KqPPgDo7ANeIzWXKcPrltxNCrqdutE5f/5TL+RW1pPWpfl67eb +YafUMcnbHxoNo5LWMFltWpkSMfzMzsRgKon44Jx+AClTa/QxtOWlAJGeL8cTW/gt8XHK4QuHHa NYa4lvib+Ea5+qSlloHrvt9XYDhGVXWprF9BE4233xHbLy9sGzMjp69lx2TDtAk1JVfiDY/kD0I 9jVSNZ6HorIEOWsgfvKia9IstvW/vHNqp6xWD8JouE39Ex8IMhVw85GA2LO7rhMNS/QGQ2YkxxX 7NZwHIsIqVWCPtTPo6+xCTTROYTo55d7FfK2Oajk/rzrRCThKwGY6TdV9E1XS94qVOC0z/2lLhb //MeGlYb6iO0mDwNnK7A00PbYq2r/tHuYG7MOJsRwEcWMln93HD0h+tJIL8KRKQ3+WtxQ8iC+hr WWNQ== X-Google-Smtp-Source: AGHT+IHnstlza8K9C5w6vOWcSWmYNQEhQr+qMHGXGhuf3pnVngAd6eVaQO3IZGsyPfF2zyp3aTQhtA== X-Received: by 2002:a17:907:968c:b0:afd:d9e4:51e7 with SMTP id a640c23a62f3a-afe296bceabmr2217290166b.63.1756387505863; Thu, 28 Aug 2025 06:25:05 -0700 (PDT) Received: from [10.41.150.230] ([77.241.232.9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe79fba62dsm926560266b.100.2025.08.28.06.25.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Aug 2025 06:25:04 -0700 (PDT) Message-ID: Date: Thu, 28 Aug 2025 15:25:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 10/13] arm64: dts: rockchip: add the vip node to px30 To: michael.riesch@collabora.com, Mehdi Djait , Maxime Chevallier , =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Thomas Petazzoni , Gerald Loacker , Markus Elfring , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Nicolas Dufresne , Sebastian Reichel , Collabora Kernel Team , Paul Kocialkowski , Alexander Shiyan , Val Packett , Rob Herring , Philipp Zabel , Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Mehdi Djait References: <20240220-rk3568-vicap-v10-0-62d8a7b209b4@collabora.com> <20240220-rk3568-vicap-v10-10-62d8a7b209b4@collabora.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20240220-rk3568-vicap-v10-10-62d8a7b209b4@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250828_062507_598263_9BBE616D X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 19/08/2025 01:26, Michael Riesch via B4 Relay wrote: > From: Mehdi Djait > > Add the device tree node for the PX30 Video Input Processor (VIP). > > Signed-off-by: Mehdi Djait > [added cosmetic changes] > Signed-off-by: Michael Riesch > Signed-off-by: Michael Riesch > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > index 46f64cd33b9b..ef52879d6a73 100644 > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > @@ -1280,6 +1280,18 @@ isp_mmu: iommu@ff4a8000 { > #iommu-cells = <0>; > }; > > + cif: video-capture@ff490000 { > + compatible = "rockchip,px30-vip"; > + reg = <0x0 0xff490000 0x0 0x200>; > + interrupts = ; > + clocks = <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>; > + clock-names = "aclk", "hclk", "pclk"; > + power-domains = <&power PX30_PD_VI>; > + resets = <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_CIF_PCLKIN>; > + reset-names = "axi", "ahb", "pclkin"; > + status = "disabled"; > + }; > + > qos_gmac: qos@ff518000 { > compatible = "rockchip,px30-qos", "syscon"; > reg = <0x0 0xff518000 0x0 0x20>; > Now that I look at the rockchip dtsi it appears newline scarcity is the norm, you can disregard my suggestion for your example in the previous patch so. Reviewed-by: Bryan O'Donoghue _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip