From: Florian Fainelli <f.fainelli@gmail.com>
To: Sergej Bauer <sbauer@blackbox.su>, netdev@vger.kernel.org
Cc: andrew@lunn.ch, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Bryan Whitehead <bryan.whitehead@microchip.com>,
UNGLinuxDriver@microchip.com,
Simon Horman <simon.horman@netronome.com>,
Mark Einon <mark.einon@gmail.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
Arnd Bergmann <arnd@arndb.de>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices
Date: Fri, 22 Jan 2021 13:52:48 -0800 [thread overview]
Message-ID: <ecc54ce2-cbda-d801-1127-e1c15aa22654@gmail.com> (raw)
In-Reply-To: <20210122214247.6536-1-sbauer@blackbox.su>
On 1/22/2021 1:42 PM, Sergej Bauer wrote:
> From: sbauer@blackbox.su
>
> v1->v2:
> switch to using of fixed_phy as was suggested by Andrew and Florian
> also features-related parts are removed
>
> Previous versions can be found at:
> v1:
> initial version
> https://lkml.org/lkml/2020/9/17/1272
>
> Signed-off-by: Sergej Bauer <sbauer@blackbox.su>
You are not explaining why you need this and why you are second guessing
the fixed PHY MII emulation that already exists. You really need to do a
better job at describing your changes and why the emulation offered by
swphy.c is not enough for your use case.
--
Florian
next prev parent reply other threads:[~2021-01-22 21:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 21:42 [PATCH v2] lan743x: add virtual PHY for PHY-less devices Sergej Bauer
2021-01-22 21:52 ` Florian Fainelli [this message]
2021-01-22 22:11 ` Sergej Bauer
2021-01-22 22:08 ` Andrew Lunn
2021-01-22 23:09 ` Sergej Bauer
2021-01-22 23:23 ` Andrew Lunn
2021-01-22 23:58 ` Sergej Bauer
2021-01-23 0:01 ` Florian Fainelli
2021-01-23 1:01 ` Sergej Bauer
2021-01-23 1:32 ` Andrew Lunn
2021-01-23 4:01 ` Sergej Bauer
2021-01-25 8:57 ` Sergej Bauer
2021-01-23 1:39 ` Florian Fainelli
2021-01-25 8:57 ` Sergej Bauer
2021-01-25 10:23 ` Sergej Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecc54ce2-cbda-d801-1127-e1c15aa22654@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@oss.nxp.com \
--cc=mark.einon@gmail.com \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbauer@blackbox.su \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.