From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0AA5C6FA82 for ; Wed, 14 Sep 2022 14:36:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230173AbiINOgW (ORCPT ); Wed, 14 Sep 2022 10:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230073AbiINOgC (ORCPT ); Wed, 14 Sep 2022 10:36:02 -0400 Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7DB55F132; Wed, 14 Sep 2022 07:35:50 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 8BD082B05FFC; Wed, 14 Sep 2022 10:30:33 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Wed, 14 Sep 2022 10:30:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663165833; x=1663169433; bh=Wfzkst+YiM JXs5sReQh7j9lQiYxOvqzMOth3P09VD2c=; b=dtA+6ioovLXgpnsW7bHMriT+T8 ob6iCcULhl0DryCUFjedfRzE3xsBbdbGgadlAVQ41Et76qFRqBCEJYxqTKLHFJYl 0mJp3SooHmD8Ak+7kZ6osWjGt2E1ap29T1ijHM027l7852BmXlU6gJ8/CtVM6jBs StaP8gavbZhPuNkxDOsOw6TvXchoXrwgU8nFCxFYpRCewlGjxOdZ+RU0NGh39qKk j5pVNaEUsGKo20ThJBJF+lFh5c2oVxJcH/n6QI+HCRvCLUTI5Z446aoyLA8zyJdn wGwrIVOzAiYcS+AOxNasXtqqFx4vqYQW36WPLWoKvU4mok2sBMK9oqBlZP/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663165833; x=1663169433; bh=Wfzkst+YiMJXs5sReQh7j9lQiYxO vqzMOth3P09VD2c=; b=itBX/aQz+iZxcv3EEVV/ixil/kcm2odCbKteXE91FORJ F10Q6kjN0bF7iLCWnXo8b53kIL+qiogY4SmdzaSLeCOtVhgmS9WgC8pJpvxYXb4u 1luiubes8aQfEci56/Tv/RYJZM5e7WYdF0+fub403CkBQck0eJqfKkqnIDUquP7X uqVOr1oZdo29LEgjRysnLwNfGW5WJ0ZRQgk9HG8WAtYgoFuNwP4BwZTBJ1GshKse nyXTIamtSmUlGxeaofMa/5JcY+f+fxAHPhiXnRFgzQ9dmaO+4uWz4omrQcwSpRdK /8vAOWsSjAqLDrD8YU1lsMAraUppR+3uY0m91jwF1g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduiedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepvefhffeltdegheeffffhtdegvdehjedtgfekueevgfduffettedtkeekueef hedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4CA84B60086; Wed, 14 Sep 2022 10:30:32 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-934-g6274855a4c-fm-20220913.002-g6274855a Mime-Version: 1.0 Message-Id: In-Reply-To: <20220914142713.29351-1-lukas.bulwahn@gmail.com> References: <20220914142713.29351-1-lukas.bulwahn@gmail.com> Date: Wed, 14 Sep 2022 16:29:22 +0200 From: "Arnd Bergmann" To: "Lukas Bulwahn" , "Linus Walleij" , "Russell King" , "Catalin Marinas" , "Will Deacon" , "Damien Le Moal" , linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ata: clean up how architectures enable PATA_PLATFORM and PATA_OF_PLATFORM Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Wed, Sep 14, 2022, at 4:27 PM, Lukas Bulwahn wrote: > There are two options for platform device PATA support: > > PATA_PLATFORM: Generic platform device PATA support > PATA_OF_PLATFORM: OpenFirmware platform device PATA support > > If an architecture allows the generic platform device PATA support, it > shall select HAVE_PATA_PLATFORM. Then, Generic platform device PATA support > is available and can be selected. > > If an architecture has OpenFirmware support, which it indicates by > selecting OF, OpenFirmware platform device PATA support is available > and can be selected. > If OpenFirmware platform device PATA support is selected, then the > functionality (code files) from Generic platform device PATA support needs > to be integrated in the kernel build for the OpenFirmware platform device > PATA support to work. Select PATA_PLATFORM in PATA_OF_PLATFORM to make sure > the needed files are added in the build. > > So, architectures with OpenFirmware support, do not need to additionally > select HAVE_PATA_PLATFORM. It is only needed by architecture that want the > non-OF pata-platform module. > > Reflect this way of intended use of config symbols in the ata Kconfig and > adjust all architecture definitions. > > This follows the suggestion from Arnd Bergmann (see Link). > > Suggested-by: Arnd Bergmann > Link: > https://lore.kernel.org/all/4b33bffc-2b6d-46b4-9f1d-d18e55975a5a@www.fastmail.com/ > > Signed-off-by: Lukas Bulwahn Thanks for the follow-up, looks good. Reviewed-by: Arnd Bergmann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23E1EECAAD3 for ; Wed, 14 Sep 2022 14:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zeyBSZxAP+5UQHu8jFN33a3WWCuis9ikc1Xqrf/rqMw=; b=yun55dWWcytUDi CsgIVYdTVT+L1OD67vfAk/mk4VMqm8qhduinh+LI+87rEGD6hHZizO2eZ1Tf2fLIBR4IDvJGe9DwZ LJdTyH1dn7RB5P6/eziPOseJfYlLTnSrMBA7WNBpLv1YJnHI6DyTk8SmaiVEm7pr9jnaZNfSWvyMa cQfe42W9RgpYaDH98BaImHHFp2+PgW236ieO8xnmBXIiBPGNAe4xQett8Zt3LJgRVsjG9H03Doi84 /crF3lEnteZUUfOH1Ub0STgpoq5wDSFrvXWombxjeayp3vivXhzVn2MKFDVEWH8Q9EbOEFROskHSc memsggNatwlpLyIAj0+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYTPY-002H55-Cn; Wed, 14 Sep 2022 14:30:44 +0000 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYTPS-002Gs6-53 for linux-arm-kernel@lists.infradead.org; Wed, 14 Sep 2022 14:30:40 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 8BD082B05FFC; Wed, 14 Sep 2022 10:30:33 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Wed, 14 Sep 2022 10:30:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663165833; x=1663169433; bh=Wfzkst+YiM JXs5sReQh7j9lQiYxOvqzMOth3P09VD2c=; b=dtA+6ioovLXgpnsW7bHMriT+T8 ob6iCcULhl0DryCUFjedfRzE3xsBbdbGgadlAVQ41Et76qFRqBCEJYxqTKLHFJYl 0mJp3SooHmD8Ak+7kZ6osWjGt2E1ap29T1ijHM027l7852BmXlU6gJ8/CtVM6jBs StaP8gavbZhPuNkxDOsOw6TvXchoXrwgU8nFCxFYpRCewlGjxOdZ+RU0NGh39qKk j5pVNaEUsGKo20ThJBJF+lFh5c2oVxJcH/n6QI+HCRvCLUTI5Z446aoyLA8zyJdn wGwrIVOzAiYcS+AOxNasXtqqFx4vqYQW36WPLWoKvU4mok2sBMK9oqBlZP/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663165833; x=1663169433; bh=Wfzkst+YiMJXs5sReQh7j9lQiYxO vqzMOth3P09VD2c=; b=itBX/aQz+iZxcv3EEVV/ixil/kcm2odCbKteXE91FORJ F10Q6kjN0bF7iLCWnXo8b53kIL+qiogY4SmdzaSLeCOtVhgmS9WgC8pJpvxYXb4u 1luiubes8aQfEci56/Tv/RYJZM5e7WYdF0+fub403CkBQck0eJqfKkqnIDUquP7X uqVOr1oZdo29LEgjRysnLwNfGW5WJ0ZRQgk9HG8WAtYgoFuNwP4BwZTBJ1GshKse nyXTIamtSmUlGxeaofMa/5JcY+f+fxAHPhiXnRFgzQ9dmaO+4uWz4omrQcwSpRdK /8vAOWsSjAqLDrD8YU1lsMAraUppR+3uY0m91jwF1g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduiedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepvefhffeltdegheeffffhtdegvdehjedtgfekueevgfduffettedtkeekueef hedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4CA84B60086; Wed, 14 Sep 2022 10:30:32 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-934-g6274855a4c-fm-20220913.002-g6274855a Mime-Version: 1.0 Message-Id: In-Reply-To: <20220914142713.29351-1-lukas.bulwahn@gmail.com> References: <20220914142713.29351-1-lukas.bulwahn@gmail.com> Date: Wed, 14 Sep 2022 16:29:22 +0200 From: "Arnd Bergmann" To: "Lukas Bulwahn" , "Linus Walleij" , "Russell King" , "Catalin Marinas" , "Will Deacon" , "Damien Le Moal" , linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ata: clean up how architectures enable PATA_PLATFORM and PATA_OF_PLATFORM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_073038_450978_4FF324D6 X-CRM114-Status: GOOD ( 18.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 14, 2022, at 4:27 PM, Lukas Bulwahn wrote: > There are two options for platform device PATA support: > > PATA_PLATFORM: Generic platform device PATA support > PATA_OF_PLATFORM: OpenFirmware platform device PATA support > > If an architecture allows the generic platform device PATA support, it > shall select HAVE_PATA_PLATFORM. Then, Generic platform device PATA support > is available and can be selected. > > If an architecture has OpenFirmware support, which it indicates by > selecting OF, OpenFirmware platform device PATA support is available > and can be selected. > If OpenFirmware platform device PATA support is selected, then the > functionality (code files) from Generic platform device PATA support needs > to be integrated in the kernel build for the OpenFirmware platform device > PATA support to work. Select PATA_PLATFORM in PATA_OF_PLATFORM to make sure > the needed files are added in the build. > > So, architectures with OpenFirmware support, do not need to additionally > select HAVE_PATA_PLATFORM. It is only needed by architecture that want the > non-OF pata-platform module. > > Reflect this way of intended use of config symbols in the ata Kconfig and > adjust all architecture definitions. > > This follows the suggestion from Arnd Bergmann (see Link). > > Suggested-by: Arnd Bergmann > Link: > https://lore.kernel.org/all/4b33bffc-2b6d-46b4-9f1d-d18e55975a5a@www.fastmail.com/ > > Signed-off-by: Lukas Bulwahn Thanks for the follow-up, looks good. Reviewed-by: Arnd Bergmann _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel