From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Val Packett <val@packett.cool>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Fabien Parent <fparent@baylibre.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/5] arm64: dts: mediatek: mt8516: fix wdt irq type
Date: Thu, 5 Dec 2024 13:26:48 +0100 [thread overview]
Message-ID: <ece47aeb-e9e2-4690-8103-a05a01ec7be5@collabora.com> (raw)
In-Reply-To: <20241204190524.21862-3-val@packett.cool>
Il 04/12/24 20:05, Val Packett ha scritto:
> The GICv2 does not support EDGE_FALLING interrupts, so the watchdog
> would refuse to attach due to a failing check coming from the GIC driver.
>
> Fixes: 5236347bde42 ("arm64: dts: mediatek: add dtsi for MT8516")
> Signed-off-by: Val Packett <val@packett.cool>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> index 444429341302..098c32ebf678 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> @@ -206,7 +206,7 @@ watchdog@10007000 {
> compatible = "mediatek,mt8516-wdt",
> "mediatek,mt6589-wdt";
> reg = <0 0x10007000 0 0x1000>;
> - interrupts = <GIC_SPI 198 IRQ_TYPE_EDGE_FALLING>;
> + interrupts = <GIC_SPI 198 IRQ_TYPE_LEVEL_LOW>;
> #reset-cells = <1>;
> };
>
next prev parent reply other threads:[~2024-12-05 12:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 19:05 [PATCH 0/5] MT8516/MT8167 dtsi fixes Val Packett
2024-12-04 19:05 ` [PATCH 1/5] arm64: dts: mediatek: mt8516: fix GICv2 range Val Packett
2024-12-05 12:26 ` AngeloGioacchino Del Regno
2024-12-04 19:05 ` [PATCH 2/5] arm64: dts: mediatek: mt8516: fix wdt irq type Val Packett
2024-12-05 12:26 ` AngeloGioacchino Del Regno [this message]
2024-12-04 19:05 ` [PATCH 3/5] arm64: dts: mediatek: mt8516: add i2c clock-div property Val Packett
2024-12-05 12:26 ` AngeloGioacchino Del Regno
2024-12-04 19:05 ` [PATCH 4/5] arm64: dts: mediatek: mt8516: reserve 192 KiB for TF-A Val Packett
2024-12-05 12:26 ` AngeloGioacchino Del Regno
2024-12-04 19:05 ` [PATCH 5/5] arm64: dts: mediatek: mt8516: add keypad node Val Packett
2024-12-05 12:26 ` AngeloGioacchino Del Regno
2024-12-05 12:27 ` [PATCH 0/5] MT8516/MT8167 dtsi fixes AngeloGioacchino Del Regno
2024-12-07 3:11 ` Val Packett
2024-12-09 10:03 ` AngeloGioacchino Del Regno
2024-12-10 8:28 ` (subset) " AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ece47aeb-e9e2-4690-8103-a05a01ec7be5@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.