From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57E9CC61DD6 for ; Fri, 4 Sep 2026 13:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:Message-ID:Date: In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lub5CvB2oRB2ku80kVXtr8LzkL+/k31NgCDoz40v5NQ=; b=gjFLStdWyrk2yD VEQk+1tAdPF5AGDvF2INWsNh5RDdGSALvQ2n8h7bMZJ1hGQexLTn2BNneZikT5Fb+i6u6DFpFHce+ Ku7TroQ7fMSzuVrGUTPJ2gJp+Hck5HKedsbdw2m+yOG+of3AB5Gn8WyT/6KYjCVP3zGvWy8Rxofbv YWKWCWX5CYLx8I8f3KfCuzHA5ZJDeH+Cc5xp+DGetMUCQ16W3bVQFHO75Kzm7S/V53My/R/xZHATo siZ9uf+jR5oaR4Gd2CPFwCZX/MZaV3jCHD49wPb6sk5OXDeK+zsIeCvKAjL3uZ/RXpJSy6oCbdTEi gCl65C/9roXqfVwaIzBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2U1X-00000002ELH-3vyL; Fri, 04 Sep 2026 13:32:07 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2U1V-00000002EJX-1GJ4 for linux-riscv@lists.infradead.org; Fri, 04 Sep 2026 13:32:07 +0000 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-cc1cc1b42b5so1127335a12.2 for ; Fri, 04 Sep 2026 06:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788528724; x=1789133524; darn=lists.infradead.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=gE9P4GObqZliYweF8gHdbLVlqBxBO1frIJ8W7HGnk/w=; b=B4iFs3K2aKZTN0IMEqYzMyLkOxsoJAXBebAypvCf4ETxvNj3lBj4kx9BCwvwBCQoIF kzoAbM6QOutcalX2jatvq/ns2MU1kQtvwkZvOlenG+zXEeARHJaasE2YIbdnTTGYrDjd 4zWQ4DJ8cd4SfvmKSrI/rwWu6/eGcWQId1vOIjBh3IGJw/DeVdtkmhgVI+G95imIjAbv 2UmAbutuM6lDzE+7k9/R2GSov1ITbPLEmTgKE3aSfCRRC7sO0/yUwLLnUPh0ZLdlO9Iz 1p8IK8zZ0zf3UR1OfNNMJd7zyX8aI+cEC1jxSqWwPEFYY4Skydc2wcWjKPpgQ8fj2gMq Yhcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788528724; x=1789133524; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gE9P4GObqZliYweF8gHdbLVlqBxBO1frIJ8W7HGnk/w=; b=eP0e4TTR6H8XMmg/P3MAilxGUMXuM/G9mDQ0L7pbRU8PtfCLzUleS5f36ycI/aWFfg rOqDzIwGvtd+m9RJD5C6V6gsYAv9JFJkD9pCr7Gx8vxhc6Iilc5UnsrLcXu/nreTA7Qe nVWIY79CBU8WHj3+89ksLMK6zETqFxd+bPlK58Ry3+Mpnl/ahiQo4qLcl3j5zSSzmcNd kubHeK8MHm2yNfqBcAZt5I2DZ7IRWMc8lZL/6MkbZT6ZoJSkf283ZV4so2u71MJ3dbrF IRciYhkUJt9WamDBKOlWTpbq+622OsTmQ6R82LmTPqgU2HqJvjD0K/m2gEAtGDQQzUFh tpFA== X-Forwarded-Encrypted: i=1; AKwUvByZAh7kjNflhwbqc/LoeyDmZcpkpvaGoXklp5feDMmOECRvNvCoN4S4fm0exTwmj4gj8ePIImh16q5sLw==@lists.infradead.org X-Gm-Message-State: AFuF++lTPIbIaac82ynbj4PsI6UR+3uAk23Dd7nWHlWj3HrncgSfdVy9 J7C8q9fjVwd4AN1jZj59dlVH3SGZqJRxZ8ZVsvvEjphruyNTH6y5xBfZ X-Gm-Gg: AYBFou3E7q/Tt15KAYfN0ooCMlH+LCQyXQD/b5JNhtLbpnd5Am2sx7LYZ+mlajIMJVK Zp15tI9FURt8PITSzJDbmRaS5Ut693xaykBc46WhjOCNEAxzmI0xrbSR6nxRdy2stz1TAUmmUre WgKBZYZZre4IyybW3oWFTr8uzthJzHoe1aXkJBl6jHv3nNHuMfQdnBfRWWyby7LImEb6BhDrGKJ nan+bjXmsjq+tx7R40q6HyRQo8qdzR4KbUYO1VVUlD7p2A6Ary0rFaUozphOkeuSQub9pWLOLuR 1XrOxkHfj6rHk7sqGoDVDgH1t9XskoubfgSMrVCJlz+l13f0SeS7YKVNBFaPlNg68FJ+PXfH0E9 wi4swKGvtL6TQiQtaf56XCvty/hsE1FlxZkpTZLKfS1Wf3Im26oBkz5Bnnvvt4sG84DMX/9KRd6 ZVVjyvfEI8Msg6+Ge7kxnxxGQQQo39J8sGcHounGse9EgobupaL/49wZbxR32CelQR4YbpghLlk 3I1KOgoXq6QekVAmYgDgzoRZAF1KAhfHP9N2xKejZpy X-Received: by 2002:a17:90b:3a50:b0:38e:4cb:51f with SMTP id 98e67ed59e1d1-39b26101576mr10859346a91.11.1788528723581; Fri, 04 Sep 2026 06:32:03 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339a534d25sm7083483eec.5.2026.09.04.06.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 06:32:02 -0700 (PDT) From: Ritesh Harjani (IBM) To: Sean Christopherson , Marc Zyngier , Oliver Upton , Sean Christopherson , Paolo Bonzini , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Atish Patra , Alexandre Ghiti , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Itaru Kitayama , Nicholas Piggin Subject: Re: [PATCH v2 04/20] KVM: selftests: Rename "num" param to "nr_pages" for physical page allocators In-Reply-To: <20260902164123.2546762-5-seanjc@google.com> Date: Fri, 04 Sep 2026 19:00:16 +0530 Message-ID: References: <20260902164123.2546762-1-seanjc@google.com> <20260902164123.2546762-5-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260904_063205_340594_6C6D7FC1 X-CRM114-Status: GOOD ( 14.63 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Sean Christopherson writes: > Rename the "num" param in the physical page allocator APIs to "nr_pages" to > make the unit and role of the param more obvious. > > Opportunistically rework the function comment to drop the superfluous > kerneldoc style, and to very explicitly call out that success is guaranteed. > > No functional change intended. > > Tested-by: Itaru Kitayama > Signed-off-by: Sean Christopherson > --- > .../testing/selftests/kvm/include/kvm_util.h | 6 ++-- > tools/testing/selftests/kvm/lib/kvm_util.c | 35 ++++++------------- > 2 files changed, 14 insertions(+), 27 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h > index 5a7a455b5387..95bc0a78d2bc 100644 > --- a/tools/testing/selftests/kvm/include/kvm_util.h > +++ b/tools/testing/selftests/kvm/include/kvm_util.h > @@ -991,11 +991,11 @@ void kvm_gsi_routing_write(struct kvm_vm *vm, struct kvm_irq_routing *routing); > const char *exit_reason_str(unsigned int exit_reason); > > gpa_t vm_phy_page_alloc(struct kvm_vm *vm, gpa_t min_gpa, u32 memslot); > -gpa_t __vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, gpa_t min_gpa, > +gpa_t __vm_phy_pages_alloc(struct kvm_vm *vm, size_t nr_pages, gpa_t min_gpa, > u32 memslot, bool protected); > gpa_t vm_alloc_page_table(struct kvm_vm *vm); > > -static inline gpa_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, > +static inline gpa_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t nr_pages, > gpa_t min_gpa, u32 memslot) > { > /* > @@ -1003,7 +1003,7 @@ static inline gpa_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, > * protected memory, as the majority of memory for such VMs is > * protected, i.e. using shared memory is effectively opt-in. > */ > - return __vm_phy_pages_alloc(vm, num, min_gpa, memslot, > + return __vm_phy_pages_alloc(vm, nr_pages, min_gpa, memslot, > vm_arch_has_protected_memory(vm)); > } > > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 9ddc047d5c27..b071d77dd301 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -2025,33 +2025,20 @@ const char *exit_reason_str(unsigned int exit_reason) > } > > /* > - * Physical Contiguous Page Allocator > + * Allocate contiguous (guest) physical pages in a given memory region, at or > + * the minimum specific GPA. If the memory is protected/private, also add the at or "above" the minimum ... Otherwise looks good. Feel free to add: Reviewed-by: Ritesh Harjani (IBM) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 836BD449B03 for ; Fri, 4 Sep 2026 13:32:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788528726; cv=none; b=mpNUXvM0pIbktmW5RLy/etNInYilCBXsc2v5EYaBQDcpthdaLRPDsV6jhhDeVhd33cvd7S8cf/+cWIZ/Lh1zAz+ldSg8HXqlVUgYFnC6QyD6wVopxXFzVsu9OAwVQfRmeKUlu07LfcDw8n1160ksO58ENs/kP0vAuhw2q1zOfFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788528726; c=relaxed/simple; bh=C7z5V731jarmZubJ2K9Qx2K4A5sVH5GDaEe3NpPUqZ0=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=VAhbNkYSjgQ9jwQcXWVGHBqamaeAqTP267QgB8BJXv1IwAJ3QFN52vigv/oDSqVHt0YrblvCxAMSjP++Y6iROYM2o6rvXrQLIWkUVELf1RZzFwUhZ44h5hvO31wVNOa+HRr6Bm6kE2jS3WHgo3jiCZGGk/ia/Qy/MzshQN046N4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pTBSHS7Y; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pTBSHS7Y" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-cbb8b54fcf8so1350075a12.0 for ; Fri, 04 Sep 2026 06:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788528724; x=1789133524; darn=lists.linux.dev; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=gE9P4GObqZliYweF8gHdbLVlqBxBO1frIJ8W7HGnk/w=; b=pTBSHS7YYJskY4ZNJgEixXXjRpx2Zn9V0SRyg5OUE0OjaMdR7+i3dMIdLfPuyH/t3W 8F6xpBZz+2ZZ2DT2m6V5rLR4C1W6/GG9AokceDi36CgvQQhwP4nx6VIY8Jrc25eK2BoN 9ZLNh9A/Vfvho5U+i21jSuX9CmbUNGMi30YHnvOcQsdD1gX35NzKQssEvGfkT+8nYtyP GesGbzuInGs+InBMNXzyLBUKFfLIfVs6c9pOjvRRNUfm1XWCMfryUCp1ViDJ/DXY+flb oW1CSnuQy3+a7nOuEcGZ2GkenacnufKPtC4IBFRgn0zhuT6ONzxE35MAkrnpJSjIWVoV Uajg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788528724; x=1789133524; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gE9P4GObqZliYweF8gHdbLVlqBxBO1frIJ8W7HGnk/w=; b=bHa9TI64Fwu74hM/5VNrnVUTA8K1YTtaM2OZsUr1NZOblBGsZKgSFgWwNP+A2Yqcgm 8prmtD6fKsHMt3b/Berx7K2yZGHP2IWRu5D4jPOXULE4dQORTsAToDQZoFpmIla2qK7J KMQslY91cwW52ufVgxecq161agMrhMVwUvlBMFeP8OKsrqaemBx+anmgS3fJSREyyMFN fN0W/NiZo49aFpJp35X0kgsEdGxhRNINKiy8QOYoP2SKcX0msLrTG/UN03typ4tyRiRh YJRm6hyMo/Dkr1PB3wIhtpvbgnVPSEeFPlTfSLSDshJ31/jQuOyhdvtwPkaxv7ReLT21 g0Lg== X-Forwarded-Encrypted: i=1; AKwUvByZryipwVv30fnpV216LmPGGfu/ZwN2I+mLHMYKjQ+8iSvCmE/t5mOghp5krzmkg2HdNBcQCXjcvZs=@lists.linux.dev X-Gm-Message-State: AFuF++nW1B0JnxnbLA+LPpjHalLrgyZpE/9Wn555EsOfSLSWGMR6Iymz hJ5YUADS0lfXIxsHsXbpD3xr3KPxWq2nkGkZUz4T8Gnah5dxz2G+9iwQ X-Gm-Gg: AYBFou2Lx9FUs0FESQzVDuQrgCT2y2eSe5ryUZXazBtMyNOz3AtDX5wkM3AgYuno8Am GLMGSmFNVMrSuiZx6NTGUeVPiKd8Pd2dmgCmxlyaIACkzXmJyXE0CFmVI2EIf7E6vUFGDFrCJSD /NlYUP2zOhnhn1diZZOn0eoC/iyA02Fu6Sg2loPsBbRrUt8HLwW/YmmdLpJVCFU8BVjP+OW3Vfh EE3h/dX6huX3/epZWsh3aOpp+GKc99X6jN9ZlBVVf/RsFyWv8yp7trQtKE8gRRR832EMa1YLKnv tmEA0JRH/69XJj+2heOr8zeEk4E32viUoAuKpR9JF63PqVfmWwWmxQS4cgiq7k20zeUxn16w7dw YixqS6WYeEsbf3244B7bblYAe3DW+p/VW63gzOGemyAfm4rvVYrXPlQx2bq5o528ej20/ZIb/OM HJES+QleHv6XXP+JYjLDLvWLHUxOwrPPB78dQ7SwmT/Pr9Fs4rb/HSpl4da9ZY6AWP1NTmnhVYC DdIoeWgl0vmTd01YzNoNn1P3Zo46qGyEKG40JPk+8TU X-Received: by 2002:a17:90b:3a50:b0:38e:4cb:51f with SMTP id 98e67ed59e1d1-39b26101576mr10859346a91.11.1788528723581; Fri, 04 Sep 2026 06:32:03 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339a534d25sm7083483eec.5.2026.09.04.06.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 06:32:02 -0700 (PDT) From: Ritesh Harjani (IBM) To: Sean Christopherson , Marc Zyngier , Oliver Upton , Sean Christopherson , Paolo Bonzini , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Atish Patra , Alexandre Ghiti , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Itaru Kitayama , Nicholas Piggin Subject: Re: [PATCH v2 04/20] KVM: selftests: Rename "num" param to "nr_pages" for physical page allocators In-Reply-To: <20260902164123.2546762-5-seanjc@google.com> Date: Fri, 04 Sep 2026 19:00:16 +0530 Message-ID: References: <20260902164123.2546762-1-seanjc@google.com> <20260902164123.2546762-5-seanjc@google.com> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Sean Christopherson writes: > Rename the "num" param in the physical page allocator APIs to "nr_pages" to > make the unit and role of the param more obvious. > > Opportunistically rework the function comment to drop the superfluous > kerneldoc style, and to very explicitly call out that success is guaranteed. > > No functional change intended. > > Tested-by: Itaru Kitayama > Signed-off-by: Sean Christopherson > --- > .../testing/selftests/kvm/include/kvm_util.h | 6 ++-- > tools/testing/selftests/kvm/lib/kvm_util.c | 35 ++++++------------- > 2 files changed, 14 insertions(+), 27 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h > index 5a7a455b5387..95bc0a78d2bc 100644 > --- a/tools/testing/selftests/kvm/include/kvm_util.h > +++ b/tools/testing/selftests/kvm/include/kvm_util.h > @@ -991,11 +991,11 @@ void kvm_gsi_routing_write(struct kvm_vm *vm, struct kvm_irq_routing *routing); > const char *exit_reason_str(unsigned int exit_reason); > > gpa_t vm_phy_page_alloc(struct kvm_vm *vm, gpa_t min_gpa, u32 memslot); > -gpa_t __vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, gpa_t min_gpa, > +gpa_t __vm_phy_pages_alloc(struct kvm_vm *vm, size_t nr_pages, gpa_t min_gpa, > u32 memslot, bool protected); > gpa_t vm_alloc_page_table(struct kvm_vm *vm); > > -static inline gpa_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, > +static inline gpa_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t nr_pages, > gpa_t min_gpa, u32 memslot) > { > /* > @@ -1003,7 +1003,7 @@ static inline gpa_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, > * protected memory, as the majority of memory for such VMs is > * protected, i.e. using shared memory is effectively opt-in. > */ > - return __vm_phy_pages_alloc(vm, num, min_gpa, memslot, > + return __vm_phy_pages_alloc(vm, nr_pages, min_gpa, memslot, > vm_arch_has_protected_memory(vm)); > } > > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 9ddc047d5c27..b071d77dd301 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -2025,33 +2025,20 @@ const char *exit_reason_str(unsigned int exit_reason) > } > > /* > - * Physical Contiguous Page Allocator > + * Allocate contiguous (guest) physical pages in a given memory region, at or > + * the minimum specific GPA. If the memory is protected/private, also add the at or "above" the minimum ... Otherwise looks good. Feel free to add: Reviewed-by: Ritesh Harjani (IBM) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A447C624D3 for ; Fri, 4 Sep 2026 13:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:Message-ID:Date: In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bc/hqkOHD/MJrxZGFRPZIZnv37HunEKdYYawoMX3RZw=; b=0IB8khXvT1VRYO AbNfBr6rfBGaxhrBWf8A0fRrED9Ykt7tFBEp2pczQMfdeWXjpdFpOIlDOjphlm5yAqPQFxYEb9ThM ctfqLEmywUSDnRRi7CbSev7HmcdWdJ7orBWiL8VYcQl8KJdqBEwIToK0w3phUiv/y+XwcVOT40GRf LNo6wVAakU+7vZdfiwj1knZlBZbjQMrGFEFzbrRe/Hf3tfaSvJFWjww8NGiIUJcbZ5i0Inn/Mrsj9 tCVplrf6M89nQYMSAI8It2/er335AP1pK4Pz5+AOv1gZM1UxMBrJVhEse8Z/IOk9BMek/B2IuhbRh 7+T6fMDOaob2CQ7JzUHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2U1Y-00000002ELM-08TG; Fri, 04 Sep 2026 13:32:08 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2U1V-00000002EJV-0IkK for kvm-riscv@lists.infradead.org; Fri, 04 Sep 2026 13:32:07 +0000 Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-398a4dcf289so1178713a91.2 for ; Fri, 04 Sep 2026 06:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788528724; x=1789133524; darn=lists.infradead.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=gE9P4GObqZliYweF8gHdbLVlqBxBO1frIJ8W7HGnk/w=; b=B4iFs3K2aKZTN0IMEqYzMyLkOxsoJAXBebAypvCf4ETxvNj3lBj4kx9BCwvwBCQoIF kzoAbM6QOutcalX2jatvq/ns2MU1kQtvwkZvOlenG+zXEeARHJaasE2YIbdnTTGYrDjd 4zWQ4DJ8cd4SfvmKSrI/rwWu6/eGcWQId1vOIjBh3IGJw/DeVdtkmhgVI+G95imIjAbv 2UmAbutuM6lDzE+7k9/R2GSov1ITbPLEmTgKE3aSfCRRC7sO0/yUwLLnUPh0ZLdlO9Iz 1p8IK8zZ0zf3UR1OfNNMJd7zyX8aI+cEC1jxSqWwPEFYY4Skydc2wcWjKPpgQ8fj2gMq Yhcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788528724; x=1789133524; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gE9P4GObqZliYweF8gHdbLVlqBxBO1frIJ8W7HGnk/w=; b=FSNc64gD9HYsnz0wnhocgOTBOw+AsYY/Y6OWprraAL4UaAWPbRV1PvFD9OPEp/0GPl Zcr0/jtCrDZPpbNkmsU418zDtYQ9aXa6WKSKnk6FXYspD+Nz07UdPAI+TpoxC8u5Wd14 J2mDsgKJ+9d5RWW4xvE7yl3GajmjhNMZJlXDqfQS4pqtrnj0Pw7Ctm/GuU/8NtXoB62d zohqJQ71nNKhMowIIhM+2+LNaDVYLZUS8ZTUivW6PT1cIgxweWrqCBM+uuSAgk0dl+sb TigS3XrONt7wnLb7zOVx2dWMf3hPgrfRBX+Zn4LN/5wSp4Iyh4ZKiXZTvE9Ksx/KqD9N vfvg== X-Forwarded-Encrypted: i=1; AKwUvBzK0Ie/1h2P99EctktY8YZyOkhJZDcwOOfc1Af+HeccOY/6R5jxaPZKeeOzdTnMlEovD+sFNSV6cKg=@lists.infradead.org X-Gm-Message-State: AFuF++nTlYOiNMJm3RVR8Ihn9CDBbs07U5hIXVAbwAH5072OSrT1tjxc eGH/KNQw+FRaBrqO/UgE1oEGXnO9dsyPkV26XoD1y22eOobWzJwIv5He X-Gm-Gg: AYBFou0fKMgywpwzEvJ2o368VC6IbtirAUF55u56Vg2Lcd59BYCeZWZ6fPPbByXcywU 0wVifSejRrXM//Dr7GhevUaS0bRYqsCxm9yPs0yXydqOHwkJD3VtRHbL1PZCduXDXNb8Hc0VSxF pr0bTw9NAdj0CYLfc7GmnSHSHrpN9DhgEmTbmhKbKQRcRl+jjLb2tQEXzyNFXNz/Uv4U/MloC1+ fa5eObNhV/o7Qozk6LEhwNMmGtCj31GxUuS65TZFeKFmViGrky+ZVSv9RIxcruNnH2tVPzw/zZq SwxIYEd6IjWb6iJPwxJRTdTxUJF4PuyQYayOVu4hgecbyALzvtPzPVDtx6jEpqKilDXFh9pk2aP KBxXvj3GHKXJQFgzKWx+0l3M4wuIv2Z3+teXJvYU/7gk0ZlE+rg6ZVeUvJz1TBs/QLO5wQAoXfS Zvxi14JKBE4Laz42Wy4yUxSNh1zH4b/Ia49PoICYVTwalsT51LZ1S676J6f2dT2EGsYYpJEumcA hV52iBwrkroo8L9Fqn5xsgrfrdA5Srco1KxOQXz9C+g X-Received: by 2002:a17:90b:3a50:b0:38e:4cb:51f with SMTP id 98e67ed59e1d1-39b26101576mr10859346a91.11.1788528723581; Fri, 04 Sep 2026 06:32:03 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339a534d25sm7083483eec.5.2026.09.04.06.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 06:32:02 -0700 (PDT) From: Ritesh Harjani (IBM) To: Sean Christopherson , Marc Zyngier , Oliver Upton , Sean Christopherson , Paolo Bonzini , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Atish Patra , Alexandre Ghiti , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Itaru Kitayama , Nicholas Piggin Subject: Re: [PATCH v2 04/20] KVM: selftests: Rename "num" param to "nr_pages" for physical page allocators In-Reply-To: <20260902164123.2546762-5-seanjc@google.com> Date: Fri, 04 Sep 2026 19:00:16 +0530 Message-ID: References: <20260902164123.2546762-1-seanjc@google.com> <20260902164123.2546762-5-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260904_063205_112309_5237C61F X-CRM114-Status: GOOD ( 14.63 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org Sean Christopherson writes: > Rename the "num" param in the physical page allocator APIs to "nr_pages" to > make the unit and role of the param more obvious. > > Opportunistically rework the function comment to drop the superfluous > kerneldoc style, and to very explicitly call out that success is guaranteed. > > No functional change intended. > > Tested-by: Itaru Kitayama > Signed-off-by: Sean Christopherson > --- > .../testing/selftests/kvm/include/kvm_util.h | 6 ++-- > tools/testing/selftests/kvm/lib/kvm_util.c | 35 ++++++------------- > 2 files changed, 14 insertions(+), 27 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h > index 5a7a455b5387..95bc0a78d2bc 100644 > --- a/tools/testing/selftests/kvm/include/kvm_util.h > +++ b/tools/testing/selftests/kvm/include/kvm_util.h > @@ -991,11 +991,11 @@ void kvm_gsi_routing_write(struct kvm_vm *vm, struct kvm_irq_routing *routing); > const char *exit_reason_str(unsigned int exit_reason); > > gpa_t vm_phy_page_alloc(struct kvm_vm *vm, gpa_t min_gpa, u32 memslot); > -gpa_t __vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, gpa_t min_gpa, > +gpa_t __vm_phy_pages_alloc(struct kvm_vm *vm, size_t nr_pages, gpa_t min_gpa, > u32 memslot, bool protected); > gpa_t vm_alloc_page_table(struct kvm_vm *vm); > > -static inline gpa_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, > +static inline gpa_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t nr_pages, > gpa_t min_gpa, u32 memslot) > { > /* > @@ -1003,7 +1003,7 @@ static inline gpa_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, > * protected memory, as the majority of memory for such VMs is > * protected, i.e. using shared memory is effectively opt-in. > */ > - return __vm_phy_pages_alloc(vm, num, min_gpa, memslot, > + return __vm_phy_pages_alloc(vm, nr_pages, min_gpa, memslot, > vm_arch_has_protected_memory(vm)); > } > > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 9ddc047d5c27..b071d77dd301 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -2025,33 +2025,20 @@ const char *exit_reason_str(unsigned int exit_reason) > } > > /* > - * Physical Contiguous Page Allocator > + * Allocate contiguous (guest) physical pages in a given memory region, at or > + * the minimum specific GPA. If the memory is protected/private, also add the at or "above" the minimum ... Otherwise looks good. Feel free to add: Reviewed-by: Ritesh Harjani (IBM) -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv