From: Eric Dumazet <eric.dumazet@gmail.com>
To: Yuchung Cheng <ycheng@google.com>, Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Jean-Louis Dupond <jean-louis@dupond.be>,
Neal Cardwell <ncardwell@google.com>
Subject: Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue
Date: Wed, 21 Nov 2018 14:40:03 -0800 [thread overview]
Message-ID: <ed3b38f5-14f9-2cae-b52d-35fd011ebcf0@gmail.com> (raw)
In-Reply-To: <CAK6E8=en_sPbKnb60YnPYrVBYKY1doG_V-FFgzrbAv4gnQwy5w@mail.gmail.com>
On 11/21/2018 02:31 PM, Yuchung Cheng wrote:
> On Wed, Nov 21, 2018 at 9:52 AM, Eric Dumazet <edumazet@google.com> wrote:
>> +
> Really nice! would it make sense to re-use (some of) the similar
> tcp_try_coalesce()?
>
Maybe, but it is a bit complex, since skbs in receive queues (regular or out of order)
are accounted differently (they have skb->destructor set)
Also they had the TCP header pulled already, while the backlog coalescing also has
to make sure TCP options match.
Not sure if we want to add extra parameters and conditional checks...
next prev parent reply other threads:[~2018-11-22 9:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 17:52 [PATCH net-next 0/3] tcp: take a bit more care of backlog stress Eric Dumazet
2018-11-21 17:52 ` [PATCH net-next 1/3] tcp: remove hdrlen argument from tcp_queue_rcv() Eric Dumazet
2018-11-21 22:41 ` Yuchung Cheng
2018-11-21 17:52 ` [PATCH net-next 2/3] tcp: implement coalescing on backlog queue Eric Dumazet
2018-11-21 22:31 ` Yuchung Cheng
2018-11-21 22:40 ` Eric Dumazet [this message]
2018-11-22 16:34 ` Yuchung Cheng
2018-11-22 18:01 ` Neal Cardwell
2018-11-22 18:16 ` Eric Dumazet
2018-11-22 18:21 ` Eric Dumazet
2018-11-21 17:52 ` [PATCH net-next 3/3] tcp: implement head drops in " Eric Dumazet
2018-11-21 22:40 ` Yuchung Cheng
2018-11-21 22:47 ` Eric Dumazet
2018-11-21 23:46 ` Yuchung Cheng
2018-11-21 23:52 ` Eric Dumazet
2018-11-22 0:18 ` Eric Dumazet
2018-11-22 0:54 ` Yuchung Cheng
2018-11-22 1:01 ` Eric Dumazet
2018-11-23 19:25 ` [PATCH net-next 0/3] tcp: take a bit more care of backlog stress David Miller
2018-11-23 19:27 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2019-04-07 21:28 [PATCH net-next 2/3] tcp: implement coalescing on backlog queue richard.purdie
2019-04-24 14:51 ` Bruno Prémont
2019-04-24 15:47 ` Eric Dumazet
2019-04-25 7:55 ` Bruno Prémont
2019-04-25 13:13 ` Bruno Prémont
2019-04-25 13:30 ` Eric Dumazet
2019-04-25 14:16 ` Bruno Prémont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed3b38f5-14f9-2cae-b52d-35fd011ebcf0@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jean-louis@dupond.be \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.