Re: [S390] cio: kernel stack overflow.

[daw@cs.berkeley.edu (David Wagner)]

Have you checked that in all cases all fields of the struct have
been overwritten?  For instance, look at this:

Martin Schwidefsky  wrote:
>-	chp->dev = (struct device) {
>-		.parent  = &css[0]->device,
>-		.release = chp_release,
>-	};
>+	chp->dev.parent = &css[0]->device;
>+	chp->dev.release = chp_release;

Doesn't this leave chp->dev.bus still holding whatever old value it
had laying around before?  Unless I'm missing something, it looks to
me like this diff causes a change in the semantics of the code.

Perhaps it would be better to memset() the entire struct (chp->dev, in
this case) to zero, before assigning to individual fields, so there is
no possibility of old remnant data still being left laying around?