Re: [LTP] [PATCH v2] Refactor aiocp using new LTP API

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

Hi!

On 8/2/22 16:30, Cyril Hrubis wrote:
> Hi!
>> I think that check doesn't make much sense and we probably should stuck
>> to "n = aionum - busy",
>> since that's the value we always need to allocate since became free in
>> the previous loop iteration.
> I guess MIN(aionum-busy, tocopy) or something like this since we want to
> avoid schedulling reads past the end of the file.
>
>>>> +	aio_blksize = 64 * 1024;
>>>> +	filesize = 1 * 1024 * 1024;
>>>> +	aionum = 16;
>>>> +	srcflags = O_RDONLY;
>>>> +	dstflags = O_WRONLY;
>>> Can we just initialize the globals directly instead of here in the test
>>> setup()?
>> In the last ltp-aiodio tests, we decided to initialize global variables
>> inside setup().
> Wasn't it exactly the other way around?
>
Sorry, you are right. Got confused.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp