From: Krzysztof Kozlowski <krzk@kernel.org>
To: Artur Weber <aweber.kernel@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Alex Elder <elder@kernel.org>,
Stanislav Jakubek <stano.jakubek@gmail.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v3 4/9] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx bus clocks
Date: Tue, 11 Mar 2025 08:36:37 +0100 [thread overview]
Message-ID: <ed700b54-8599-4775-b07f-43c7d62ae722@kernel.org> (raw)
In-Reply-To: <2b120341-0026-4a9c-9ad1-b14adfac50c8@gmail.com>
On 10/03/2025 21:20, Artur Weber wrote:
> On 10.03.2025 10:43, Krzysztof Kozlowski wrote:
>> On Sat, Mar 08, 2025 at 08:50:42AM +0100, Artur Weber wrote:
>>> Add bus clocks corresponding to peripheral clocks currently supported
>>> by the BCM281xx clock driver and add the relevant clock IDs to the
>>> clock/bcm281xx.h dt-bindings header.
>>
>> Please squash the patch so we see complete change.
>
> Squash which patch(-es)? Both CCU bindings and the dt-bindings header
> are modified in this patch, as outlined in the commit message (though
> now that I look at it, I could reword the first sentence to specifically
> imply "add bus clocks *to the binding*"...). What is missing?
If I got it correctly, you are changing the same lines in bindings in
two patches, so squash these two patches.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-11 7:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 7:50 [PATCH v3 0/9] clk: bcm: kona: Add bus clock support, bus clocks for BCM21664/BCM281xx Artur Weber
2025-03-08 7:50 ` [PATCH v3 1/9] clk: bcm: kona: Move CLOCK_COUNT defines into the driver Artur Weber
2025-03-10 8:40 ` Krzysztof Kozlowski
2025-03-16 19:01 ` Artur Weber
2025-03-17 7:29 ` Krzysztof Kozlowski
2025-03-08 7:50 ` [PATCH v3 2/9] dt-bindings: clock: brcm,kona-ccu: Drop CLOCK_COUNT defines from DT headers Artur Weber
2025-03-10 8:41 ` Krzysztof Kozlowski
2025-03-08 7:50 ` [PATCH v3 3/9] dt-bindings: clock: brcm,kona-ccu: Add BCM21664 bus clocks Artur Weber
2025-03-10 8:41 ` Krzysztof Kozlowski
2025-03-08 7:50 ` [PATCH v3 4/9] dt-bindings: clock: brcm,kona-ccu: Add BCM281xx " Artur Weber
2025-03-10 9:43 ` Krzysztof Kozlowski
2025-03-10 20:13 ` Artur Weber
2025-03-10 20:20 ` Artur Weber
2025-03-11 7:36 ` Krzysztof Kozlowski [this message]
2025-03-08 7:50 ` [PATCH v3 5/9] clk: bcm: kona: Add support for " Artur Weber
2025-03-08 7:50 ` [PATCH v3 6/9] clk: bcm21664: Add matching bus clocks for peripheral clocks Artur Weber
2025-03-08 7:50 ` [PATCH v3 7/9] clk: bcm281xx: Add corresponding " Artur Weber
2025-03-08 7:50 ` [PATCH v3 8/9] ARM: dts: bcm2166x-common: Add matching " Artur Weber
2025-03-08 7:50 ` [PATCH v3 9/9] ARM: dts: bcm11351: Add corresponding " Artur Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed700b54-8599-4775-b07f-43c7d62ae722@kernel.org \
--to=krzk@kernel.org \
--cc=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.