From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH S38 06/15] ice: Add support to enable/disable all Rx queues before waiting
Date: Mon, 27 Jan 2020 23:14:20 +0000 [thread overview]
Message-ID: <ed752e9fee864b698e21be3b0a2e66d3@intel.com> (raw)
In-Reply-To: <20200122152138.41585-6-anthony.l.nguyen@intel.com>
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Wednesday, January 22, 2020 7:21 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S38 06/15] ice: Add support to
> enable/disable all Rx queues before waiting
>
> From: Brett Creeley <brett.creeley@intel.com>
>
> Currently when we enable/disable all Rx queues we do the following
> sequence for each Rx queue and then move to the next queue.
>
> 1. Enable/Disable the Rx queue via register write.
> 2. Read the configuration register to determine if the Rx queue was
> enabled/disabled successfully.
>
> In some cases enabling/disabling queue 0 fails because of step 2 above.
> Fix this by doing step 1 for all of the Rx queues and then step 2 for all of the
> Rx queues.
>
> Also, there are cases where we enable/disable a single queue (i.e.
> SR-IOV and XDP) so add a new function that does step 1 and 2 above with a
> read flush in between.
>
> This change also required a single Rx queue to be enabled/disabled with and
> without waiting for the change to propagate through hardware. Fix this by
> adding a boolean wait flag to the necessary functions.
>
> Also, add the keywords "one" and "all" to distinguish between
> enabling/disabling a single Rx queue and all Rx queues respectively.
>
> Signed-off-by: Brett Creeley <brett.creeley@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_base.c | 42 ++++++++++++++-----
> drivers/net/ethernet/intel/ice/ice_base.h | 4 +-
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 4 +-
> drivers/net/ethernet/intel/ice/ice_lib.c | 32 +++++++++-----
> drivers/net/ethernet/intel/ice/ice_lib.h | 4 +-
> drivers/net/ethernet/intel/ice/ice_main.c | 4 +-
> .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 7 ++--
> drivers/net/ethernet/intel/ice/ice_xsk.c | 4 +-
> 8 files changed, 67 insertions(+), 34 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
next prev parent reply other threads:[~2020-01-27 23:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 15:21 [Intel-wired-lan] [PATCH S38 01/15] ice: Add initial support for QinQ Tony Nguyen
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 02/15] ice: Refactor port vlan configuration for the VF Tony Nguyen
2020-01-27 22:55 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 03/15] ice: Add helper to determine if VF link is up Tony Nguyen
2020-01-27 22:55 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 04/15] ice: Fix Port VLAN priority bits Tony Nguyen
2020-01-27 23:04 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 05/15] ice: Only allow tagged bcast/mcast traffic for VF in port VLAN Tony Nguyen
2020-01-27 23:13 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 06/15] ice: Add support to enable/disable all Rx queues before waiting Tony Nguyen
2020-01-27 23:14 ` Bowers, AndrewX [this message]
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 07/15] ice: Fix implicit queue mapping mode in ice_vsi_get_qs Tony Nguyen
2020-01-27 23:14 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 08/15] ice: Handle LAN overflow event for VF queues Tony Nguyen
2020-01-27 23:15 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 09/15] ice: Fix and refactor Rx queue disable for VFs Tony Nguyen
2020-01-27 23:15 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 10/15] ice: Fix virtchnl_queue_select bitmap validation Tony Nguyen
2020-01-27 23:16 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 11/15] ice: remove unnecessary fallthrough comments Tony Nguyen
2020-01-27 23:17 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 12/15] ice: replace "fallthrough" comments with fallthrough reserved word Tony Nguyen
2020-01-27 23:18 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 13/15] ice: use proper format for function pointer as a function parameter Tony Nguyen
2020-01-27 23:19 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 14/15] ice: add function argument description to function header comment Tony Nguyen
2020-01-27 23:19 ` Bowers, AndrewX
2020-01-22 15:21 ` [Intel-wired-lan] [PATCH S38 15/15] ice: use true/false for bool types Tony Nguyen
2020-01-27 23:20 ` Bowers, AndrewX
2020-01-27 22:53 ` [Intel-wired-lan] [PATCH S38 01/15] ice: Add initial support for QinQ Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed752e9fee864b698e21be3b0a2e66d3@intel.com \
--to=andrewx.bowers@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.