All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Julien Thierry <julien.thierry@arm.com>
Subject: Re: [PATCH] arm64/irq: use NMI to send stop IPI
Date: Mon, 14 Dec 2020 13:24:30 +0000	[thread overview]
Message-ID: <ed75ae7aa73653420f1ab1182647d302@kernel.org> (raw)
In-Reply-To: <CAFgQCTsxKr-B7XwED8k_20in3L5ysC+zWjVCoxRXw=eXe7hxLQ@mail.gmail.com>

On 2020-12-14 13:04, Pingfan Liu wrote:
> On Mon, Dec 14, 2020 at 5:46 PM Marc Zyngier <maz@kernel.org> wrote:
>> 
>> On 2020-12-14 02:20, Pingfan Liu wrote:
>> 
>> [...]
>> 
>> > After serval days of chasing this issue, I have a raw idea about it.
>> > What about re-structure the code like
>> > DEFINE_IDTENTRY_SYSVEC_SIMPLE(sysvec_reschedule_ipi) ?
>> 
>> I'm not sure how you want to mimic what x86 does, given that we have
>> at least three different root interrupt controllers on arm64 (plus
>> a fourth coming up), all of which have access methods that are not
>> part of the CPU architecture, and that are shared with the 32bit
>> part.
>> 
> I just found that Mark had implemented enter_el1_irq_or_nmi() for
> arm64, and think it is another way to handle the problem.
> 
> I had thought if aligned to x86, then linux/kernel/entry/common.c can
> be used. It may bring benefits, e.g. shift off the rcu/lockdep/dyntick
> to core kernel.

Using the entry/common.c stuff is indeed what we are planning to do,
but the current arm64 code doesn't lend itself to that just yet,

> 
> Anyway, I am a new beginner at this. If my opinion is not good enough,
> please just ignore it.
>> > I will send a series soon afterward.
>> 
>> Please wait until the merge window is over.
>> 
> Sorry that it has been sent out before your reply. If there is V2, I
> will do it after the merge window.

Please look at the series I pointed you too (and its follow-up), which
has most of what you are trying to achieve already.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-12-14 13:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 13:14 [PATCH] arm64/irq: use NMI to send stop IPI Pingfan Liu
2020-12-08 14:04 ` Marc Zyngier
2020-12-14  2:20   ` Pingfan Liu
2020-12-14  2:25     ` [PATCH 1/3] kernel/irq: __handle_domain_irq() makes irq_enter/exit arch optional Pingfan Liu
2020-12-14  2:25       ` [PATCH 2/3] arm64/irq-gic-v3: make gic_handle_irq() cope with enter_from_kernel_mode() Pingfan Liu
2020-12-14  2:25       ` [PATCH 3/3] arm64/irq-gic-v3: make reschedule-ipi light weight Pingfan Liu
2020-12-14  9:46     ` [PATCH] arm64/irq: use NMI to send stop IPI Marc Zyngier
2020-12-14 13:04       ` Pingfan Liu
2020-12-14 13:24         ` Marc Zyngier [this message]
2020-12-15  5:40           ` Pingfan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed75ae7aa73653420f1ab1182647d302@kernel.org \
    --to=maz@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=julien.thierry@arm.com \
    --cc=kernelfans@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.