From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [PATCH] ASoC: Intel: Baytrail: Fix implicit fallthrough warning Date: Thu, 22 Aug 2019 09:08:57 -0500 Message-ID: References: <20190822120135.13515-1-cezary.rojewski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AE3F1F80112 for ; Thu, 22 Aug 2019 16:09:00 +0200 (CEST) In-Reply-To: <20190822120135.13515-1-cezary.rojewski@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Cezary Rojewski , alsa-devel@alsa-project.org Cc: broonie@kernel.org, tiwai@suse.com, lgirdwood@gmail.com List-Id: alsa-devel@alsa-project.org On 8/22/19 7:01 AM, Cezary Rojewski wrote: > Separate _SUSPEND from _PAUSE_PUSH to ensure code is handled correctly > while fixing warning reported during compilation. > > Fixes: b80d19c166c4 ("ASoC: Intel: Restore Baytrail ADSP streams only when ADSP was in reset") > Signed-off-by: Cezary Rojewski > --- > sound/soc/intel/baytrail/sst-baytrail-pcm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c b/sound/soc/intel/baytrail/sst-baytrail-pcm.c > index 9cbc982d46a9..eddb24ab8072 100644 > --- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c > +++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c > @@ -193,6 +193,8 @@ static int sst_byt_pcm_trigger(struct snd_pcm_substream *substream, int cmd) > break; > case SNDRV_PCM_TRIGGER_SUSPEND: > pdata->restore_stream = false; > + sst_byt_stream_pause(byt, pcm_data->stream); > + break; why not just a /* fallthrough */ statement? > case SNDRV_PCM_TRIGGER_PAUSE_PUSH: > sst_byt_stream_pause(byt, pcm_data->stream); > break; >