Re: [PATCH v3 3/7] coverage: introduce generic file

[George Dunlap <george.dunlap@citrix.com>]

On 01/25/2018 02:47 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Jan 24, 2018 at 10:01:21AM +0000, Roger Pau Monne wrote:
>> It will contain the generic implementation of sysctl_cov_op, which
>> will be shared between all the coverage implementations.
>>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> ---
>> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
>> Cc: George Dunlap <George.Dunlap@eu.citrix.com>
>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>> Cc: Jan Beulich <jbeulich@suse.com>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> Cc: Stefano Stabellini <sstabellini@kernel.org>
>> Cc: Tim Deegan <tim@xen.org>
>> Cc: Wei Liu <wei.liu2@citrix.com>
>> ---
>> Changes since v1:
>>  - Use private coverage.h header.
>>  - Sort alphabetically the obj-y list.
>> ---
>>  xen/common/coverage/Makefile   |  2 +-
>>  xen/common/coverage/coverage.c | 73 ++++++++++++++++++++++++++++++++++++++++++
>>  xen/common/coverage/coverage.h |  1 +
>>  xen/common/coverage/gcov.c     | 39 +---------------------
>>  4 files changed, 76 insertions(+), 39 deletions(-)
>>  create mode 100644 xen/common/coverage/coverage.c
>>
>> diff --git a/xen/common/coverage/Makefile b/xen/common/coverage/Makefile
>> index a7a48494ca..5387bc6429 100644
>> --- a/xen/common/coverage/Makefile
>> +++ b/xen/common/coverage/Makefile
>> @@ -1,4 +1,4 @@
>> -obj-y += gcov_base.o gcov.o
>> +obj-y += coverage.o gcov_base.o gcov.o
>>  obj-y += $(call cc-ifversion,lt,0x040700, \
>>  		gcc_3_4.o, $(call cc-ifversion,lt,0x040900, \
>>  		gcc_4_7.o, $(call cc-ifversion,lt,0x050000, \
>> diff --git a/xen/common/coverage/coverage.c b/xen/common/coverage/coverage.c
>> new file mode 100644
>> index 0000000000..bd90f28663
>> --- /dev/null
>> +++ b/xen/common/coverage/coverage.c
>> @@ -0,0 +1,73 @@
>> +/*
>> + * Generic functionality for coverage analysis.
>> + *
>> + * Copyright (C) 2017 Citrix Systems R&D
> 
> 2018 now I believe.

I'm pretty sure the copyright starts from the time the work is created,
not the time it gets checked into a public tree.  Most of this would
have been written last year.

Since we're being pedantic. ;-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel