From: David Hildenbrand <david@redhat.com>
To: Suren Baghdasaryan <surenb@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: hughd@google.com, hannes@cmpxchg.org,
vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org,
shy828301@gmail.com, pasha.tatashin@soleen.com,
paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz,
Liam.Howlett@oracle.com, ccross@google.com, willy@infradead.org,
arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com,
bagasdotme@gmail.com, suleiman@google.com, steven@liquorix.net,
heftig@archlinux.org, cuigaosheng1@huawei.com,
kirill@shutemov.name, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com
Subject: Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs
Date: Thu, 5 Jan 2023 10:03:19 +0100 [thread overview]
Message-ID: <ed9dc172-e519-3fd5-afa4-0089b083ee10@redhat.com> (raw)
In-Reply-To: <CAJuCfpGHMeWSSp+ge3pPppLrQ5BpGiga=fjKmDk65GTjFDV=3w@mail.gmail.com>
On 05.01.23 03:39, Suren Baghdasaryan wrote:
> On Wed, Jan 4, 2023 at 5:38 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>>
>> On Wed, 4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan <surenb@google.com> wrote:
>>
>>> free_anon_vma_name() is missing a check for anonymous shmem VMA which
>>> leads to a memory leak due to refcount not being dropped. Fix this by
>>> calling anon_vma_name_put() unconditionally. It will free vma->anon_name
>>> whenever it's non-NULL.
>>>
>>> Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming")
>>
>> A cc:stable is appropriate here, yes?
>
> Hmm. The patch we are fixing here was merged in 6.2-rc1. Should I CC
> stable to fix the previous -rc branch?
>
No need for stable if it's not in a release kernel yet.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-01-05 9:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 0:02 [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs Suren Baghdasaryan
2023-01-05 1:38 ` Andrew Morton
2023-01-05 2:39 ` Suren Baghdasaryan
2023-01-05 9:03 ` David Hildenbrand [this message]
2023-01-05 12:07 ` Holger Hoffstätte
2023-01-05 12:18 ` David Hildenbrand
2023-01-05 9:04 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed9dc172-e519-3fd5-afa4-0089b083ee10@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bagasdotme@gmail.com \
--cc=ccross@google.com \
--cc=cgel.zte@gmail.com \
--cc=cuigaosheng1@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=heftig@archlinux.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=paul.gortmaker@windriver.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=shy828301@gmail.com \
--cc=steven@liquorix.net \
--cc=suleiman@google.com \
--cc=surenb@google.com \
--cc=syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com \
--cc=vbabka@suse.cz \
--cc=vincent.whitchurch@axis.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.