From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: gitweb_check_feature always return list
Date: Fri, 01 Sep 2006 22:12:29 +0200 [thread overview]
Message-ID: <eda475$ob7$1@sea.gmane.org> (raw)
In-Reply-To: eda2q0$la8$1@sea.gmane.org
<opublikowany i wysłany>
Jakub Narebski wrote:
> Junio C Hamano wrote:
>
>> Jakub Narebski <jnareb@gmail.com> writes:
>>
>>> Modified feature_blame so it returns one-element list and not scalar,
>>> thus making gitweb_check_feature always return list. Updated comment
>>> to explain that part.
>>
>> I do not understand what you are fixing.
>>
>> sub A { return (1); }
>> sub B { return 1; }
>>
>> Don't they quack the same way?
>
> Well, that is just nitpicking. gitweb_check_feature returns list if feature
> is not overridable, so I made it that it always returns list.
Then I'm not sure if Aneesh Kumar patch I replied to is really necessary.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
--
VGER BF report: U 0.499824
prev parent reply other threads:[~2006-09-01 20:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 3:43 [PATCH] gitweb: Fix git_blame Aneesh Kumar K.V
2006-09-01 9:07 ` Jakub Narebski
2006-09-01 19:31 ` [PATCH] gitweb: gitweb_check_feature always return list Jakub Narebski
2006-09-01 19:37 ` Junio C Hamano
2006-09-01 19:48 ` Jakub Narebski
2006-09-01 20:12 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eda475$ob7$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.