Re: [Intel-xe] [PATCH] drm/xe: Print GT info on TLB inv failure

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 05.05.2023 15:47, Rodrigo Vivi wrote:
> On Fri, May 05, 2023 at 03:34:33PM +0200, Nirmoy Das wrote:
>> Print GT info on TLB inv failure for better debugbility.
>>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
>> ---
>>  drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
>> index 604f189dbd70..9e7fe8d9bca4 100644
>> --- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
>> +++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
>> @@ -34,8 +34,8 @@ static void xe_gt_tlb_fence_timeout(struct work_struct *work)
>>  			break;
>>  
>>  		trace_xe_gt_tlb_invalidation_fence_timeout(fence);
>> -		drm_err(&gt_to_xe(gt)->drm, "TLB invalidation fence timeout, seqno=%d",
>> -			fence->seqno);
>> +		drm_err(&gt_to_xe(gt)->drm, "gt%d: TLB invalidation fence timeout, seqno=%d",
>> +			gt->info.id, fence->seqno);
>>  
>>  		list_del(&fence->link);
>>  		fence->base.error = -ETIME;
>> @@ -285,8 +285,8 @@ int xe_gt_tlb_invalidation_wait(struct xe_gt *gt, int seqno)
>>  				 tlb_invalidation_seqno_past(gt, seqno),
>>  				 TLB_TIMEOUT);
>>  	if (!ret) {
>> -		drm_err(&xe->drm, "TLB invalidation time'd out, seqno=%d, recv=%d\n",
>> -			seqno, gt->tlb_invalidation.seqno_recv);
>> +		drm_err(&xe->drm, "gt%d: TLB invalidation time'd out, seqno=%d, recv=%d\n",
>> +			gt->info.id, seqno, gt->tlb_invalidation.seqno_recv);

as a reminder, there is pending series with gt log wrappers [1] that
could be used also here to avoid manual addition of "gt%u" prefix

[1] https://patchwork.freedesktop.org/series/115083/

>>  		return -ETIME;
>>  	}
>>  
>> -- 
>> 2.39.0
>>