From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D88714F9F9 for ; Sat, 8 Mar 2025 11:00:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741431650; cv=none; b=QamsakU/jX8la76jG1haY71jE7S/Xlm18q54vWBUxoAq4zQ3ffwBmaG35cIURvUzPyoh8sORwqrGyDD5fnBF5ODpy0TcTD3u3ffEMp5ucBiVfb0Be8NrkJfLL3vuevFUBgd8TtuXh1xW7yWhN3wMPL7wXvTACQDUaWp+Y1BuBPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741431650; c=relaxed/simple; bh=adKhsoYCOCoDj5zg/Jhy4QF/2605gBuniQhr/kAlYpg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fEDvypc+dOSeoWQSLPS5JMHalVEA3x4Sii1/1MmdrDELk0aBaTeLWLAm6UKSDAzW4R163AUo8Iv/85ksKYlER8qgdt51BvIUcGTIMEZKS+WtPXOt05gnuJ+wsjUAyFNogfWQvs1JhK4Mj/z8T+jAZrli5lJTGBkiSfftFi4bZGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CEswD5a3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CEswD5a3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F79FC4CEE0; Sat, 8 Mar 2025 11:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741431649; bh=adKhsoYCOCoDj5zg/Jhy4QF/2605gBuniQhr/kAlYpg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CEswD5a3KFvZbOOg0RAgor7Q6z46vL2ypZjo/qc0n5wtMVrH86ryxdj4tYPeM5xXW 4iTTN0Qodg3rWXFPuTKrLtzcq4awsKWEJZH7bR7GM8LSxKFzivWoyqOtpszAIubSkq Zuk4t398wC4ZLxXImfZ+23FRISjzzj/4w3vXgDgUnbiKiTNdOi+Ln9bDYnQ6sFiHM1 lNVee2c4/UyVXvEos241LKjswEATTRHZZFhOBppt06lnAfLgtQRZVGb4WPTB7EQ9cl xsQzSdwbSSwbXJ8qDrhYbgMZhHDSdZ0jsyqrBBtbjldKX3HFVB0n4NhObSEqxdOuwu WpXWkhvGH+z1Q== Message-ID: Date: Sat, 8 Mar 2025 12:00:44 +0100 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH mptcp-next v2 05/11] mptcp: add mptcp_subflow_sched bpf_iter Content-Language: en-GB To: Geliang Tang , mptcp@lists.linux.dev Cc: Geliang Tang , Mat Martineau References: From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Geliang, On 07/03/2025 12:36, Geliang Tang wrote: > From: Geliang Tang > > Add a new bpt_iter mptcp_subflow_sched, it's a wrapper of mptcp_subflow. > > Signed-off-by: Geliang Tang > --- > net/mptcp/bpf.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/net/mptcp/bpf.c b/net/mptcp/bpf.c > index 3921261b4fd4..c31f7b407b84 100644 > --- a/net/mptcp/bpf.c > +++ b/net/mptcp/bpf.c > @@ -288,6 +288,31 @@ bpf_iter_mptcp_subflow_destroy(struct bpf_iter_mptcp_subflow *it) > { > } > > +struct bpf_iter_mptcp_subflow_sched { > + struct bpf_iter_mptcp_subflow it; > +}; > + > +__bpf_kfunc static int > +bpf_iter_mptcp_subflow_sched_new(struct bpf_iter_mptcp_subflow_sched *it, > + struct sock *sk, struct mptcp_sched_data *data) > +{ > + if (!mptcp_sched_check_bpf_iter_task(data)) > + return -EINVAL; > + > + return bpf_iter_mptcp_subflow_new(&it->it, sk); We would need the same thing for the BPF PM I suppose, no? Then, why not having something more generic, either: - add "struct task_struct *" in the msk structure - or pass a "const struct task_struct *bpf_iter_task" instead of something sched specific? For the first idea, I guess it should work because the helper will be called when the msk lock will be owned by the caller. So we should not have the PM and scheduler setting it at the same time from different context, right? Also, if this helper receives a msk in argument, no need to check that it is a valid MPTCP socket, etc., right? If one of these two ideas is used, no need to re-introduce mptcp_sched_data. The API is not settled yet, so no need to worry about that. It is even a good time to change it. Cheers, Matt -- Sponsored by the NGI0 Core fund.