From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE2FAC197A0 for ; Mon, 20 Nov 2023 16:40:55 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.637120.992859 (Exim 4.92) (envelope-from ) id 1r57K5-0005Qi-Q0; Mon, 20 Nov 2023 16:40:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 637120.992859; Mon, 20 Nov 2023 16:40:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r57K5-0005Qb-MQ; Mon, 20 Nov 2023 16:40:33 +0000 Received: by outflank-mailman (input) for mailman id 637120; Mon, 20 Nov 2023 16:40:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r57K4-0005QV-3t for xen-devel@lists.xenproject.org; Mon, 20 Nov 2023 16:40:32 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 83e0b60e-87c3-11ee-9b0e-b553b5be7939; Mon, 20 Nov 2023 17:40:29 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 32DAB4EE0739; Mon, 20 Nov 2023 17:40:29 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83e0b60e-87c3-11ee-9b0e-b553b5be7939 MIME-Version: 1.0 Date: Mon, 20 Nov 2023 17:40:29 +0100 From: Nicola Vetrini To: Andrew Cooper Cc: Xen Devel , Julien Grall , Stefano Stabellini , Jbeulich , Roger Pau , Bertrand Marquis , Michal Orzel , Consulting Subject: Re: Remaining violations of MISRA Rule 7.4 In-Reply-To: References: <21761f2a6633a08ceb2b70a46013486a@bugseng.com> Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit > I've just rebased and pushed the residual from the past work (although > I > missed the ARM EFI fix.) > > https://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=commitdiff;h=0f06bab762f5201f3e00aaaee704c3c01f516b51 > https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1065699873 > > I'm going to make a firm request that we fix this by activating > -Wwrite-strings Xen wide, because that's by far and away the best way > to > stop regressions creeping back in. > > In start_xen(), basically whatever goes.  All that's doing is > processing > of one command line into another, and your version looks a bit neater > than mine. > > The name.s cases (it's duplicated in x86 and ARM) are more tricky.  The > compiler warning can be silenced by swapping name.s for name.cs but I > have no idea whether Eclair can see through that piece of blatent > lying. > > ~Andrew Just to avoid any misunderstanding: do you have the intention of evaluating and then perhaps integrate the fixes that at the moment block the introduction of -Wwrite-strings and then respin your patch, or should I do something specifically? -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)