All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Joe Hung (洪銘陽)" <joe_hung@ilitek.com>
To: Rob Herring <robh@kernel.org>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"Luca Hsu (徐嘉鍊)" <luca_hsu@ilitek.com>,
	"Joe Hung (洪銘陽)" <joe_hung@ilitek.com>
Subject: RE: [RESEND PATCH 1/2] dt-bindings: input: touchscreen: ilitek_ts_i2c: Add bindings
Date: Wed, 17 Feb 2021 06:32:58 +0000	[thread overview]
Message-ID: <edfc6f354bbe435a95407b9bbd2f89f8@ilitek.com> (raw)
In-Reply-To: <20210210225718.GA2971881@robh.at.kernel.org>

Hi Rob,

Thank you for your review; agreed on all comments.
Should address your feedback in v2.

On Thu, Feb 04, 2021 at 08:39:01PM +0800, Joe Hung wrote:
> Add binding documentation for ILITEK touch devices.

Bindings are in DT schema format now. Please convert.

> 
> Signed-off-by: Joe Hung <joe_hung@ilitek.com>
> ---
>  .../input/touchscreen/ilitek_ts_i2c.txt       | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt b/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt
> new file mode 100644
> index 000000000000..eb90d3bd7ee7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt
> @@ -0,0 +1,23 @@
> +Ilitek I2C 23XX/25XX/Lego Series Touch ICs
> +
> +Required properties:
> +- compatible		: Must be equal to one of following:
> +			  "ilitek,ili2520"
> +			  "ilitek,ili2510"
> +- reg			: I2C slave address for touch device.
> +- reset-gpios		: GPIO output high to reset pin of touch device.
> +- irq-gpios		: GPIO as active low input from touch irq pin.

Use 'interrupts' instead.

> +
> +Example:
> +	&i2c1 {
> +		/* ... */
> +
> +		touchscreen@41 {
> +			compatible = "ilitek,ili2520";
> +			reg = <0x41>;
> +			irq-gpios = <&gpio1 13 0>;
> +			reset-gpios = <&gpio1 14 GPIO_ACTIVE_HIGH>;
> +		};
> +
> +		/* ... */
> +	};
> -- 
> 2.25.1
> 
> 

      reply	other threads:[~2021-02-17  6:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 12:39 [RESEND PATCH 1/2] dt-bindings: input: touchscreen: ilitek_ts_i2c: Add bindings Joe Hung
2021-02-04 12:39 ` [RESEND PATCH 2/2] input: touchscreen: Add support for ILITEK Lego Series Joe Hung
2021-02-10 22:57 ` [RESEND PATCH 1/2] dt-bindings: input: touchscreen: ilitek_ts_i2c: Add bindings Rob Herring
2021-02-17  6:32   ` Joe Hung (洪銘陽) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edfc6f354bbe435a95407b9bbd2f89f8@ilitek.com \
    --to=joe_hung@ilitek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=luca_hsu@ilitek.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.