Re: [LTP] [PATCH] syscalls/getrusage04: Disable for VIRT_OTHER

[Martin Doucha <mdoucha@suse.cz>]

On 25. 02. 25 16:44, Ricardo B. Marlière wrote:
> On Tue Feb 25, 2025 at 12:09 PM -03, Martin Doucha wrote:
>> Hi,
>> I think it'd be better to change the condition to this:
>>
>> if (tst_is_virt(VIRT_ANY))
>>       tst_brkm(TCONF, ...);
>>
>> Otherwise we'll play endless whack-a-mole with future virt environments.
> 
> But if `systemd-detect-virt` outputs "amazon", wouldn't that translate
> to VIRT_OTHER [1]? i.e. The goal is to also skip on VIRT_OTHER, unless
> we invert the logic.

VIRT_ANY is a wildcard value that'll match any virtualized environment. 
If somebody decides to define separate VIRT_AMAZON env type in the LTP 
library in the future, getrusage04 would start to fail again if we only 
add check for VIRT_OTHER. With VIRT_ANY, the new env type will stay covered.

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp