From: Krzysztof Kozlowski <krzk@kernel.org>
To: "karthik.s" <karthik.s@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: codecs: wcd937x: Add conditional regulator control for wcd937x
Date: Thu, 2 Apr 2026 09:30:22 +0200 [thread overview]
Message-ID: <ee23daf4-8181-4ab0-bd21-b2ea636168f7@kernel.org> (raw)
In-Reply-To: <20260402072256.2811085-1-karthik.s@oss.qualcomm.com>
On 02/04/2026 09:22, karthik.s wrote:
> Add has_always_on_supplies for managing regulators. Indicates that the
> codec power supplies are provided by the board as always-on rails and
> are not switchable by the codec or its associated regulators. This implies
> that the codec supply regulators are always enabled by the system and
> must not be requested or enabled by the codec driver.
>
> Signed-off-by: karthik.s <karthik.s@oss.qualcomm.com>
> ---
> .../devicetree/bindings/sound/qcom,wcd937x.yaml | 8 ++++++++
> sound/soc/codecs/wcd937x.c | 13 +++++++++----
> 2 files changed, 17 insertions(+), 4 deletions(-)
>
I gave you review within 5 minutes and you send exactly the same after.
Without any changelog or explanations or response.
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-02 7:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 7:22 [PATCH v2] ASoC: codecs: wcd937x: Add conditional regulator control for wcd937x karthik.s
2026-04-02 7:30 ` Krzysztof Kozlowski [this message]
[not found] ` <CAPg2bp0DeOcQB-=VJDC5SSiFLLFL6PBPJUBHXSOP9EJZA3+bqw@mail.gmail.com>
2026-04-02 7:50 ` Krzysztof Kozlowski
2026-04-06 9:52 ` Karthik S
2026-04-02 8:29 ` Rob Herring (Arm)
2026-04-06 9:58 ` Karthik S
2026-04-02 11:23 ` Mark Brown
2026-04-10 5:40 ` Karthik S
2026-04-10 10:25 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2026-04-08 2:53 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee23daf4-8181-4ab0-bd21-b2ea636168f7@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=karthik.s@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.