Re: [PATCH net v4] mptcp: fix stale skb->sk reference on subflow close

[Matthieu Baerts <matttbe@kernel.org>]

Hi Kalpan,

On 25/06/2026 08:40, Kalpan Jani wrote:
> Hi Paolo, Matt,
> 
> Gentle ping on this patch.
> 
> https://lore.kernel.org/all/20260601083010.924938-1-kalpan.jani@mpiricsoftware.com/
> 
> I haven't seen any further feedback on v4, so I just wanted to bring it back to your attention in case it was missed.

Sorry for the delay, your patch has not been missed, it is tracked on
patchwork. The delay is due to unfortunate timing from most of us at the
same time, hopefully this will get better at the point, and the load
will decrease!

I will apply the patch, the v4 looks good to me.

> Changes since v3:
> - Rewrote the commit message: the old backlog traversal in mptcp_close_ssk() ran before __mptcp_close_ssk() took the ssk lock, holding neither the ssk lock nor mptcp_data_lock(). The race is a concurrent softirq RX path (subflow_data_ready() -> mptcp_data_ready() -> __mptcp_add_backlog(), under mptcp_data_lock()) adding to the backlog mid-traversal, not anything tied to a release_sock(ssk).
> - Added the missing Fixes tag (ee458a3f314e).

Thank you for the changelog. It is always useful to keep it in the note
section (under '---') to help reviewers.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.