All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] ipv6: add debug checks in fib6_info_release()
Date: Tue, 5 Dec 2023 20:41:02 -0700	[thread overview]
Message-ID: <ee557d3b-79f1-4851-9473-99f711a78f2b@kernel.org> (raw)
In-Reply-To: <20231205173250.2982846-1-edumazet@google.com>

On 12/5/23 10:32 AM, Eric Dumazet wrote:
> Some elusive syzbot reports are hinting to fib6_info_release(),
> with a potential dangling f6i->gc_link anchor.
> 
> Add debug checks so that syzbot can catch the issue earlier eventually.
> 
> BUG: KASAN: slab-use-after-free in __hlist_del include/linux/list.h:990 [inline]
> BUG: KASAN: slab-use-after-free in hlist_del_init include/linux/list.h:1016 [inline]
> BUG: KASAN: slab-use-after-free in fib6_clean_expires_locked include/net/ip6_fib.h:533 [inline]
> BUG: KASAN: slab-use-after-free in fib6_purge_rt+0x986/0x9c0 net/ipv6/ip6_fib.c:1064
> Write of size 8 at addr ffff88802805a840 by task syz-executor.1/10057
> 

...

> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
>  include/net/ip6_fib.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>





  reply	other threads:[~2023-12-06  3:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 17:32 [PATCH net-next] ipv6: add debug checks in fib6_info_release() Eric Dumazet
2023-12-06  3:41 ` David Ahern [this message]
2023-12-07  3:10 ` patchwork-bot+netdevbpf
2023-12-07 13:29   ` Eric Dumazet
2023-12-07 16:43     ` Kui-Feng Lee
2023-12-07 18:06     ` Kui-Feng Lee
2023-12-07 18:10       ` Eric Dumazet
2023-12-07 18:19         ` Kui-Feng Lee
2023-12-07 18:22           ` Eric Dumazet
2023-12-07 18:25             ` David Ahern
2023-12-07 18:26               ` David Ahern
2023-12-07 18:36               ` Kui-Feng Lee
2023-12-07 18:40                 ` Kui-Feng Lee
2023-12-07 19:00                   ` Kui-Feng Lee
2023-12-07 19:05                     ` Eric Dumazet
2023-12-07 19:08                       ` Kui-Feng Lee
2023-12-07 19:14                         ` Eric Dumazet
2023-12-07 18:46             ` Kui-Feng Lee
2023-12-07 18:55               ` Eric Dumazet
2023-12-07 23:02 ` Kui-Feng Lee
2023-12-08  9:18   ` Eric Dumazet
2023-12-08 18:20     ` Kui-Feng Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee557d3b-79f1-4851-9473-99f711a78f2b@kernel.org \
    --to=dsahern@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.