From: Alejandro Colomar <colomar.6.4.3@gmail.com>
To: Konstantin Bukin <kbukin@gmail.com>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>,
linux-man@vger.kernel.org, mtk.manpages@gmail.com
Subject: Re: [PATCH] stat.2: fixed inode printing in example program
Date: Sun, 13 Sep 2020 20:30:47 +0200 [thread overview]
Message-ID: <ee5cc545-b04a-647f-e8e2-2692af9f1f8e@gmail.com> (raw)
In-Reply-To: <CAF98MAKanUQtQN18Rh1F-YEhUqFix9+6aWVHuqSPLWHrJA93TA@mail.gmail.com>
Hi Konstantin,
On 9/13/20 8:16 PM, Konstantin Bukin wrote:
>> Do you agree it solves this problem?
>
> No, that does not solve the problem. There is still casting to a
> signed resulting in printing negative inode.
True. The definition of ino_t is unsigned, so the example was wrong
from the beginning.
>
> Using %llu might be better since that would not require including an
> extra header.
We just had that discussion in this thread:
https://lore.kernel.org/linux-man/20200911231411.28406-1-colomar.6.4.3@gmail.com/T/#m971e4dcfae5f25e0f26c906679aa7176b6786bdf
We decided to go for [u]intmax_t. But the patch has not yet been
applied, so you arrive just in time to give reasons against it.
>
> Mind I'll send a new patch?
Sure.
Cheers,
Alex
next prev parent reply other threads:[~2020-09-13 18:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 15:04 [PATCH] stat.2: fixed inode printing in example program Konstantin Bukin
2020-09-13 15:16 ` Dmitry V. Levin
2020-09-13 17:24 ` Konstantin Bukin
2020-09-13 17:38 ` Dmitry V. Levin
2020-09-13 18:04 ` Alejandro Colomar
2020-09-13 18:16 ` Konstantin Bukin
2020-09-13 18:30 ` Alejandro Colomar [this message]
2020-09-13 18:42 ` Konstantin Bukin
2020-09-13 18:46 ` Alejandro Colomar
2020-09-13 19:12 ` Konstantin Bukin
2020-09-13 19:39 ` Konstantin Bukin
2020-09-13 19:40 ` Konstantin Bukin
2020-09-14 9:30 ` Michael Kerrisk (man-pages)
2020-09-13 18:04 ` Konstantin Bukin
-- strict thread matches above, loose matches on Subject: below --
2020-09-13 18:29 Konstantin Bukin
2020-09-13 18:43 ` Alejandro Colomar
2020-09-13 19:32 ` Konstantin Bukin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee5cc545-b04a-647f-e8e2-2692af9f1f8e@gmail.com \
--to=colomar.6.4.3@gmail.com \
--cc=kbukin@gmail.com \
--cc=ldv@altlinux.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.