From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48BADC4338F for ; Thu, 19 Aug 2021 04:49:58 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1A79610FE; Thu, 19 Aug 2021 04:49:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E1A79610FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mGa04-00083Z-7W; Thu, 19 Aug 2021 04:49:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGa01-00083S-ML for linux-f2fs-devel@lists.sourceforge.net; Thu, 19 Aug 2021 04:49:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=B0EJkXAubeYVR9YmsQUbWLH4qNhXcVxKlR/KnsrY/Cc=; b=UrVxnNcDntrJe0lP5t1VeKVaUu iZkRgInL/2wtsu/QE/4J1BDwaNVALs63P44B3ceehrKKQD+YMCT+CVULgZ2Od7U/D9PySnUsyiG9w s+8DrnCSgAbtAur7eHbBaaEyruPj2IECoP60O4my7P6Bi2ZckBoPWrgih6u8vyU1R8vw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=B0EJkXAubeYVR9YmsQUbWLH4qNhXcVxKlR/KnsrY/Cc=; b=HmtuJ/g7iJyuRjrUO6yuRmEjdn GUW9bWNpmR7IAvMjQIr68kow/LOJho7l59StVIMjLCQd2kZLrdlw2NYKHSwpUX7BTSMtWpjCFgFZP bA1j0rP0ruq6XQ/aK87BrG6bKv5BqnVAcZYH6cJ+HI7US1bMvonH2JRmA3HKhkHvhniM=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mGZzw-00BAeF-CA for linux-f2fs-devel@lists.sourceforge.net; Thu, 19 Aug 2021 04:49:53 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BB79D610CF; Thu, 19 Aug 2021 04:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629348579; bh=0Cg8oLWlkJnSS9ZcFq1U+zblisO3esXh0aghBm3X7GE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Dh/vU215RfcMd2KkH4rG/2rLm/jIZ7EZdfuyqnP4eq9xMTDxqXvzQCSVwTC9tQFiw u9LY5T0uGj2QeM1I0o82X2wNBlW9MNYA+ROLYNuB1DzCuLa1YVQBRw9yDoao78pcde 4YcVS1K7lji6lv88DrwLflWLjjvTeF8FPFTMYxAa31ZMy3l0e4x9uP5BLFCfs8YRG6 PnFxwYmm6a6DCBsdf/nk5Wr29DIVIPRsUba8Rl2uUTeUkLrIYg62ztounl8c5gtmYq wQARy19WaM7342+SVX5Pw+HkT2MKJfm8WGQyFJC69NJeFRPvehl3i3mGJXQaqfLnaR Lskps/U2dqEnA== To: =?UTF-8?B?5p2O5oms6Z+s?= References: From: Chao Yu Message-ID: Date: Thu, 19 Aug 2021 12:49:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Headers-End: 1mGZzw-00BAeF-CA Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: add sysfs nodes to get discard information X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMjAyMS84LzE2IDE0OjEzLCDmnY7miazpn6wgd3JvdGU6Cj4+Pj4+IEkndmUgYWRkZWQgbmV3 IHN5c2ZzIG5vZGVzIHRvIHNob3cgZGlzY2FyZCBzdGF0IHNpbmNlIG1vdW50LCB3aGljaAo+Pj4+ PiB3aWxsIGhlbHAgdXMgYW5hbHl6ZSB3aGV0aGVyIHRoZSBwZXJmb3JtYW5jZSBwcm9ibGVtIGlz IHJlbGF0ZWQgdG8KPj4+Pj4gZGlzY2FyZC4KPj4+Pj4KPj4+Pj4gaXNzdWVkX2Rpc2NhcmQgIC0g U2hvd3MgdGhlIG51bWJlciBvZiBpc3N1ZWQgZGlzY2FyZAo+Pj4+PiBxdWV1ZWRfZGlzY2FyZCAg LSBTaG93cyB0aGUgbnVtYmVyIG9mIGNhY2hlZCBkaXNjYXJkIGNtZCBjb3VudAo+Pj4+PiBkaXNj YXJkX2NtZF9jbnQgLSBTaG93cyB0aGUgbnVtYmVyIG9mIGNhY2hlZCBkaXNjYXJkIGNtZCBjb3Vu dAo+Pj4+PiB1bmRpc2NhcmRfYmxrcyAgLSBTaG93cyB0aGUgbnVtYmVyIG9mIHVuZGlzY2FyZCBi bG9ja3MKPj4+Pgo+Pj4+IFdlIGhhdmUgZXhwb3J0ZWQgdGhlbSBpbiBkZWJ1Z2ZzLCBjYW4geW91 IHVzZSB0aGF0Pwo+Pj4+Cj4+Pj4gVGhhbmtzLAo+Pj4KPj4+IEJ1dCBub3cgQW5kcm9pZCBpcyBm b3JiaWRkZW4gdG8gb3BlbiBkZWJ1Z2ZzLCBhbmQgaW4gZmFjdCB3ZSBoYXZlIG5vdAo+Pj4gb3Bl bmVkIHRoaXMgY29uZmlndXJhdGlvbiBmb3IgYSBsb25nIHRpbWUuCj4+Cj4+IFdlcmVuJ3QgdGhl bSBiZSB1c2VkIGZvciBkZWJ1ZyBwdXJwb3NlPyBjYW4geW91IHBsZWFzZSBleHBsYWluIG1vcmUg YWJvdXQKPj4geW91ciB1c2UgY2FzZT8KPiAKPiBEdXJpbmcgbG9uZy10ZXJtIGFnaW5nIHRlc3Qg b3Igbm9ybWFsIHVzZSwgc29tZXRpbWVzIHRoZXJlIHdpbGwgYmUgcGVyZm9ybWFuY2UKPiBkZWdy YWRhdGlvbiBwcm9ibGVtcy4gSXQgbWF5IGJlIGNhdXNlZCBieSBzdG9yYWdlLCBvciBpdCBtYXkg YmUgY2F1c2VkIGJ5IHRoZQo+IGZpbGVzeXN0ZW0uIEZvciBleGFtcGxlLCB0aGUgZmlsZXN5c3Rl bSBhY2N1bXVsYXRlcyBhIGxhcmdlIG51bWJlciBvZiB1bmRpc2NhcmQKPiAgIGJsb2Nrcy4gQWx0 aG91Z2ggdGhlcmUgaXMgc29tZSByZW1haW5pbmcgc3BhY2UsIHRoZSBhbmRyb2lkYmVuY2ggdGVz dCB3aWxsCj4gc2hvdyBwZXJmb3JtYW5jZSBkZWdyYWRhdGlvbi4gVGhlcmVmb3JlLCBpdCBpcyBu ZWNlc3NhcnkgdG8gZXhwb3J0IGluZm9ybWF0aW9uCj4gcmVsYXRlZCB0byBkaXNjYXJkIHNvIHRo YXQgd2UgY2FuIGNvbmZpcm0gdGhpcyBzaXR1YXRpb24uCgpJIGhhdmUgYSBzb2x1dGlvbiBmb3Ig eW91ciBjYXNlLCBob3dldmVyIGZpbmFsbHksIHdlIGhhdmVuJ3QgdXNlZCBzdWNoIGRpc2NhcmQK cG9saWN5IGJ5IGRlZmF1bHQgZHVlIHRvIHRoZSBwb2xpY3kgbmVlZHMgdG8gYmUgZGVzaWduZWQg bW9yZSB0dW5hYmxlIGZvcgpkZXZpY2VzIHdpdGggZGlmZmVyZW50IGNoYXJhY3RlcnMuCgpTZWUg bW9yZSBkZXRhaWxzIGluIGJlbG93IHBhdGNoZXM6CgpodHRwczovL2xrbWwub3JnL2xrbWwvMjAx OC84LzEwLzIxOQpodHRwczovL2xrbWwub3JnL2xrbWwvMjAxOC84LzEwLzIyMAoKVGhhbmtzLAoK PiAKPiBUaHgsCj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKTGludXgtZjJmcy1kZXZlbEBs aXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMv bGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B61DDC4338F for ; Thu, 19 Aug 2021 04:51:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80920610CF for ; Thu, 19 Aug 2021 04:51:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbhHSEuQ (ORCPT ); Thu, 19 Aug 2021 00:50:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:52068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbhHSEuP (ORCPT ); Thu, 19 Aug 2021 00:50:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BB79D610CF; Thu, 19 Aug 2021 04:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629348579; bh=0Cg8oLWlkJnSS9ZcFq1U+zblisO3esXh0aghBm3X7GE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Dh/vU215RfcMd2KkH4rG/2rLm/jIZ7EZdfuyqnP4eq9xMTDxqXvzQCSVwTC9tQFiw u9LY5T0uGj2QeM1I0o82X2wNBlW9MNYA+ROLYNuB1DzCuLa1YVQBRw9yDoao78pcde 4YcVS1K7lji6lv88DrwLflWLjjvTeF8FPFTMYxAa31ZMy3l0e4x9uP5BLFCfs8YRG6 PnFxwYmm6a6DCBsdf/nk5Wr29DIVIPRsUba8Rl2uUTeUkLrIYg62ztounl8c5gtmYq wQARy19WaM7342+SVX5Pw+HkT2MKJfm8WGQyFJC69NJeFRPvehl3i3mGJXQaqfLnaR Lskps/U2dqEnA== Subject: Re: [PATCH 1/2] f2fs: add sysfs nodes to get discard information To: =?UTF-8?B?5p2O5oms6Z+s?= Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: From: Chao Yu Message-ID: Date: Thu, 19 Aug 2021 12:49:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/16 14:13, 李扬韬 wrote: >>>>> I've added new sysfs nodes to show discard stat since mount, which >>>>> will help us analyze whether the performance problem is related to >>>>> discard. >>>>> >>>>> issued_discard - Shows the number of issued discard >>>>> queued_discard - Shows the number of cached discard cmd count >>>>> discard_cmd_cnt - Shows the number of cached discard cmd count >>>>> undiscard_blks - Shows the number of undiscard blocks >>>> >>>> We have exported them in debugfs, can you use that? >>>> >>>> Thanks, >>> >>> But now Android is forbidden to open debugfs, and in fact we have not >>> opened this configuration for a long time. >> >> Weren't them be used for debug purpose? can you please explain more about >> your use case? > > During long-term aging test or normal use, sometimes there will be performance > degradation problems. It may be caused by storage, or it may be caused by the > filesystem. For example, the filesystem accumulates a large number of undiscard > blocks. Although there is some remaining space, the androidbench test will > show performance degradation. Therefore, it is necessary to export information > related to discard so that we can confirm this situation. I have a solution for your case, however finally, we haven't used such discard policy by default due to the policy needs to be designed more tunable for devices with different characters. See more details in below patches: https://lkml.org/lkml/2018/8/10/219 https://lkml.org/lkml/2018/8/10/220 Thanks, > > Thx, > >