Re: [PATCH] station: Move netconfig_reset() to common path

[Denis Kenzior <denkenz at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

Hi Andrew,

> I don't remember what the reasoning was, but station_connect_cb does
> handle some mechanisms that seem desirable here also, like trying the
> next bss from the autoconnect list immediately and blacklisting BSSes.

The connect failed path is generally used if the connection simply fails. 
Either due to an invalid password, or due to handshake timeout, or some other 
reason where the status_code can be returned by netdev.  Once we're successfully 
connected, and the driver/kernel decides to disconnect us due to a firmware 
crash/bug/whatever, then I'm not sure blacklisting the bss should be done. 
Besides, we already sent the dbus message reply, etc.

Now, maybe some elements of what the connect failed path does might be needed in 
this failure case.  But to determine that we would need to know why the 
disconnect happens? How often? Is it every time? Sometimes? Once in a blue moon, 
etc.

> In this case it seems the problem was triggered by a driver problem
> (or our misunderstanding on when the radio is free for scanning) but
> if a specific BSS always fails during netconfig then we should
> blacklist it.
> 

Sure, but then these actions should be taken in the station_disassociated path, 
or a brand new path specifically for this case.

Regards,
-Denis