From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Alicja Michalska <ahplka19@gmail.com>
Cc: alsa-devel@alsa-project.org, upstream@semihalf.com,
rad@semihalf.com, pierre-louis.bossart@linux.intel.com,
tiwai@suse.com, hdegoede@redhat.com, broonie@kernel.org,
amadeuszx.slawinski@linux.intel.com, cujomalainey@chromium.org,
lma@semihalf.com
Subject: Re: [PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL
Date: Tue, 22 Nov 2022 19:10:50 +0100 [thread overview]
Message-ID: <ee8fb5be-e31b-2000-84de-85db5989ee92@intel.com> (raw)
In-Reply-To: <Y3wHyJ/EcsLRHGr3@tora>
On 2022-11-22 12:20 AM, Alicja Michalska wrote:
> KBL platform is missing the definition of 'max98357a' audio amplifier.
> This amplifier is used on many KBL Chromebooks, for instance variant
> 'nami' of 'Google/poppy' baseboard.
>
> Reported-by: CoolStar <coolstarorganization@gmail.com>
> Signed-off-by: Alicja Michalska <ahplka19@gmail.com>
>
> diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c
> index 87f9c18be238..650faebb33ef 100644
> --- a/sound/soc/intel/avs/board_selection.c
> +++ b/sound/soc/intel/avs/board_selection.c
> @@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
> },
> .tplg_filename = "max98373-tplg.bin",
> },
> + {
> + .id = "MX98357A",
> + .drv_name = "avs_max98357a",
> + .mach_params = {
> + .i2s_link_mask = AVS_SSP(0),
> + },
> + .tplg_filename = "max98357a-tplg.bin",
> + },
> {
> .id = "DLGS7219",
> .drv_name = "avs_da7219",
> ---
> sound/soc/intel/avs/board_selection.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c
> index 87f9c18be238..650faebb33ef 100644
> --- a/sound/soc/intel/avs/board_selection.c
> +++ b/sound/soc/intel/avs/board_selection.c
> @@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
> },
> .tplg_filename = "max98373-tplg.bin",
> },
> + {
> + .id = "MX98357A",
> + .drv_name = "avs_max98357a",
> + .mach_params = {
> + .i2s_link_mask = AVS_SSP(0),
> + },
> + .tplg_filename = "max98357a-tplg.bin",
> + },
> {
> .id = "DLGS7219",
> .drv_name = "avs_da7219",
Any reason why diff is repeated twice? It seems that the first copy of
diff is part of the commit message.
next prev parent reply other threads:[~2022-11-22 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 23:20 [PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL Alicja Michalska
2022-11-22 0:36 ` Curtis Malainey
2022-11-22 18:03 ` Cezary Rojewski
2022-11-22 18:10 ` Cezary Rojewski [this message]
2022-11-22 20:49 ` Alicja Michalska
2022-11-23 11:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee8fb5be-e31b-2000-84de-85db5989ee92@intel.com \
--to=cezary.rojewski@intel.com \
--cc=ahplka19@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cujomalainey@chromium.org \
--cc=hdegoede@redhat.com \
--cc=lma@semihalf.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rad@semihalf.com \
--cc=tiwai@suse.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.