From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Alexandra Winter <wintera@linux.ibm.com>
Cc: Julian Ruess <julianr@linux.ibm.com>,
Mete Durlu <meted@linux.ibm.com>,
"D. Wythe" <alibuda@linux.alibaba.com>,
Dust Li <dust.li@linux.alibaba.com>,
Sidraya Jayagond <sidraya@linux.ibm.com>,
Wenjia Zhang <wenjia@linux.ibm.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Mahanta Jambigi <mjambigi@linux.ibm.com>,
Tony Lu <tonylu@linux.alibaba.com>,
Wen Gu <guwen@linux.alibaba.com>, <linux-rdma@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-s390@vger.kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next 1/2] dibs: Remove reset of static vars in dibs_init()
Date: Thu, 23 Oct 2025 17:16:17 +0200 [thread overview]
Message-ID: <eea7d0ea-4aec-4f95-8a0d-e9765225fe48@intel.com> (raw)
In-Reply-To: <20251023150636.3995476-1-wintera@linux.ibm.com>
From: Alexandra Winter <wintera@linux.ibm.com>
Date: Thu, 23 Oct 2025 17:06:35 +0200
> 'clients' and 'max_client' are static variables and therefore don't need to
> be initialized.
>
> Reported-by: Mete Durlu <meted@linux.ibm.com>
> Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
> drivers/dibs/dibs_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
> index 0374f8350ff7..b015578b4d2e 100644
> --- a/drivers/dibs/dibs_main.c
> +++ b/drivers/dibs/dibs_main.c
> @@ -254,9 +254,6 @@ static int __init dibs_init(void)
> {
> int rc;
>
> - memset(clients, 0, sizeof(clients));
> - max_client = 0;
> -
> dibs_class = class_create("dibs");
> if (IS_ERR(dibs_class))
> return PTR_ERR(dibs_class);
Thanks,
Olek
next prev parent reply other threads:[~2025-10-23 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 15:06 [PATCH net-next 1/2] dibs: Remove reset of static vars in dibs_init() Alexandra Winter
2025-10-23 15:06 ` [PATCH net-next 2/2] dibs: Use subsys_initcall() Alexandra Winter
2025-10-23 15:18 ` Alexander Lobakin
2025-10-24 9:07 ` Alexandra Winter
2025-10-23 15:16 ` Alexander Lobakin [this message]
2025-10-24 2:26 ` [PATCH net-next 1/2] dibs: Remove reset of static vars in dibs_init() Dust Li
2025-10-28 12:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eea7d0ea-4aec-4f95-8a0d-e9765225fe48@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=agordeev@linux.ibm.com \
--cc=alibuda@linux.alibaba.com \
--cc=andrew+netdev@lunn.ch \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=guwen@linux.alibaba.com \
--cc=hca@linux.ibm.com \
--cc=horms@kernel.org \
--cc=julianr@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=meted@linux.ibm.com \
--cc=mjambigi@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sidraya@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.