From: Jun Guo <jun.guo@cixtech.com>
To: Rob Herring <robh@kernel.org>
Cc: peter.chen@cixtech.com, fugang.duan@cixtech.com,
krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
ychuang3@nuvoton.com, schung@nuvoton.com, robin.murphy@arm.com,
Frank.Li@kernel.org, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
cix-kernel-upstream@cixtech.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/3] dt-bindings: dma: arm-dma350: document combined and per-channel IRQ topologies
Date: Wed, 8 Apr 2026 14:39:16 +0800 [thread overview]
Message-ID: <eea87be5-5257-4ed2-b8f4-42c35889fd05@cixtech.com> (raw)
In-Reply-To: <20260407172014.GA3090142-robh@kernel.org>
Hi Rob,
Thanks for your review. I have already resubmitted the V6 patch. Please
take a look at the latest v6 patch when you have time, as it includes
considerable changes compared to the v5 version.
On 4/8/2026 1:20 AM, Rob Herring wrote:
> EXTERNAL EMAIL
>
> On Tue, Mar 24, 2026 at 08:01:11PM +0800, Jun Guo wrote:
>> Document the interrupt topologies supported by DMA-350 integration:
>> - one combined interrupt for all channels, or
>> - one interrupt per channel (up to 8 channels).
>>
>> Assisted-by: Cursor:GPT-5.3-Codex
>> Signed-off-by: Jun Guo <jun.guo@cixtech.com>
>> ---
>> .../devicetree/bindings/dma/arm,dma-350.yaml | 25 ++++++++++++-------
>> 1 file changed, 16 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/arm,dma-350.yaml b/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
>> index 429f682f15d8..bec9dc32541b 100644
>> --- a/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
>> +++ b/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
>> @@ -22,15 +22,22 @@ properties:
>>
>> interrupts:
>> minItems: 1
>> - items:
>> - - description: Channel 0 interrupt
>> - - description: Channel 1 interrupt
>> - - description: Channel 2 interrupt
>> - - description: Channel 3 interrupt
>> - - description: Channel 4 interrupt
>> - - description: Channel 5 interrupt
>> - - description: Channel 6 interrupt
>> - - description: Channel 7 interrupt
>> + maxItems: 8
>
> Don't need maxItems
>
>> + description:
>> + Either one interrupt per channel (8 interrupts), or one
>> + combined interrupt for all channels.
>> + oneOf:
>> + - items:
>> + - description: Channel 0 interrupt
>> + - description: Channel 1 interrupt
>> + - description: Channel 2 interrupt
>> + - description: Channel 3 interrupt
>> + - description: Channel 4 interrupt
>> + - description: Channel 5 interrupt
>> + - description: Channel 6 interrupt
>> + - description: Channel 7 interrupt
>> + - items:
>> + - description: Combined interrupt shared by all channels
>>
>> "#dma-cells":
>> const: 1
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2026-04-08 6:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 12:01 [PATCH v5 0/3] dmaengine: arm-dma350: support combined IRQ mode with runtime IRQ topology detection Jun Guo
2026-03-24 12:01 ` [PATCH v5 1/3] dt-bindings: dma: arm-dma350: document combined and per-channel IRQ topologies Jun Guo
2026-04-07 17:20 ` Rob Herring
2026-04-08 6:39 ` Jun Guo [this message]
2026-03-24 12:01 ` [PATCH v5 2/3] dma: arm-dma350: support combined IRQ mode with runtime IRQ topology detection Jun Guo
2026-03-24 12:01 ` [PATCH v5 3/3] arm64: dts: cix: add DT nodes for DMA Jun Guo
2026-03-24 13:36 ` [PATCH v5 0/3] dmaengine: arm-dma350: support combined IRQ mode with runtime IRQ topology detection Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eea87be5-5257-4ed2-b8f4-42c35889fd05@cixtech.com \
--to=jun.guo@cixtech.com \
--cc=Frank.Li@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=schung@nuvoton.com \
--cc=vkoul@kernel.org \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.