From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: Wait for pending flips in intel_pipe_set_base() Date: Wed, 31 Oct 2012 17:43:16 +0000 Message-ID: References: <1351705121-17627-1-git-send-email-ville.syrjala@linux.intel.com> <1351705121-17627-3-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0468794795==" Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 48941A0E9B for ; Wed, 31 Oct 2012 10:43:59 -0700 (PDT) In-Reply-To: <1351705121-17627-3-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0468794795== Content-Type: text/plain On Wed, 31 Oct 2012 19:38:41 +0200, ville.syrjala@linux.intel.com wrote: > From: Ville Syrjälä > > intel_pipe_set_base() never actually waited for any pending page flips > on the CRTC. It looks like it tried to, by calling intel_finish_fb() on > the current front buffer. But the pending flips were actually tracked > in the BO of the previous front buffer, so the call to intel_finish_fb() > never did anything useful. > > Now even the pending_flip counter is gone, so we should just > use intel_crtc_wait_for_pending_flips(), but since we're already holding > struct_mutex when we would call that function, we need another version > of it, that itself doesn't lock struct_mutex. That function call is now superfluous as you pointed out in an earlier review... But yes, not waking up the pending_flip_queue after a GPU hang is a recent bug, and could explain the lockup in https://bugs.freedesktop.org/show_bug.cgi?id=56337. -Chris -- Chris Wilson, Intel Open Source Technology Centre --===============0468794795== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0468794795==--