From: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Ben Widawsky <ben@bwidawsk.net>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/5 v5] drm/i915: Stop using AGP layer for GEN6+
Date: Fri, 09 Nov 2012 18:35:21 +0000 [thread overview]
Message-ID: <eeac1e$4uo71e@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1352049691-2810-1-git-send-email-ben@bwidawsk.net>
On Sun, 4 Nov 2012 09:21:27 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> void i915_gem_gtt_bind_object(struct drm_i915_gem_object *obj,
> enum i915_cache_level cache_level)
> {
> struct drm_device *dev = obj->base.dev;
> - unsigned int agp_type = cache_level_to_agp_type(dev, cache_level);
> + if (INTEL_INFO(dev)->gen < 6) {
> + unsigned int flags = (cache_level == I915_CACHE_LLC) ?
> + AGP_USER_CACHED_MEMORY : AGP_USER_MEMORY;
And we still failed to get this right. :(
cache_level == I915_CACHE_NONE ? AGP_USER_MEMORY : AGP_USER_CACHED_MEMORY;
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-11-09 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 17:21 [PATCH 1/5 v5] drm/i915: Stop using AGP layer for GEN6+ Ben Widawsky
2012-11-04 17:21 ` [PATCH 2/5] drm/i915: Calculate correct stolen size for GEN7+ Ben Widawsky
2012-11-04 17:21 ` [PATCH 3/5 v2] drm/i915: Kill off now unused gen6+ AGP code Ben Widawsky
2012-11-04 17:21 ` [PATCH 4/5 v2] drm/i915: flush system agent TLBs on SNB Ben Widawsky
2012-11-04 17:21 ` [PATCH 5/5] drm/i915: Move the remaining gtt code Ben Widawsky
2012-11-04 22:17 ` Daniel Vetter
2012-11-09 18:35 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eeac1e$4uo71e@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.