From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 1/5 v5] drm/i915: Stop using AGP layer for
	GEN6+
Date: Fri, 09 Nov 2012 18:35:21 +0000
Message-ID: <eeac1e$4uo71e@AZSMGA002.ch.intel.com>
References: <1352049691-2810-1-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id E91A69E80D
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  9 Nov 2012 10:35:31 -0800 (PST)
In-Reply-To: <1352049691-2810-1-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sun,  4 Nov 2012 09:21:27 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
>  void i915_gem_gtt_bind_object(struct drm_i915_gem_object *obj,
>  			      enum i915_cache_level cache_level)
>  {
>  	struct drm_device *dev = obj->base.dev;
> -	unsigned int agp_type = cache_level_to_agp_type(dev, cache_level);
> +	if (INTEL_INFO(dev)->gen < 6) {
> +		unsigned int flags = (cache_level == I915_CACHE_LLC) ?
> +			AGP_USER_CACHED_MEMORY : AGP_USER_MEMORY;

And we still failed to get this right. :(
  cache_level == I915_CACHE_NONE ? AGP_USER_MEMORY : AGP_USER_CACHED_MEMORY;
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre