From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 4/4] drm/i915: only call intel_prepare_ddi if HAS_DDI Date: Fri, 23 Nov 2012 17:54:34 +0000 Message-ID: References: <1353691840-9913-1-git-send-email-przanoni@gmail.com> <1353691840-9913-4-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id EEB0DE5EFB for ; Fri, 23 Nov 2012 09:54:41 -0800 (PST) In-Reply-To: <1353691840-9913-4-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Fri, 23 Nov 2012 15:30:40 -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > In other words, move the check from inside the function to outside it. Don't agree with this last step. You can make the function tidier with an early return, but it is paramount that the high level sequence inside intel_modeset_init_hw() be clear and comprehendable. -Chris -- Chris Wilson, Intel Open Source Technology Centre