From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/4] drm/i915: Always clear semaphore mboxes on seqno wrap Date: Mon, 17 Dec 2012 19:15:40 +0000 Message-ID: References: <1355762669-6806-1-git-send-email-mika.kuoppala@intel.com> <1355762669-6806-2-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 87E22E5C24 for ; Mon, 17 Dec 2012 11:15:54 -0800 (PST) In-Reply-To: <1355762669-6806-2-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 17 Dec 2012 18:44:27 +0200, Mika Kuoppala wrote: > We need to clear the hw semaphore values explicitly. > Even if sync_seqnos are zero, there might still be > invalid values in the hw semaphores when we wrap. This changelog does not make it clear why you want this patch. This is for enabling a future feature, right? Anyway, after initial misgivings because I thought you were trying to fix a bug rather than add a feature, and provided that you improve the changelog, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre