From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A8B1C3DA7A for ; Mon, 2 Jan 2023 13:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ad93jy4nGmiAxBFqZL+WajJtEDD12VYYg2Ox7Jp8cOc=; b=myAPHKpg5JqDDU DG54PBQ/ifdBaqEja6tE5iYcYAEtyfNpCrLzsVULUsbCuuMkv1NCWBQUcP0wPid/Gv8vgWi6svDf8 g74Om5rAcdDojH5CaI4ss1kRusiki6x4sJ0mitdlh9X0nLondj9+3ET4UFqwQjCo3xfXJf0BF9v81 hXw1Hoi7vutkR7MdOTAgrHqz01gmKfcZDUH1CNUmNKMtStSzOOuH7Wwgnbii8XZ7eA30VN1gsvzxB YsbzwOrlxUpCytVXYuI8mVCpFvgFB/8D/1bTWrdNk98MfD7hgUtSfjY5uLG8y8pIf85RXI9nMzDoE 8BpFNEHH4ezqX+zmmkgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCLEU-00Bcjm-Cn; Mon, 02 Jan 2023 13:52:06 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCLEE-00BcfW-PY for linux-arm-kernel@lists.infradead.org; Mon, 02 Jan 2023 13:51:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672667506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yafyz4ioVVvoQAhwV2aIRVvfD9yfwhAh4dPTo7SXFJY=; b=SbGAmqTDs85+QPY3fBBL8d/iNFN4cm2IWZKLg9uuJg/weKA3lzN6OvBzxT9mZhlhlec8Cu wQnCr8s4zvY+cyu9VSA2SlIhPQf9/jOk26S4CQD22xJPFaKYejt8sa8P21BlYe9MjtmrN6 xao+EqKb6r1TfWyT6OVMTAzsVNhFAMo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-45-WfzX-iuZNAmiU3uCc3wA7g-1; Mon, 02 Jan 2023 08:51:44 -0500 X-MC-Unique: WfzX-iuZNAmiU3uCc3wA7g-1 Received: by mail-wm1-f69.google.com with SMTP id m38-20020a05600c3b2600b003d23f8c6ebdso10422410wms.0 for ; Mon, 02 Jan 2023 05:51:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yafyz4ioVVvoQAhwV2aIRVvfD9yfwhAh4dPTo7SXFJY=; b=CrxnGtVqeXkkU/REEmAYWqFucse9KI0To2lybkZJY9tT+wPPZ18UTxpQ1ZqKv5Jewi UCH3kcS9KqJAWNJUL9t4ScIxV0/OSmRD7eQqGdL5eXxMv25FdPdO9inlZHXbnXcv5a3j hnp33iTp/LHpKbBHIJUp35thOq95dPsfFo35ps7CdfkM9wyg0MPbEZvEC3DRmbEyuRxS AKqJ6kL8ABvFZsx8UThNQ+s1nBLOnRnqHJLD9AJkvueDcg6PiZy3MZnfMWBWJpv2dWs/ Z4AS2hLLkY2rYSVGCwR6oNGlCm12wgITaAx4wobS7WoBVwxjb77OD14CL69RHNTY7cWy n6qw== X-Gm-Message-State: AFqh2krhP8JngA4blX8TxGoWirbjM3aYu9U1gQQTOtERYODjvRPBOqn3 Tr3lPOU2bQkYi2okOSAyfuy93lS0xeJ6cXi2xX9JOMc2WJ3SZ6nbRHeV3/BILLzpeRt0D828xwE C0/7L1JG1/n4GjRiF4UC/YvIW+r42vWlhElY= X-Received: by 2002:a05:600c:3d0e:b0:3d2:3ca2:2d4f with SMTP id bh14-20020a05600c3d0e00b003d23ca22d4fmr31097429wmb.36.1672667503871; Mon, 02 Jan 2023 05:51:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXvbJtUehka09TTHzpZ3/tNKAm+H+SNwIOl23IORGJcibzel5onetyN+N+qYZrSa/x/EZ634SA== X-Received: by 2002:a05:600c:3d0e:b0:3d2:3ca2:2d4f with SMTP id bh14-20020a05600c3d0e00b003d23ca22d4fmr31097417wmb.36.1672667503668; Mon, 02 Jan 2023 05:51:43 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id f18-20020a05600c4e9200b003d35c845cbbsm48786206wmq.21.2023.01.02.05.51.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jan 2023 05:51:43 -0800 (PST) Message-ID: Date: Mon, 2 Jan 2023 14:51:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver To: =?UTF-8?Q?Ond=c5=99ej_Jirman?= , linux-kernel@vger.kernel.org, =?UTF-8?Q?Kamil_Trzci=c5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-3-javierm@redhat.com> <20221230154043.7v3zmzqdrnouqzd2@core> <7120dfd4-305f-69ac-fee8-123196ed06a9@redhat.com> <20230102105915.gbfhletcm4dunrlf@core> From: Javier Martinez Canillas In-Reply-To: <20230102105915.gbfhletcm4dunrlf@core> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230102_055150_975898_C95CA7A4 X-CRM114-Status: GOOD ( 26.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gT25kxZllaiwKCk9uIDEvMi8yMyAxMTo1OSwgT25kxZllaiBKaXJtYW4gd3JvdGU6Cgpb Li4uXQoKPj4gWWVzLCBiZWNhdXNlIGFzIHlvdSBzYWlkIHdlcmUgZGVidWcgcHJpbnRrcy4gRmVl bCBmcmVlIHRvIHByb3Bvc2UgYWRkaW5nIHRoZQo+PiBkZWJ1ZyBwcmludGtzIGlmIHlvdSBjb25z aWRlciB1c2VmdWwgZm9yIG5vcm1hbCB1c2FnZSBhbmQgbm90IGp1c3QgZm9yIGRldmVsCj4+IHB1 cnBvc2VzLgo+IAo+IEkgYWxyZWFkeSBkaWQsIGFuZCB1c2VkIHRoZW0gZG8gZGVidWcgYW5kIGZp eCB0aGUgaXNzdWVzLiBUaGlzIHN1Ym1pc3Npb24ganVzdAo+IGRvZXNuJ3QgaW5jbHVkZSB0aGUg Zml4ZXMuCj4KCkkgbWlzc2VkIHRoZSBmaXhlcywgSSB0aGluayB0aGF0IGNoZXJyeS1waWNrZWQg YW5kIHNxdWFzaGVkIGZyb20geW91ciB0cmVlCmJlZm9yZSB5b3UgYWRkZWQgY29tbWl0IGYxOWNl N2JiN2Q3MiAoImFybTY0OiBkdHM6IHJrMzM5OS1waW5lcGhvbmUtcHJvOgpVc2UgdW51c2VkIEdQ TEwgZm9yIFZPUHMgRENMSyIpIGF0IGxlYXN0LgogCj4+PiBob29rcy4gSGF2ZSB5b3UgdGVzdGVk IHRoZSBkcml2ZXIgdGhvcm91Z2hseSB3aXRoIHZhcmlvdXMgRFJNIGFwcHMsCj4+PiB3aXRoIERQ TS9zdXNwZW5kL3Jlc3VtZSwgZXRjLj8KPj4+Cj4+Cj4+IEkgZGlkIG5vdC4gSSB3YXNuJ3QgZXhw ZWN0aW5nIHN1c3BlbmQgYW5kIHJlc3VtZSB0byB3b3JrIG9uIHRoZSBQUFAgZ2l2ZW4gaXRzCj4+ IHN1cHBvcnQgaXMgcXVpdGUgbWluaW1hbCBjdXJyZW50bHkuCj4gCj4gU3lzdGVtIHN1c3BlbmQv cmVzdW1lIHdvcmtzIGFuZCBpcyB1c2VkIGJ5IGRpc3RyaWJ1dGlvbnMuIERpc3BsYXkgYmxhbmtp bmcgaXMKPiBhbHNvIHVzZWQgYnkgbm9ybWFsIGRpc3Ryb3MsIGV2ZW4gaWYgeW91IGRvbid0IHVz ZSBzeXN0ZW0gc3VzcGVuZC9yZXN1bWUuCj4KCkkga25vdyBidXQgbXkgcG9pbnQgd2FzIHRoYXQg dGhlIFBQUCBtYWlubGluZSBzdXBwb3J0IGlzbid0IHJlYWR5IHRvIGJlIHVzZWQKYXMgYSBkYWls eSBkcml2ZXIgaW4gcHJhY3RpY2UuIFNvIEkgZGlkbid0IGNvbnNpZGVyIHN1c3BlZC9yZXN1bWUg b3IgZGlzcGxheQpibGFuayBhcyBhIHJlcXVpcmVtZW50IHRvIHVwc3RyZWFtIGFuIGluaXRpYWwg c3VwcG9ydCBmb3IgdGhlIHBhbmVsIGRyaXZlci4KClsuLi5dCgo+Pj4gQWxzbywgaGF2ZSB5b3Ug Y2hlY2tlZCB0aGUgY2xvY2tzIGFyZSBhY3R1YWxseSBjb25maWd1cmVkIGNvcnJlY3RseSBieSB0 aGUKPj4+IHJrMzM5OSBjcnUgZHJpdmVyPyBJIGhhdmUgYSBsb3Qgb2YgdHJvdWJsZSB3aXRoIHRo YXQsIHRvby4gY2xrIGRyaXZlciBzb21ldGltZXMKPj4+IHNlbGVjdHMgdGhlIGZyYWN0aW9uYWwg Y2xvY2ssIGJ1dCBkb2VzIG5vdCBnaXZlIGl0IHRoZSBuZWNlc3NhcnkgPjIweCBkaWZmZXJlbmNl Cj4+PiBiZXR3ZWVuIGlucHV0L291dHB1dCBjbG9jayByYXRlcy4gWW91J2xsIG9ubHkgbm90aWNl IGlmIHlvdSBtZWFzdXJlIGNsb2NrIHJhdGVzCj4+PiBkaXJlY3RseSwgYnkgbG9va2luZyBhdCBh Y3R1YWwgcmVmcmVzaCByYXRlLCBieSB1c2luZyBzb21lIHRlc3RpbmcgRFJNIGFwcC4KPj4+IENs b2NrIHN1YnN5c3RlbSBzb21ldGltZXMgc2h1ZmZsZXMgdGhpbmdzIGFyb3VuZCBpZiB5b3Ugc3dp dGNoIFZPUHMgYW5kIHVzZSBiaWcKPj4+IFZPUCBmb3IgbWlwaS1kc2kgZGlzcGxheSwgaW5zdGVh ZCBvZiB0aGUgZGVmYXVsdCBzbWFsbCBWT1AuCj4+Pgo+Pgo+PiBJIGhhdmUgbm90LiBKdXN0IHZl cmlmaWVkIHRoYXQgdGhlIGRpc3BsYXkgd2FzIHdvcmtpbmcgb24gbXkgUFBQIGFuZCBjb3VsZCBz dGFydAo+PiBhIG11dHRlciB3YXlsYW5kIHNlc3Npb24uIFdlIGNvdWxkIGZpeCB0aGUgY2xvY2sg Y29uZmlndXJhdGlvbiBhcyBmb2xsb3ctdXAgSU1PLgo+IAo+IFRoZSBkaXNwbGF5IG91dHB1dCB3 aWxsIGJlIGJyb2tlbiBhZnRlciB5b3UgZml4IHRoZSBhc3NpZ25lZC1jbG9ja3MgaW4gRFQgdG8K PiBleHBlY3RlZCB2YWx1ZXMgKHVzZSBHUExMIHBhcmVudCwgdG8gbWFrZSB0aGUgSFcgZ2VuZXJh dGUgdGhlIGV4YWN0IHBpeGVsIGNsb2NrCj4gZGVmaW5lZCBpbiB0aGUgZGlzcGxheSBtb2RlKS4g U28gdGhpcyBuZWVkcyB0byBiZSBkZWFsdCB3aXRoIG5vdywgbm90IGxhdGVyLgo+IAo+IAo+IFRo ZSBkcml2ZXIgaXNzdWVzIGFyZSBhbGwga25vd24gYXQgdGhpcyB0aW1lIGFuZCBoYXZlIGZpeGVz IGF2YWlsYWJsZSwgdW5saWtlCj4gYSB5ZWFyIGFnbzoKPiAKCk15IGdvYWwgd2FzIHRvIGhhdmUg c29tZSBpbml0aWFsIHN1cHBvcnQgaW4gbWFpbmxpbmUgZXZlbiBpZiB0aGVyZSBjb3VsZCBiZSBz b21lCmlzc3Vlcy4gSU1PIGl0IGlzIGJldHRlciB0byB1c2UgdXBzdHJlYW0gYXMgYSBiYXNlbGlu ZSBhbmQgYXR0ZW1wdCB0byBzdXBwb3J0IHRoZQpQUFAgaW5jcmVtZW50YWxseS4KCkJ1dCBzaW5j ZSB5b3UgYXJlIGF3YXJlIG9mIHRoZSBpc3N1ZXMgYW5kIGtub3cgd2hhdCBhcmUgdGhlIGF2YWls YWJsZSBmaXhlcywgSSdsbApsZXQgeW91IGNvbnRpbnVlIHdpdGggdGhlIGVmZm9ydCBhbmQgdGFr ZSBjYXJlIG9mIHRoZSBwYXRjaGVzLiBIb3BlZnVsbHkgdGhlcmUgbWF5CmJlIHRoaW5ncyB0aGF0 IHdpbGwgYmUgaGVscGZ1bCwgc3VjaCBhcyB0aGUgYmluZGluZyBzY2hlbWEgcGF0Y2ggYW5kIHRo ZSBjb2xsZWN0ZWQKdGFncy4gSSBjYW4gYWxzbyB0YWtlIGNhcmUgb2YgcHVzaGluZyB0aGUgRFJN IGJpdHMgdG8gdGhlIGRybS1taXNjLW5leHQgdHJlZSBvbmNlCnlvdSBmZWVsIHRoYXQgdGhvc2Ug YXJlIHJlYWR5IHRvIGdldCBtZXJnZWQuCgotLSAKQmVzdCByZWdhcmRzLAoKSmF2aWVyIE1hcnRp bmV6IENhbmlsbGFzCkNvcmUgUGxhdGZvcm1zClJlZCBIYXQKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD855C3DA7A for ; Mon, 2 Jan 2023 13:51:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1098A10E33D; Mon, 2 Jan 2023 13:51:49 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4836710E30C for ; Mon, 2 Jan 2023 13:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672667506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yafyz4ioVVvoQAhwV2aIRVvfD9yfwhAh4dPTo7SXFJY=; b=SbGAmqTDs85+QPY3fBBL8d/iNFN4cm2IWZKLg9uuJg/weKA3lzN6OvBzxT9mZhlhlec8Cu wQnCr8s4zvY+cyu9VSA2SlIhPQf9/jOk26S4CQD22xJPFaKYejt8sa8P21BlYe9MjtmrN6 xao+EqKb6r1TfWyT6OVMTAzsVNhFAMo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-45-GEUwwVr3M8m4HIjq9B3t8w-1; Mon, 02 Jan 2023 08:51:45 -0500 X-MC-Unique: GEUwwVr3M8m4HIjq9B3t8w-1 Received: by mail-wm1-f71.google.com with SMTP id m38-20020a05600c3b2600b003d23f8c6ebdso10422412wms.0 for ; Mon, 02 Jan 2023 05:51:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yafyz4ioVVvoQAhwV2aIRVvfD9yfwhAh4dPTo7SXFJY=; b=HBamu4UWPy5M2x6kOjg+U1nEuFoldnOfDiLGCikG29SmtN2JZ9tGaaK2Unf2SZSrnN WwqVn1Mt1+5olSjFEVaJODfSW4kIsifF7O+ngFtDb82mcx3CvL5XIF5avm27McjI8ki7 hykvXZ9jaT+SUABWSNhRB9mFQ5tBdnko0ZIvr+SQwWRBo80LeT6LhWva+n40g3GWZYbX uA3t7CD+l9B+V94wTLVunVk2FWVuXvb04c7mFEjfGLvN12+oy8s/zD21sRTLxegKJiJC 6nNzLBukI0Gn9yL71meL5N45GthKV/490JPFh2yI9VEE4TM4v1NfRmsB9NBjegD4/dQF MJFg== X-Gm-Message-State: AFqh2kpPIQzh8dEQXDGSJcUL7sCXDpRIG9sbRU2uqILaqEyPt5O1yBn7 lE1/9wA3SCo4NpsZJ4WyYWlkCGNa9+NPhJs3UD1cb0c8DIVgEzUSG8768YI5HWZ/JTDEc+sC+mX NDfIPDbfBE8zzQzsjCzKCq2x4/74V X-Received: by 2002:a05:600c:3d0e:b0:3d2:3ca2:2d4f with SMTP id bh14-20020a05600c3d0e00b003d23ca22d4fmr31097439wmb.36.1672667503873; Mon, 02 Jan 2023 05:51:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXvbJtUehka09TTHzpZ3/tNKAm+H+SNwIOl23IORGJcibzel5onetyN+N+qYZrSa/x/EZ634SA== X-Received: by 2002:a05:600c:3d0e:b0:3d2:3ca2:2d4f with SMTP id bh14-20020a05600c3d0e00b003d23ca22d4fmr31097417wmb.36.1672667503668; Mon, 02 Jan 2023 05:51:43 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id f18-20020a05600c4e9200b003d35c845cbbsm48786206wmq.21.2023.01.02.05.51.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jan 2023 05:51:43 -0800 (PST) Message-ID: Date: Mon, 2 Jan 2023 14:51:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver To: =?UTF-8?Q?Ond=c5=99ej_Jirman?= , linux-kernel@vger.kernel.org, =?UTF-8?Q?Kamil_Trzci=c5=84ski?= , Martijn Braam , Sam Ravnborg , Robert Mader , Tom Fitzhenry , Peter Robinson , Onuralp Sezer , dri-devel@lists.freedesktop.org, Maya Matuszczyk , Neal Gompa , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Jagan Teki , Daniel Vetter , David Airlie , Thierry Reding References: <20221230113155.3430142-1-javierm@redhat.com> <20221230113155.3430142-3-javierm@redhat.com> <20221230154043.7v3zmzqdrnouqzd2@core> <7120dfd4-305f-69ac-fee8-123196ed06a9@redhat.com> <20230102105915.gbfhletcm4dunrlf@core> From: Javier Martinez Canillas In-Reply-To: <20230102105915.gbfhletcm4dunrlf@core> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Ondřej, On 1/2/23 11:59, Ondřej Jirman wrote: [...] >> Yes, because as you said were debug printks. Feel free to propose adding the >> debug printks if you consider useful for normal usage and not just for devel >> purposes. > > I already did, and used them do debug and fix the issues. This submission just > doesn't include the fixes. > I missed the fixes, I think that cherry-picked and squashed from your tree before you added commit f19ce7bb7d72 ("arm64: dts: rk3399-pinephone-pro: Use unused GPLL for VOPs DCLK") at least. >>> hooks. Have you tested the driver thoroughly with various DRM apps, >>> with DPM/suspend/resume, etc.? >>> >> >> I did not. I wasn't expecting suspend and resume to work on the PPP given its >> support is quite minimal currently. > > System suspend/resume works and is used by distributions. Display blanking is > also used by normal distros, even if you don't use system suspend/resume. > I know but my point was that the PPP mainline support isn't ready to be used as a daily driver in practice. So I didn't consider susped/resume or display blank as a requirement to upstream an initial support for the panel driver. [...] >>> Also, have you checked the clocks are actually configured correctly by the >>> rk3399 cru driver? I have a lot of trouble with that, too. clk driver sometimes >>> selects the fractional clock, but does not give it the necessary >20x difference >>> between input/output clock rates. You'll only notice if you measure clock rates >>> directly, by looking at actual refresh rate, by using some testing DRM app. >>> Clock subsystem sometimes shuffles things around if you switch VOPs and use big >>> VOP for mipi-dsi display, instead of the default small VOP. >>> >> >> I have not. Just verified that the display was working on my PPP and could start >> a mutter wayland session. We could fix the clock configuration as follow-up IMO. > > The display output will be broken after you fix the assigned-clocks in DT to > expected values (use GPLL parent, to make the HW generate the exact pixel clock > defined in the display mode). So this needs to be dealt with now, not later. > > > The driver issues are all known at this time and have fixes available, unlike > a year ago: > My goal was to have some initial support in mainline even if there could be some issues. IMO it is better to use upstream as a baseline and attempt to support the PPP incrementally. But since you are aware of the issues and know what are the available fixes, I'll let you continue with the effort and take care of the patches. Hopefully there may be things that will be helpful, such as the binding schema patch and the collected tags. I can also take care of pushing the DRM bits to the drm-misc-next tree once you feel that those are ready to get merged. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat