Re: [Intel-xe] [PATCH v2 6/8] drm/xe: Include GT ID in error message if TLB invalidation times out

["Das, Nirmoy" <nirmoy.das@linux.intel.com>]

I missed it. I have sent a very similar patch which now merged.

Tried this series on a MTL  and I can confirm it fixes driver load.


On 4/13/2023 12:52 AM, Matt Roper wrote:
> This will hopefully help debug TLB invalidation problems.
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> index f279e21300aa..796403b82531 100644
> --- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> +++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> @@ -285,8 +285,8 @@ int xe_gt_tlb_invalidation_wait(struct xe_gt *gt, int seqno)
>   				 tlb_invalidation_seqno_past(gt, seqno),
>   				 TLB_TIMEOUT);
>   	if (!ret) {
> -		drm_err(&xe->drm, "TLB invalidation time'd out, seqno=%d, recv=%d\n",
> -			seqno, gt->tlb_invalidation.seqno_recv);
> +		drm_err(&xe->drm, "TLB invalidation time'd out on GT%d, seqno=%d, recv=%d\n",
> +			gt->info.id, seqno, gt->tlb_invalidation.seqno_recv);
>   		return -ETIME;
>   	}
>